Merged
Conversation
hatal175
reviewed
Jun 16, 2025
| /* 0x5C0 */ mDoExt_brkAnm* mBrkAnm; | ||
| /* 0x5C4 */ Z2CreatureEnemy mSound; | ||
| /* 0x668 */ s8 field_0x668; | ||
| /* 0x669 */ u8 field_0x669[3]; |
Contributor
There was a problem hiding this comment.
field_0x669 can be removed
Contributor
Author
There was a problem hiding this comment.
Someday I'll remember to take out the padding XD
| /* 0x669 */ u8 field_0x669[3]; | ||
| /* 0x66C */ J3DModel* field_0x66c; | ||
| /* 0x670 */ s8 field_0x670; | ||
| /* 0x671 */ u8 field_0x671[0x674 - 0x671]; |
Contributor
There was a problem hiding this comment.
field_0x671 can be removed
| /* 0x6C4 */ s16 field_0x6c4[5]; | ||
| /* 0x6CE */ s16 field_0x6ce; | ||
| /* 0x6D0 */ s16 field_0x6d0; | ||
| /* 0x6D2 */ u8 field_0x6d2[0x6d4 - 0x6d2]; |
Contributor
There was a problem hiding this comment.
field_0x6d2 can be removed
| /* 0x6D2 */ u8 field_0x6d2[0x6d4 - 0x6d2]; | ||
| /* 0x6D4 */ cXyz field_0x6d4; | ||
| /* 0x6E0 */ s8 field_0x6e0; | ||
| /* 0x6E1 */ u8 field_0x6e1[0x6e4 - 0x6e1]; |
Contributor
There was a problem hiding this comment.
field_0x6e1 can be removed
| /* 0x8B8 */ f32 field_0x8b8[18]; | ||
| /* 0x900 */ s16 field_0x900[18]; | ||
| /* 0x924 */ s16 field_0x924; | ||
| /* 0x926 */ u8 field_0x926[2]; |
Contributor
There was a problem hiding this comment.
field_0x926 can be removed
| /* 0x9AC */ dCcD_Sph mHeadSph; | ||
| /* 0xAE4 */ dCcD_Cyl mBodyCyl; | ||
| /* 0xC20 */ s8 field_0xc20; | ||
| /* 0xC21 */ u8 field_0xc21[3]; |
Contributor
There was a problem hiding this comment.
field_0xc21 can be removed
| /* 0xC24 */ dCcU_AtInfo mAtInfo; | ||
| /* 0xC48 */ dBgS_AcchCir mAcchCir; | ||
| /* 0xC88 */ dBgS_ObjAcch mObjAcch; | ||
| /* 0xE60 */ u8 field_0xe60[0xe62 - 0xe60]; |
Contributor
There was a problem hiding this comment.
field_0xe60 can be removed
Contributor
Author
There was a problem hiding this comment.
This one is actually needed
| /* 0xEE8 */ f32 mDemoCamFovy; | ||
| /* 0xEEC */ u8 field_0xeec[0xef5 - 0xeec]; | ||
| /* 0xEF5 */ u8 field_0xef5; | ||
| /* 0xEF6 */ u8 field_0xef6[0xef8 - 0xef6]; |
Contributor
There was a problem hiding this comment.
field_0xef6 can be removed
| public: | ||
| /* 806C1CEC */ daE_GB_HIO_c(); | ||
| /* 806C6F98 */ ~daE_GB_HIO_c(); | ||
| /* 806C6F98 */ virtual ~daE_GB_HIO_c() {}; |
| if ((s16)(i_this->field_0x6b8 - sVar1) < 0) { | ||
| a_this->current.angle.y = sVar1 + 0x2000; | ||
| } else { | ||
| a_this->current.angle.y = sVar1 + -0x2000; |
Report for GZ2E01 (bb008ca - 1867c19)📈 Matched code: 65.87% (+0.11%, +13196 bytes) ✅ 38 new matches:
...and 8 more new matches 💔 1 broken matches:
📈 6 improvements in unmatched functions:
|
hatal175
approved these changes
Jun 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.