Merged
Conversation
Report for GZ2E01 (2dc324c - 8c823d5)📈 Matched code: 76.42% (+0.11%, +12404 bytes) ✅ 78 new matches
...and 48 more new matches |
hatal175
reviewed
Aug 8, 2025
src/d/actor/d_a_npc_yamid.cpp
Outdated
| u32 daNpc_yamiD_c::getFlowNodeNo() { | ||
| u32 rv = -1; | ||
|
|
||
| /* dSv_event_flag_c::F_0570 - Palace of Twilight - Cleared Palace of Twilight */ |
Contributor
Author
There was a problem hiding this comment.
I purposefully indented them like so to start the comment right above the chkEvtBit functions. Should I not do that?
src/d/actor/d_a_npc_yamid.cpp
Outdated
| switch (mType) { | ||
| case 0: | ||
| case 1: | ||
| /* dSv_event_flag_c::F_0570 - Palace of Twilight - Cleared Palace of Twilight */ |
Contributor
|
It's pretty obvious what they're about without the indentation
…On Fri, Aug 8, 2025, 18:14 Carco_21 ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/d/actor/d_a_npc_yamid.cpp
<#2574 (comment)>:
> }
/* 80B43934-80B43998 000AD4 0064+00 1/1 0/0 0/0 .text getFlowNodeNo__13daNpc_yamiD_cFv */
-void daNpc_yamiD_c::getFlowNodeNo() {
- // NONMATCHING
+u32 daNpc_yamiD_c::getFlowNodeNo() {
+ u32 rv = -1;
+
+ /* dSv_event_flag_c::F_0570 - Palace of Twilight - Cleared Palace of Twilight */
I purposefully indented them like so to start the comment right above the
chkEvtBit functions. Should I not do that?
—
Reply to this email directly, view it on GitHub
<#2574 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACYQXXM6PNTHIEOAXKRDRUT3MS5FFAVCNFSM6AAAAACDN4ZMUOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTCMBRGIYDKOBSGM>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
hatal175
approved these changes
Aug 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.