Merged
Conversation
Report for GZ2E01 (0e8d06c - 2e55825)📈 Matched code: 77.97% (+0.17%, +19240 bytes) ✅ 41 new matches
...and 11 more new matches |
hatal175
reviewed
Aug 15, 2025
src/d/actor/d_a_e_dd.cpp
Outdated
| i_this->mAtInfo.mpCollider = i_this->field_0xa74[2].GetTgHitObj(); | ||
| at_power_check(&i_this->mAtInfo); | ||
|
|
||
| if (i_this->mAtInfo.mHitType == 16) { |
src/d/actor/d_a_e_dd.cpp
Outdated
| i_this->mAtInfo.mpCollider = i_this->field_0xa74[i].GetTgHitObj(); | ||
| at_power_check(&i_this->mAtInfo); | ||
|
|
||
| if (i_this->mAtInfo.mHitType == 16) { |
src/d/actor/d_a_e_dd.cpp
Outdated
| daE_DD_HIO_c l_HIO; | ||
|
|
||
| /* 806A74F0-806A75EF 000040 00FF+00 1/1 0/0 0/0 .bss check_index$4196 */ | ||
| static u8 check_index[255]; |
Contributor
There was a problem hiding this comment.
This should be defined inside path_check (notice the $4196)
src/d/actor/d_a_e_dd.cpp
Outdated
| i_this->field_0xa74[0].OffTgShield(); | ||
| i_this->field_0xa74[0].SetTgHitMark((CcG_Tg_HitMark)0); | ||
| i_this->field_0xa74[1].OffTgShield(); | ||
| i_this->field_0xa74[1].SetTgHitMark((CcG_Tg_HitMark)0); |
src/d/actor/d_a_e_dd.cpp
Outdated
| i_this->field_0xa74[1].SetTgHitMark((CcG_Tg_HitMark)2); | ||
| } else { | ||
| i_this->field_0xa74[0].OffTgShield(); | ||
| i_this->field_0xa74[0].SetTgHitMark((CcG_Tg_HitMark)0); |
src/d/actor/d_a_e_dd.cpp
Outdated
|
|
||
| if (bVar2 != 0) { | ||
| i_this->field_0xa74[0].OnTgShield(); | ||
| i_this->field_0xa74[0].SetTgHitMark((CcG_Tg_HitMark)2); |
src/d/actor/d_a_e_dd.cpp
Outdated
|
|
||
| if (i == 2) { | ||
| i_this->field_0xa74[i].OffTgShield(); | ||
| i_this->field_0xa74[i].SetTgHitMark((CcG_Tg_HitMark)0); |
src/d/actor/d_a_e_dd.cpp
Outdated
| i_this->field_0xa74[i].SetTgHitMark((CcG_Tg_HitMark)0); | ||
| } else { | ||
| i_this->field_0xa74[i].OnTgShield(); | ||
| i_this->field_0xa74[i].SetTgHitMark((CcG_Tg_HitMark)2); |
src/d/actor/d_a_e_dd.cpp
Outdated
|
|
||
| if (a_this->health <= 1) { | ||
| a_this->health = 0; | ||
| i_this->field_0xa74[2].SetTgHitMark((CcG_Tg_HitMark)3); |
src/d/actor/d_a_e_dd.cpp
Outdated
| i_this->mFireSph.Set(fire_sph_src); | ||
| i_this->mFireSph.SetStts(&i_this->mStts); | ||
| i_this->mFireSph.SetAtType(AT_TYPE_100); | ||
| i_this->mFireSph.SetAtMtrl(1); |
TakaRikka
reviewed
Aug 15, 2025
src/d/actor/d_a_e_dd.cpp
Outdated
|
|
||
| /* 806A74C8-806A74F0 000018 0028+00 9/9 0/0 0/0 .bss l_HIO */ | ||
| static u8 l_HIO[40]; | ||
| daE_DD_HIO_c l_HIO; |
Contributor
There was a problem hiding this comment.
this should still be static
hatal175
approved these changes
Aug 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason, my bss data is off by one byte. Not sure if that's just padding or something else.