Merged
Conversation
Report for GZ2E01 (a23984e - 0e8aa90)📈 Matched code: 78.50% (+0.22%, +25104 bytes) ✅ 39 new matches
...and 9 more new matches |
hatal175
reviewed
Aug 18, 2025
Contributor
|
Not critical.
…On Tue, Aug 19, 2025, 00:43 Max Roncace ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/d/actor/d_a_e_yr.cpp
<#2591 (comment)>:
> + anm_init(i_this, 8, 5.0f, 2, cM_rndF(0.2f) + 1.2f);
+
+ i_this->field_0x6a4[1] = cM_rndF(100.0f) + 60.0f;
+ i_this->field_0x6c4 = playerActor->shape_angle.y;
+ i_this->field_0x6a4[0] = 0;
+ i_this->field_0x6a4[2] = 0;
+ i_this->field_0x6a4[3] = 0;
+ case 1:
+ if (i_this->field_0x6a4[1] == 0) {
+ anm_init(i_this, 8, 5.0f, 2, cM_rndF(0.2f) + 1.0f);
+
+ i_this->field_0x67d = 2;
+ i_this->field_0x6a4[1] = cM_rndF(150.0f) + 70.0f;
+ }
+
+ goto lbl_case2;
I may be missing something, but I can't come up with a sane way to do
this. The first bit of case 2 is only ever executed when jumping directly
there, but I'm not sure how that could be expressed with conditional logic.
That aside this also seems somehow more evil than a goto.
—
Reply to this email directly, view it on GitHub
<#2591 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACYQXXNSPS4FXGWSBZ7MJEL3OJCJXAVCNFSM6AAAAACED6XDWOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTCMZQGA3DGOJWGA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
caseif
force-pushed
the
d_a_e_yr-1
branch
2 times, most recently
from
4e561e9 to
00fcbe6
Compare
hatal175
approved these changes
Aug 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
d_a_e_yris equivalent with this PR with the only remaining issue beingsetMidnaBindEffectshenanigans.