Skip to content

d_a_npc_grc equivalent#2594

Merged
hatal175 merged 4 commits intozeldaret:mainfrom
carter-ktb21:d_a_npc_grc
Aug 22, 2025
Merged

d_a_npc_grc equivalent#2594
hatal175 merged 4 commits intozeldaret:mainfrom
carter-ktb21:d_a_npc_grc

Conversation

@carter-ktb21
Copy link
Copy Markdown
Contributor

No description provided.

@decomp-dev
Copy link
Copy Markdown

decomp-dev bot commented Aug 21, 2025

Report for GZ2E01 (ef75333 - 7be59ad)

📈 Matched code: 78.82% (+0.14%, +16400 bytes)

✅ 61 new matches
Unit Function Bytes Before After
d_a_npc_grc/d/actor/d_a_npc_grc daNpc_grC_c::setAttnPos() +1337 0.30% 100.00%
d_a_npc_grc/d/actor/d_a_npc_grc daNpc_grC_c::playExpression() +756 0.53% 100.00%
d_a_npc_grc/d/actor/d_a_npc_grc daNpc_grC_c::create() +752 0.53% 100.00%
d_a_npc_grc/d/actor/d_a_npc_grc daNpc_grC_c::playMotion() +740 0.54% 100.00%
d_a_npc_grc/d/actor/d_a_npc_grc daNpc_grC_c::doEvent() +728 0.55% 100.00%
d_a_npc_grc/d/actor/d_a_npc_grc daNpc_grC_c::talk(void*) +676 0.59% 100.00%
d_a_npc_grc/d/actor/d_a_npc_grc daNpc_grC_c::lookat() +645 0.62% 100.00%
d_a_npc_grc/d/actor/d_a_npc_grc daNpcF_c::~daNpcF_c() +585 0.68% 100.00%
d_a_npc_grc/d/actor/d_a_npc_grc daNpc_grC_c::setExpressionAnm(int, bool) +580 0.68% 100.00%
d_a_npc_grc/d/actor/d_a_npc_grc daNpc_grC_c::ctrlJoint(J3DJoint*, J3DModel*) +560 0.71% 100.00%
d_a_npc_grc/d/actor/d_a_npc_grc daNpc_grC_c::reset() +500 0.79% 100.00%
d_a_npc_grc/d/actor/d_a_npc_grc daNpc_grC_c::waitSpa(void*) +500 0.79% 100.00%
d_a_npc_grc/d/actor/d_a_npc_grc daNpc_grC_c::CreateHeap() +492 0.81% 100.00%
d_a_npc_grc/d/actor/d_a_npc_grc daNpcF_c::daNpcF_c() +492 0.81% 100.00%
d_a_npc_grc/d/actor/d_a_npc_grc daNpc_grC_c::~daNpc_grC_c() +463 9.76% 100.00%
d_a_npc_grc/d/actor/d_a_npc_grc daNpc_grC_c::wait(void*) +429 0.93% 100.00%
d_a_npc_grc/d/actor/d_a_npc_grc daNpc_grC_c::setMotionAnm(int, float) +413 0.96% 100.00%
d_a_npc_grc/d/actor/d_a_npc_grc daNpc_grC_c::main() +381 1.04% 100.00%
d_a_npc_grc/d/actor/d_a_npc_grc daNpc_grC_c::daNpc_grC_c() +341 12.21% 100.00%
d_a_npc_grc/d/actor/d_a_npc_grc daNpc_grC_c::setParam() +316 1.25% 100.00%
d_a_npc_grc/d/actor/d_a_npc_grc daNpc_grC_c::waitBuyer(void*) +313 1.27% 100.00%
d_a_npc_grc/d/actor/d_a_npc_grc daNpc_grC_c::chkFindPlayer() +301 1.32% 100.00%
d_a_npc_grc/d/actor/d_a_npc_grc daNpc_grC_c::setExpressionBtp(int) +296 1.33% 100.00%
d_a_npc_grc/d/actor/d_a_npc_grc daNpc_grC_c::doNormalAction(int) +272 1.45% 100.00%
d_a_npc_grc/d/actor/d_a_npc_grc daNpc_grC_c::selectAction() +244 1.61% 100.00%
d_a_npc_grc/d/actor/d_a_npc_grc daNpc_grC_c::waitTW(void*) +229 1.72% 100.00%
d_a_npc_grc/d/actor/d_a_npc_grc daNpc_grC_c::test(void*) +225 1.75% 100.00%
d_a_npc_grc/d/actor/d_a_npc_grc daNpcF_Lookat_c::~daNpcF_Lookat_c() +205 1.92% 100.00%
d_a_npc_grc/d/actor/d_a_npc_grc daNpc_grC_c::setExpressionTalkAfter() +200 1.96% 100.00%
d_a_npc_grc/d/actor/d_a_npc_grc daNpc_grC_c::setAction(int (daNpc_grC_c::*)(void*)) +165 2.38% 100.00%

...and 31 more new matches

Execute();

return cPhs_COMPLEATE_e;
} else {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need for else

// NONMATCHING
/* 809CBE18-809CBE8C 000A38 0074+00 1/1 0/0 0/0 .text Draw__11daNpc_grC_cFv */
int daNpc_grC_c::Draw() {
draw(chkAction(&daNpc_grC_c::test), FALSE, daNpc_grC_Param_c::m.common.real_shadow_size, NULL, FALSE);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing return

// NONMATCHING
}
BOOL daNpc_grC_c::isDelete() {
if ((mType == TYPE_6 || mType == TYPE_0 || mType == TYPE_TWILIGHT) || (mType == TYPE_SPA &&
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need all the parenthesis here?

@hatal175 hatal175 merged commit 731d8be into zeldaret:main Aug 22, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants