Merged
Conversation
Report for GZ2E01 (aec2c09 - 3d2492e)📈 Matched code: 79.40% (+0.45%, +51712 bytes) ✅ 85 new matches
...and 55 more new matches 📈 8 improvements in unmatched functions
📉 1 regression in unmatched functions
|
hatal175
reviewed
Aug 22, 2025
src/d/actor/d_a_mg_fish.cpp
Outdated
| if (s_fish_ct <= 1) { | ||
| f32 fVar1 = i_this->field_0x5ec; | ||
| if (rod->field_0xf80 == 4) { | ||
| if (rod->lure_type == 4) { |
src/d/actor/d_a_mg_fish.cpp
Outdated
| if (i_this->mGedouKind != GEDOU_KIND_CF_1 && | ||
| rod->field_0xf80 != 4 && | ||
| (i_this->field_0x750 & learn_d[rod->field_0xf80]) != 0) | ||
| rod->lure_type != 4 && |
src/d/actor/d_a_mg_fish.cpp
Outdated
| cXyz diff = rod->current.pos - i_this->actor.current.pos; | ||
| if (rod->field_0xf80 == 2 && rod->field_0x100c >= 10) { | ||
| cXyz diff = rod->actor.current.pos - i_this->actor.current.pos; | ||
| if (rod->lure_type == 2 && rod->field_0x100c >= 10) { |
src/d/actor/d_a_mg_fish.cpp
Outdated
| } | ||
| f32 rodDist = sqrtf(VECSquareMag(&rodSep)); | ||
| if (rod->field_0xf80 != 4 && rod->field_0xf80 != 2 && | ||
| if (rod->lure_type != 4 && rod->lure_type != 2 && |
Contributor
There was a problem hiding this comment.
MG_LURE_SP and MG_LURE_PO
src/d/actor/d_a_mg_fish.cpp
Outdated
| if (rodDist < 1.3f * i_this->field_0x5ec && | ||
| (rod->field_0xf80 == 4 || rod->field_0xf80 == 3) && | ||
| rod->field_0x14f0 != 0 && | ||
| (rod->lure_type == 4 || rod->lure_type == 3) && |
src/d/actor/d_a_mg_rod.cpp
Outdated
| case 900: | ||
| if (!actor->eventInfo.checkCommandDemoAccrpt()) { | ||
| fopAcM_orderPotentialEvent(actor, 2, 0xFFFF, 0); | ||
| actor->eventInfo.onCondition(2); |
src/d/actor/d_a_mg_rod.cpp
Outdated
| if (i_this->msgflow.doFlow(actor, NULL, 0)) { | ||
| camera->mCamera.Reset(i_this->play_cam_center, i_this->play_cam_eye, i_this->play_cam_fovy, 0); | ||
| camera->mCamera.Start(); | ||
| camera->mCamera.S |
src/d/actor/d_a_mg_rod.cpp
Outdated
| if (i_this->msgflow.doFlow(actor, NULL, 0)) { | ||
| camera->mCamera.Reset(i_this->play_cam_center, i_this->play_cam_eye, i_this->play_cam_fovy, 0); | ||
| camera->mCamera.Start(); | ||
| camera->mCamera.S |
src/d/actor/d_a_mg_rod.cpp
Outdated
| if (i_this->msgflow.doFlow(actor, NULL, 0)) { | ||
| camera->mCamera.Reset(i_this->play_cam_center, i_this->play_cam_eye, i_this->play_cam_fovy, 0); | ||
| camera->mCamera.Start(); | ||
| camera->mCamera.S |
src/d/actor/d_a_mg_rod.cpp
Outdated
| if (i_this->msgflow.doFlow(actor, NULL, 0)) { | ||
| camera->mCamera.Reset(i_this->play_cam_center, i_this->play_cam_eye, i_this->play_cam_fovy, 0); | ||
| camera->mCamera.Start(); | ||
| camera->mCamera.S |
hatal175
approved these changes
Aug 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
first pass, still needs more cleanup later