Add hacks to fix PCH .data causing fake mismatches with decompctx#2606
Merged
TakaRikka merged 1 commit intozeldaret:mainfrom Aug 31, 2025
Merged
Add hacks to fix PCH .data causing fake mismatches with decompctx#2606TakaRikka merged 1 commit intozeldaret:mainfrom
TakaRikka merged 1 commit intozeldaret:mainfrom
Conversation
TakaRikka
approved these changes
Aug 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds some hacks to fix erroneous mismatches that are reported when compiling code generated by decompctx. These are caused by not using a PCH thereby causing constants that would normally end up in
.datato be emitted in.rodatainstead which then affects the final assembly and makes it difficult to tell whether code is matching or not in decomp.me. This basically just moves thestatic constitems tostaticglobals so that they're forced to go in.data. This isn't a perfect fix as the ordering ends up being wrong, but the important part is that 1) the.datasize stays the same, and 2) the later.dataand the.rodataoffsets are what they should be (as they would be when using a PCH).This also includes changes from encounter/dtk-template#62 to allow conditionally compiling code for decompctx (and also to fix including PCHs in general).