Skip to content

Fix all REL module names for ShieldD#2607

Merged
TakaRikka merged 1 commit intozeldaret:mainfrom
LagoLunatic:debug
Aug 26, 2025
Merged

Fix all REL module names for ShieldD#2607
TakaRikka merged 1 commit intozeldaret:mainfrom
LagoLunatic:debug

Conversation

@LagoLunatic
Copy link
Copy Markdown
Contributor

Debug version has "D" suffixes on all REL filenames which makes them inconsistent with retail. This is annoying because if you have objdiff inside a REL and switch between retail/debug it kicks you out and you have to manually refind the TU with the other name which really slows down the workflow.

This PR switches REL names to use the object name instead of the filename, which is the same between debug/retail. This causes a one-time break in history tracking, but debug only got added to tracking today anyways.

@LagoLunatic LagoLunatic marked this pull request as ready for review August 26, 2025 01:43
@decomp-dev
Copy link
Copy Markdown

decomp-dev bot commented Aug 26, 2025

Report for ShieldD (ee6c527 - 34be45d)

✅ 13806 new matches
Unit Function Bytes Before After
d_a_e_yr/d/actor/d_a_e_yr daE_Yr_Execute(e_yr_class*) +4236 0.00% 100.00%
d_a_kago/d/actor/d_a_kago daKago_HIO_c::genMessage(JORMContext*) +2980 0.00% 100.00%
d_a_kago/d/actor/d_a_kago daKago_c::flySpeedCalc(short, int) +2096 0.00% 100.00%
d_a_obj_crope/d/actor/d_a_obj_crope daObjCrope_c::setRideRopePos() +1896 0.00% 100.00%
d_a_vrbox2/d/actor/d_a_vrbox2 daVrbox2_Draw(vrbox2_class*) +1836 0.00% 100.00%
d_a_tag_allmato/d/actor/d_a_tag_allmato daTag_AllMato_c::Execute() +1804 0.00% 100.00%
d_a_b_bh/d/actor/d_a_b_bh b_bh_wait(b_bh_class*) +1796 0.00% 100.00%
d_a_tag_wljump/d/actor/d_a_tag_wljump daTagWljump_c::execute() +1584 0.00% 100.00%
d_a_obj_yousei/d/actor/d_a_obj_yousei daObjYOUSEI_c::MoveAction() +1404 0.00% 100.00%
d_a_obj_msima/d/actor/d_a_obj_msima action(obj_msima_class*) +1348 0.00% 100.00%
d_a_npc_wrestler/d/actor/d_a_npc_wrestler daNpcWrestler_c::setExpressionAnm(int, bool) +1232 0.00% 100.00%
d_a_obj_flag3/d/actor/d_a_obj_flag3 FlagCloth2_c::draw() +1232 0.00% 100.00%
d_a_obj_poFire/d/actor/d_a_obj_poFire daPoFire_HIO_c::genMessage(JORMContext*) +1208 0.00% 100.00%
d_a_e_sb/d/actor/d_a_e_sb daE_SB_HIO_c::genMessage(JORMContext*) +1144 0.00% 100.00%
d_a_e_th_ball/d/actor/d_a_e_th_ball chain_draw(e_th_ball_class*) +1136 0.00% 100.00%
d_a_obj_kgate/d/actor/d_a_obj_kgate daObjKGate_c::setBaseMtx() +1132 0.00% 100.00%
d_a_npc_kn/d/actor/d_a_npc_kn daNpc_Kn_c::playAllAnm() +1128 0.00% 100.00%
d_a_balloon_2D/d/actor/d_a_balloon_2D daBalloon2D_c::setHIO(bool) +1120 0.00% 100.00%
d_a_npc_besu/d/actor/d_a_npc_besu daNpc_Besu_c::CreateHeap() +1116 0.00% 100.00%
d_a_obj_sakuita/d/actor/d_a_obj_sakuita daObjSakuita_Hio_c::genMessage(JORMContext*) +1096 0.00% 100.00%
d_a_obj_rgate/d/actor/d_a_obj_rgate daObjRgate_c::setBaseMtx() +1080 0.00% 100.00%
d_a_e_hb/d/actor/d_a_e_hb damage_check(e_hb_class*) +1068 0.00% 100.00%
d_a_obj_dust/d/actor/d_a_obj_dust daObjDust_c::Execute(float(**)[3][4]) +1068 0.00% 100.00%
d_a_obj_yousei/d/actor/d_a_obj_yousei daObjYOUSEI_c::LinkChk() +1052 0.00% 100.00%
d_a_e_yr/d/actor/d_a_e_yr nodeCallBack(J3DJoint*, int) +1048 0.00% 100.00%
d_a_kago/d/actor/d_a_kago daKago_c::checkWallHitFall(int) +1044 0.00% 100.00%
d_a_coach_2D/d/actor/d_a_coach_2D daCoach2D_c::drawMeter() +1020 0.00% 100.00%
d_a_npc_kn/d/actor/d_a_npc_kn daNpc_Kn_c::draw(int, int, float, _GXColorS10*, float, int, int, int) +1016 0.00% 100.00%
d_a_obj_lv3Water/d/actor/d_a_obj_lv3Water daLv3Water_c::effectSet() +1004 0.00% 100.00%
d_a_npc_ks/d/actor/d_a_npc_ks useHeapInit(fopAc_ac_c*) +988 0.00% 100.00%

...and 13776 more new matches

💔 13806 broken matches
Unit Function Bytes Before After
d_a_e_yrD/d/actor/d_a_e_yr daE_Yr_Execute(e_yr_class*) -4236 100.00% 0.00%
d_a_kagoD/d/actor/d_a_kago daKago_HIO_c::genMessage(JORMContext*) -2980 100.00% 0.00%
d_a_kagoD/d/actor/d_a_kago daKago_c::flySpeedCalc(short, int) -2096 100.00% 0.00%
d_a_obj_cropeD/d/actor/d_a_obj_crope daObjCrope_c::setRideRopePos() -1896 100.00% 0.00%
d_a_vrbox2D/d/actor/d_a_vrbox2 daVrbox2_Draw(vrbox2_class*) -1836 100.00% 0.00%
d_a_tag_allmatoD/d/actor/d_a_tag_allmato daTag_AllMato_c::Execute() -1804 100.00% 0.00%
d_a_b_bhD/d/actor/d_a_b_bh b_bh_wait(b_bh_class*) -1796 100.00% 0.00%
d_a_tag_wljumpD/d/actor/d_a_tag_wljump daTagWljump_c::execute() -1584 100.00% 0.00%
d_a_obj_youseiD/d/actor/d_a_obj_yousei daObjYOUSEI_c::MoveAction() -1404 100.00% 0.00%
d_a_obj_msimaD/d/actor/d_a_obj_msima action(obj_msima_class*) -1348 100.00% 0.00%
d_a_npc_wrestlerD/d/actor/d_a_npc_wrestler daNpcWrestler_c::setExpressionAnm(int, bool) -1232 100.00% 0.00%
d_a_obj_flag3D/d/actor/d_a_obj_flag3 FlagCloth2_c::draw() -1232 100.00% 0.00%
d_a_obj_poFireD/d/actor/d_a_obj_poFire daPoFire_HIO_c::genMessage(JORMContext*) -1208 100.00% 0.00%
d_a_e_sbD/d/actor/d_a_e_sb daE_SB_HIO_c::genMessage(JORMContext*) -1144 100.00% 0.00%
d_a_e_th_ballD/d/actor/d_a_e_th_ball chain_draw(e_th_ball_class*) -1136 100.00% 0.00%
d_a_obj_kgateD/d/actor/d_a_obj_kgate daObjKGate_c::setBaseMtx() -1132 100.00% 0.00%
d_a_npc_knD/d/actor/d_a_npc_kn daNpc_Kn_c::playAllAnm() -1128 100.00% 0.00%
d_a_balloon_2DD/d/actor/d_a_balloon_2D daBalloon2D_c::setHIO(bool) -1120 100.00% 0.00%
d_a_npc_besuD/d/actor/d_a_npc_besu daNpc_Besu_c::CreateHeap() -1116 100.00% 0.00%
d_a_obj_sakuitaD/d/actor/d_a_obj_sakuita daObjSakuita_Hio_c::genMessage(JORMContext*) -1096 100.00% 0.00%
d_a_obj_rgateD/d/actor/d_a_obj_rgate daObjRgate_c::setBaseMtx() -1080 100.00% 0.00%
d_a_e_hbD/d/actor/d_a_e_hb damage_check(e_hb_class*) -1068 100.00% 0.00%
d_a_obj_dustD/d/actor/d_a_obj_dust daObjDust_c::Execute(float(**)[3][4]) -1068 100.00% 0.00%
d_a_obj_youseiD/d/actor/d_a_obj_yousei daObjYOUSEI_c::LinkChk() -1052 100.00% 0.00%
d_a_e_yrD/d/actor/d_a_e_yr nodeCallBack(J3DJoint*, int) -1048 100.00% 0.00%
d_a_kagoD/d/actor/d_a_kago daKago_c::checkWallHitFall(int) -1044 100.00% 0.00%
d_a_coach_2DD/d/actor/d_a_coach_2D daCoach2D_c::drawMeter() -1020 100.00% 0.00%
d_a_npc_knD/d/actor/d_a_npc_kn daNpc_Kn_c::draw(int, int, float, _GXColorS10*, float, int, int, int) -1016 100.00% 0.00%
d_a_obj_lv3WaterD/d/actor/d_a_obj_lv3Water daLv3Water_c::effectSet() -1004 100.00% 0.00%
d_a_npc_ksD/d/actor/d_a_npc_ks useHeapInit(fopAc_ac_c*) -988 100.00% 0.00%

...and 13776 more broken matches

📈 15117 improvements in unmatched functions
Unit Function Bytes Before After
d_a_npc_henna/d/actor/d_a_npc_henna demo_camera_shop(npc_henna_class*) +12792 0.00% 92.46%
d_a_b_ob/d/actor/d_a_b_ob demo_camera(b_ob_class*) +12546 0.00% 94.16%
d_a_e_po/d/actor/d_a_e_po e_po_holl_demo(e_po_class*) +11997 0.00% 91.20%
d_a_b_bq/d/actor/d_a_b_bq demo_camera(b_bq_class*) +10727 0.00% 91.19%
d_a_mg_rod/d/actor/d_a_mg_rod play_camera(dmg_rod_class*) +10665 0.00% 95.88%
d_a_npc_ks/d/actor/d_a_npc_ks demo_camera(npc_ks_class*) +10397 0.00% 85.93%
d_a_e_fm/d/actor/d_a_e_fm demo_camera(e_fm_class*) +10048 0.00% 99.45%
d_a_b_gnd/d/actor/d_a_b_gnd demo_camera(b_gnd_class*) +9437 0.00% 87.51%
d_a_e_pz/d/actor/d_a_e_pz daE_PZ_c::executeOpeningDemo() +9258 0.00% 97.13%
d_a_e_rd/d/actor/d_a_e_rd daE_RD_Execute(e_rd_class*) +8829 0.00% 96.14%
d_a_b_gnd/d/actor/d_a_b_gnd daB_GND_Execute(b_gnd_class*) +8269 0.00% 82.07%
d_a_obj_so/d/actor/d_a_obj_so part_move(obj_so_class*) +7663 0.00% 99.37%
d_a_e_fm/d/actor/d_a_e_fm daE_FM_Execute(e_fm_class*) +7629 0.00% 96.23%
d_a_L7op_demo_dr/d/actor/d_a_L7op_demo_dr daL7ODR_c::dr_fly() +7356 0.00% 98.25%
d_a_b_ds/d/actor/d_a_b_ds daB_DS_c::executeOpeningDemo() +7301 0.00% 95.71%
d_a_e_rdy/d/actor/d_a_e_rdy demo_camera(e_rdy_class*) +7181 0.00% 98.54%
d_a_e_rd/d/actor/d_a_e_rd action(e_rd_class*) +7086 0.00% 90.67%
d_a_midna/d/actor/d_a_midna daMidna_c::setAnm() +6810 0.00% 99.86%
d_a_obj_lv4chandelier/d/actor/d_a_obj_lv4chandelier daObjLv4Chan_c::Execute(float(**)[3][4]) +6578 0.00% 88.42%
d_a_e_rdy/d/actor/d_a_e_rdy action(e_rdy_class*) +6569 0.00% 99.06%
d_a_b_gm/d/actor/d_a_b_gm demo_camera(b_gm_class*) +6345 0.00% 89.37%
d_a_npc_maro/d/actor/d_a_npc_maro daNpc_Maro_c::cutArrowTutorial(int) +6294 0.00% 99.60%
d_a_e_rdy/d/actor/d_a_e_rdy daE_RDY_Execute(e_rdy_class*) +6181 0.00% 98.42%
d_a_e_warpappear/d/actor/d_a_e_warpappear demo_camera(e_warpappear_class*) +5975 0.00% 87.21%
d_a_obj_brg/d/actor/d_a_obj_brg daObj_Brg_Execute(obj_brg_class*) +5926 0.00% 96.58%
d_a_e_rd/d/actor/d_a_e_rd demo_camera(e_rd_class*) +5903 0.00% 94.37%
d_a_b_yo/d/actor/d_a_b_yo daB_YO_c::executeOpening() +5848 0.00% 93.25%
d_a_b_ds/d/actor/d_a_b_ds daB_DS_c::executeBattle2Dead() +5772 0.00% 82.94%
d_a_e_po/d/actor/d_a_e_po e_po_dead(e_po_class*) +5640 0.00% 92.22%
d_a_npc_tk/d/actor/d_a_npc_tk daNPC_TK_c::executeWolfPerch() +5589 0.00% 96.77%

...and 15087 more improvements in unmatched functions

📉 15117 regressions in unmatched functions
Unit Function Bytes Before After
d_a_npc_hennaD/d/actor/d_a_npc_henna demo_camera_shop(npc_henna_class*) -12792 92.46% 0.00%
d_a_b_obD/d/actor/d_a_b_ob demo_camera(b_ob_class*) -12546 94.16% 0.00%
d_a_e_poD/d/actor/d_a_e_po e_po_holl_demo(e_po_class*) -11997 91.20% 0.00%
d_a_b_bqD/d/actor/d_a_b_bq demo_camera(b_bq_class*) -10727 91.19% 0.00%
d_a_mg_rodD/d/actor/d_a_mg_rod play_camera(dmg_rod_class*) -10665 95.88% 0.00%
d_a_npc_ksD/d/actor/d_a_npc_ks demo_camera(npc_ks_class*) -10397 85.93% 0.00%
d_a_e_fmD/d/actor/d_a_e_fm demo_camera(e_fm_class*) -10048 99.45% 0.00%
d_a_b_gndD/d/actor/d_a_b_gnd demo_camera(b_gnd_class*) -9437 87.51% 0.00%
d_a_e_pzD/d/actor/d_a_e_pz daE_PZ_c::executeOpeningDemo() -9258 97.13% 0.00%
d_a_e_rdD/d/actor/d_a_e_rd daE_RD_Execute(e_rd_class*) -8829 96.14% 0.00%
d_a_b_gndD/d/actor/d_a_b_gnd daB_GND_Execute(b_gnd_class*) -8269 82.07% 0.00%
d_a_obj_soD/d/actor/d_a_obj_so part_move(obj_so_class*) -7663 99.37% 0.00%
d_a_e_fmD/d/actor/d_a_e_fm daE_FM_Execute(e_fm_class*) -7629 96.23% 0.00%
d_a_L7op_demo_drD/d/actor/d_a_L7op_demo_dr daL7ODR_c::dr_fly() -7356 98.25% 0.00%
d_a_b_dsD/d/actor/d_a_b_ds daB_DS_c::executeOpeningDemo() -7301 95.71% 0.00%
d_a_e_rdyD/d/actor/d_a_e_rdy demo_camera(e_rdy_class*) -7181 98.54% 0.00%
d_a_e_rdD/d/actor/d_a_e_rd action(e_rd_class*) -7086 90.67% 0.00%
d_a_midnaD/d/actor/d_a_midna daMidna_c::setAnm() -6810 99.86% 0.00%
d_a_obj_lv4chandelierD/d/actor/d_a_obj_lv4chandelier daObjLv4Chan_c::Execute(float(**)[3][4]) -6578 88.42% 0.00%
d_a_e_rdyD/d/actor/d_a_e_rdy action(e_rdy_class*) -6569 99.06% 0.00%
d_a_b_gmD/d/actor/d_a_b_gm demo_camera(b_gm_class*) -6345 89.37% 0.00%
d_a_npc_maroD/d/actor/d_a_npc_maro daNpc_Maro_c::cutArrowTutorial(int) -6294 99.60% 0.00%
d_a_e_rdyD/d/actor/d_a_e_rdy daE_RDY_Execute(e_rdy_class*) -6181 98.42% 0.00%
d_a_e_warpappearD/d/actor/d_a_e_warpappear demo_camera(e_warpappear_class*) -5975 87.21% 0.00%
d_a_obj_brgD/d/actor/d_a_obj_brg daObj_Brg_Execute(obj_brg_class*) -5926 96.58% 0.00%
d_a_e_rdD/d/actor/d_a_e_rd demo_camera(e_rd_class*) -5903 94.37% 0.00%
d_a_b_yoD/d/actor/d_a_b_yo daB_YO_c::executeOpening() -5848 93.25% 0.00%
d_a_b_dsD/d/actor/d_a_b_ds daB_DS_c::executeBattle2Dead() -5772 82.94% 0.00%
d_a_e_poD/d/actor/d_a_e_po e_po_dead(e_po_class*) -5640 92.22% 0.00%
d_a_npc_tkD/d/actor/d_a_npc_tk daNPC_TK_c::executeWolfPerch() -5589 96.77% 0.00%

...and 15087 more regressions in unmatched functions


Report for GZ2P01 (ee6c527 - 34be45d)

No changes

Report for GZ2E01 (ee6c527 - 34be45d)

No changes

Report for GZ2J01 (ee6c527 - 34be45d)

No changes

@TakaRikka TakaRikka merged commit a945ef4 into zeldaret:main Aug 26, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants