d_a_npc_zelro matching and some npct's linked#2649
Merged
TakaRikka merged 9 commits intozeldaret:mainfrom Sep 15, 2025
Merged
Conversation
Report for ShieldD (ae6f424 - 0da4b4b)📈 Matched code: 19.12% (+0.03%, +4032 bytes) ✅ 44 new matches
...and 14 more new matches 📈 25 improvements in unmatched functions
📉 2 regressions in unmatched functions
Report for GZ2E01 (ae6f424 - 0da4b4b)📈 Matched code: 84.42% (+0.11%, +12408 bytes) ✅ 77 new matches
...and 47 more new matches Report for GZ2J01 (ae6f424 - 0da4b4b)📈 Matched code: 82.20% (+0.11%, +12408 bytes) ✅ 77 new matches
...and 47 more new matches Report for GZ2P01 (ae6f424 - 0da4b4b)📈 Matched code: 82.52% (+0.11%, +12408 bytes) ✅ 77 new matches
...and 47 more new matches |
Contributor
|
@caseif matches for JPN? |
Contributor
|
@YunataSavior Yep, all four match! |
TakaRikka
reviewed
Sep 12, 2025
src/d/actor/d_a_npc_zelRo.cpp
Outdated
| attention_info.distances[fopAc_attn_LOCK_e] = daNpcT_getDistTableIdx(daNpc_ZelRo_Param_c::m.common.attention_distance, daNpc_ZelRo_Param_c::m.common.attention_angle); | ||
| attention_info.distances[fopAc_attn_TALK_e] = attention_info.distances[fopAc_attn_LOCK_e]; | ||
| attention_info.distances[fopAc_attn_SPEAK_e] = daNpcT_getDistTableIdx(talk_distance, talk_angle); | ||
| attention_info.flags = 10; |
Contributor
There was a problem hiding this comment.
use attention flag enums from f_op_actor.h
Contributor
Contributor
|
@carter-ktb21 can you resolve the merge conflicts please? |
TakaRikka
approved these changes
Sep 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.