Skip to content

d_a_midna equivalent#2658

Merged
TakaRikka merged 1 commit intozeldaret:mainfrom
YunataSavior:midna
Sep 14, 2025
Merged

d_a_midna equivalent#2658
TakaRikka merged 1 commit intozeldaret:mainfrom
YunataSavior:midna

Conversation

@YunataSavior
Copy link
Copy Markdown
Contributor

Two notes:

  1. Placement of cLib_calcTimer is too far down. IDK how to fix it.
  2. setMatrix is a bit of a fakematch. IDK how else to get retail to match.

@decomp-dev
Copy link
Copy Markdown

decomp-dev bot commented Sep 14, 2025

Report for ShieldD (275135f - 5df411c)

📈 5 improvements in unmatched functions
Unit Function Bytes Before After
d_a_midna/d/actor/d_a_midna daMidna_c::setHairAngle() +64 94.23% 96.66%
d_a_midna/d/actor/d_a_midna daMidna_c::setMatrix() +9 97.70% 98.25%
d_a_midna/d/actor/d_a_midna daMidna_c::setBodyPartMatrix() +1 92.29% 92.30%
d_a_midna/d/actor/d_a_midna daMidna_c::create() 0 91.36% 91.40%
d_a_midna/d/actor/d_a_midna daMidna_c::initHairAngle() 0 99.89% 99.91%
📉 8 regressions in unmatched functions
Unit Function Bytes Before After
d_a_midna/d/actor/d_a_midna daMidna_c::setAnm() -61 99.86% 98.96%
d_a_midna/d/actor/d_a_midna daMidna_c::checkMidnaPosState() -1 98.86% 98.84%
d_a_midna/d/actor/d_a_midna daMidna_c::setEyeMove(const cXyz*, short, short) -1 92.29% 92.25%
d_a_midna/d/actor/d_a_midna daMidna_c::allAnimePlay() 0 99.25% 99.22%
d_a_midna/d/actor/d_a_midna daMidna_c::setBodyPartPos() 0 94.98% 94.94%
d_a_midna/d/actor/d_a_midna daMidna_c::setBckAnime(J3DAnmTransform*, int, float) 0 96.56% 96.55%
d_a_midna/d/actor/d_a_midna daMidna_c::setSound() 0 98.78% 98.76%
d_a_midna/d/actor/d_a_midna daMidna_c::execute() 0 98.10% 98.09%

Report for GZ2J01 (275135f - 5df411c)

📈 Matched code: 82.09% (+0.13%, +14888 bytes)

✅ 4 new matches
Unit Function Bytes Before After
d_a_midna/d/actor/d_a_midna daMidna_c::setMatrix() +10 99.44% 100.00%
d_a_midna/d/actor/d_a_midna daMidna_c::checkMidnaPosState() +9 99.79% 100.00%
d_a_midna/d/actor/d_a_midna daMidna_c::setAnm() +9 99.86% 100.00%
d_a_midna/d/actor/d_a_midna daMidna_c::setHairAngle() +4 99.87% 100.00%

Report for GZ2E01 (275135f - 5df411c)

📈 Matched code: 84.31% (+0.13%, +14888 bytes)

✅ 4 new matches
Unit Function Bytes Before After
d_a_midna/d/actor/d_a_midna daMidna_c::setMatrix() +10 99.44% 100.00%
d_a_midna/d/actor/d_a_midna daMidna_c::checkMidnaPosState() +9 99.79% 100.00%
d_a_midna/d/actor/d_a_midna daMidna_c::setAnm() +9 99.86% 100.00%
d_a_midna/d/actor/d_a_midna daMidna_c::setHairAngle() +4 99.87% 100.00%

Report for GZ2P01 (275135f - 5df411c)

📈 Matched code: 82.42% (+0.13%, +14888 bytes)

✅ 4 new matches
Unit Function Bytes Before After
d_a_midna/d/actor/d_a_midna daMidna_c::setMatrix() +10 99.44% 100.00%
d_a_midna/d/actor/d_a_midna daMidna_c::checkMidnaPosState() +9 99.79% 100.00%
d_a_midna/d/actor/d_a_midna daMidna_c::setAnm() +9 99.86% 100.00%
d_a_midna/d/actor/d_a_midna daMidna_c::setHairAngle() +4 99.87% 100.00%

@TakaRikka TakaRikka merged commit bd49d7b into zeldaret:main Sep 14, 2025
4 checks passed
@YunataSavior YunataSavior deleted the midna branch September 22, 2025 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants