Skip to content

Miscellaneous TU fixes#2662

Merged
TakaRikka merged 1 commit intozeldaret:mainfrom
caseif:misc-6
Sep 15, 2025
Merged

Miscellaneous TU fixes#2662
TakaRikka merged 1 commit intozeldaret:mainfrom
caseif:misc-6

Conversation

@caseif
Copy link
Copy Markdown
Contributor

@caseif caseif commented Sep 15, 2025

This PR includes a bunch of random fixes for miscellaneous TUs which are almost matching. It also newly matches a handful.

Closes #469.
Closes #740.
Closes #868.
Closes #885.
Closes #983.

@decomp-dev
Copy link
Copy Markdown

decomp-dev bot commented Sep 15, 2025

Report for ShieldD (ae6f424 - 72e329c)

📈 Matched code: 19.11% (+0.01%, +1240 bytes)

✅ 3 new matches
Unit Function Bytes Before After
d_a_obj_iceleaf/d/actor/d_a_obj_iceleaf J3DJoint::setTransformInfo(const J3DTransformInfo&) +52 0.00% 100.00%
d_a_obj_ito/d/actor/d_a_obj_ito ito_end(ito_s*) +5 98.09% 100.00%
d_a_ep/d/actor/d_a_ep hahen_move(ep_class*) +1 99.99% 100.00%
📈 5 improvements in unmatched functions
Unit Function Bytes Before After
d_a_npc_zrc/d/actor/d_a_npc_zrc daNpc_zrC_c::doEvent() +190 84.37% 99.62%
d_a_obj_ito/d/actor/d_a_obj_ito cut_line_calc(obj_ito_class*, ito_s*, int) +136 86.87% 96.16%
d_a_obj_web0/d/actor/d_a_obj_web0 daObj_Web0_Execute(obj_web0_class*) +74 83.42% 91.78%
d_a_obj_flag3/d/actor/d_a_obj_flag3 daObjFlag3_c::execute() +1 81.02% 81.10%
d_a_npc_kasi_kyu/d/actor/d_a_npc_kasi_kyu daNpcKasiKyu_c::cheer(int) 0 88.63% 88.64%
📉 1 regression in unmatched functions
Unit Function Bytes Before After
d_a_obj_ito/d/actor/d_a_obj_ito action(obj_ito_class*) -63 93.36% 91.93%

Report for GZ2E01 (ae6f424 - 72e329c)

📈 Matched code: 84.41% (+0.10%, +11396 bytes)
📈 Linked code: 53.32% (+0.61%, +69896 bytes)

✅ 15 new matches
Unit Function Bytes Before After
d_a_obj_movebox/d/actor/d_a_obj_movebox daObjMovebox::@unnamed@d_a_obj_movebox_cpp@::Mthd_Create(void*) +436 0.00% 100.00%
d_a_obj_ito/d/actor/d_a_obj_ito cut_line_calc(obj_ito_class*, ito_s*, int) +126 89.40% 100.00%
d_a_obj_movebox/d/actor/d_a_obj_movebox daObjMovebox::@unnamed@d_a_obj_movebox_cpp@::Mthd_Delete(void*) +88 0.00% 100.00%
d_a_obj_ito/d/actor/d_a_obj_ito action(obj_ito_class*) +61 98.39% 100.00%
d_a_obj_movebox/d/actor/d_a_obj_movebox daObjMovebox::@unnamed@d_a_obj_movebox_cpp@::Mthd_Draw(void*) +44 0.00% 100.00%
d_a_obj_movebox/d/actor/d_a_obj_movebox daObjMovebox::@unnamed@d_a_obj_movebox_cpp@::Mthd_IsDelete(void*) +44 0.00% 100.00%
d_a_obj_movebox/d/actor/d_a_obj_movebox daObjMovebox::@unnamed@d_a_obj_movebox_cpp@::Mthd_Execute(void*) +32 0.00% 100.00%
d_a_npc_moi/d/actor/d_a_npc_moi daNpc_Moi_c::walkOnEggshell(void*) +16 98.76% 100.00%
d_a_npc_moi/d/actor/d_a_npc_moi daNpc_Moi_c::talk(void*) +16 97.87% 100.00%
d_a_ep/d/actor/d_a_ep hahen_move(ep_class*) +3 99.75% 100.00%
d_a_obj_ito/d/actor/d_a_obj_ito useHeapInit(fopAc_ac_c*) +3 99.45% 100.00%
d_a_ep/d/actor/d_a_ep daEp_CreateHeap(fopAc_ac_c*) +2 99.68% 100.00%
d_a_obj_flag3/d/actor/d_a_obj_flag3 FlagCloth2_c::calcFlagFactor(cXyz*, cXyz*, cXyz*, int) +1 99.97% 100.00%
d_a_obj_flag3/d/actor/d_a_obj_flag3 daObjFlag3_c::create_init() +1 99.95% 100.00%
d_a_obj_flag3/d/actor/d_a_obj_flag3 FlagCloth2_c::initFlagPos(cXyz*, fopAc_ac_c*) +1 99.93% 100.00%
📈 4 improvements in unmatched functions
Unit Function Bytes Before After
d_a_obj_wchain/d/actor/d_a_obj_wchain daObjWchain_c::setChainPos() +12 98.70% 99.26%
d_a_obj_web0/d/actor/d_a_obj_web0 daObj_Web0_Execute(obj_web0_class*) +3 98.49% 98.79%
d_a_tbox/d/actor/d_a_tbox daTbox_c::lightColorProc() +1 99.09% 99.18%
d_a_npc_kasi_kyu/d/actor/d_a_npc_kasi_kyu daNpcKasiKyu_c::cheer(int) 0 98.44% 98.45%

Report for GZ2P01 (ae6f424 - 72e329c)

📈 Matched code: 82.51% (+0.09%, +10752 bytes)

✅ 10 new matches
Unit Function Bytes Before After
d_a_obj_ito/d/actor/d_a_obj_ito cut_line_calc(obj_ito_class*, ito_s*, int) +126 89.40% 100.00%
d_a_obj_ito/d/actor/d_a_obj_ito action(obj_ito_class*) +61 98.39% 100.00%
d_a_npc_moi/d/actor/d_a_npc_moi daNpc_Moi_c::walkOnEggshell(void*) +16 98.76% 100.00%
d_a_npc_moi/d/actor/d_a_npc_moi daNpc_Moi_c::talk(void*) +16 97.87% 100.00%
d_a_ep/d/actor/d_a_ep hahen_move(ep_class*) +3 99.75% 100.00%
d_a_obj_ito/d/actor/d_a_obj_ito useHeapInit(fopAc_ac_c*) +3 99.45% 100.00%
d_a_ep/d/actor/d_a_ep daEp_CreateHeap(fopAc_ac_c*) +2 99.68% 100.00%
d_a_obj_flag3/d/actor/d_a_obj_flag3 FlagCloth2_c::calcFlagFactor(cXyz*, cXyz*, cXyz*, int) +1 99.97% 100.00%
d_a_obj_flag3/d/actor/d_a_obj_flag3 daObjFlag3_c::create_init() +1 99.95% 100.00%
d_a_obj_flag3/d/actor/d_a_obj_flag3 FlagCloth2_c::initFlagPos(cXyz*, fopAc_ac_c*) +1 99.93% 100.00%
📈 4 improvements in unmatched functions
Unit Function Bytes Before After
d_a_obj_wchain/d/actor/d_a_obj_wchain daObjWchain_c::setChainPos() +12 98.70% 99.26%
d_a_obj_web0/d/actor/d_a_obj_web0 daObj_Web0_Execute(obj_web0_class*) +3 98.49% 98.79%
d_a_tbox/d/actor/d_a_tbox daTbox_c::lightColorProc() +1 99.09% 99.18%
d_a_npc_kasi_kyu/d/actor/d_a_npc_kasi_kyu daNpcKasiKyu_c::cheer(int) 0 98.44% 98.45%

Report for GZ2J01 (ae6f424 - 72e329c)

📈 Matched code: 82.20% (+0.10%, +11772 bytes)
📈 Linked code: 49.78% (+1.72%, +197224 bytes)

✅ 17 new matches
Unit Function Bytes Before After
d_a_obj_movebox/d/actor/d_a_obj_movebox daObjMovebox::@unnamed@d_a_obj_movebox_cpp@::Mthd_Create(void*) +436 0.00% 100.00%
d_a_obj_ito/d/actor/d_a_obj_ito cut_line_calc(obj_ito_class*, ito_s*, int) +126 89.40% 100.00%
d_a_obj_movebox/d/actor/d_a_obj_movebox daObjMovebox::@unnamed@d_a_obj_movebox_cpp@::Mthd_Delete(void*) +88 0.00% 100.00%
d_a_obj_ito/d/actor/d_a_obj_ito action(obj_ito_class*) +61 98.39% 100.00%
d_a_obj_movebox/d/actor/d_a_obj_movebox daObjMovebox::@unnamed@d_a_obj_movebox_cpp@::Mthd_Draw(void*) +44 0.00% 100.00%
d_a_obj_movebox/d/actor/d_a_obj_movebox daObjMovebox::@unnamed@d_a_obj_movebox_cpp@::Mthd_IsDelete(void*) +44 0.00% 100.00%
d_a_obj_movebox/d/actor/d_a_obj_movebox daObjMovebox::@unnamed@d_a_obj_movebox_cpp@::Mthd_Execute(void*) +32 0.00% 100.00%
d_a_npc_moi/d/actor/d_a_npc_moi daNpc_Moi_c::walkOnEggshell(void*) +16 98.76% 100.00%
d_a_npc_moi/d/actor/d_a_npc_moi daNpc_Moi_c::talk(void*) +16 97.87% 100.00%
d_a_ep/d/actor/d_a_ep hahen_move(ep_class*) +3 99.75% 100.00%
d_a_obj_ito/d/actor/d_a_obj_ito useHeapInit(fopAc_ac_c*) +3 99.45% 100.00%
d_a_ep/d/actor/d_a_ep daEp_CreateHeap(fopAc_ac_c*) +2 99.68% 100.00%
d_a_obj_flag3/d/actor/d_a_obj_flag3 FlagCloth2_c::calcFlagFactor(cXyz*, cXyz*, cXyz*, int) +1 99.97% 100.00%
d_a_obj_flag3/d/actor/d_a_obj_flag3 daObjFlag3_c::create_init() +1 99.95% 100.00%
d_a_obj_flag3/d/actor/d_a_obj_flag3 FlagCloth2_c::initFlagPos(cXyz*, fopAc_ac_c*) +1 99.93% 100.00%
d_a_obj_iceleaf/d/actor/d_a_obj_iceleaf daObjIceLeaf_c::action() +1 99.79% 100.00%
d_a_obj_iceleaf/d/actor/d_a_obj_iceleaf daObjIceLeaf_c::event_proc_call() +1 99.79% 100.00%
📈 4 improvements in unmatched functions
Unit Function Bytes Before After
d_a_obj_wchain/d/actor/d_a_obj_wchain daObjWchain_c::setChainPos() +12 98.70% 99.26%
d_a_obj_web0/d/actor/d_a_obj_web0 daObj_Web0_Execute(obj_web0_class*) +3 98.49% 98.79%
d_a_tbox/d/actor/d_a_tbox daTbox_c::lightColorProc() +1 99.09% 99.18%
d_a_npc_kasi_kyu/d/actor/d_a_npc_kasi_kyu daNpcKasiKyu_c::cheer(int) 0 98.44% 98.45%

@TakaRikka TakaRikka merged commit a813649 into zeldaret:main Sep 15, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

d_a_obj_movebox.cpp d_a_obj_flag2.cpp d_a_obj_crvfence.cpp d_a_npc_moi.cpp d_a_ep.cpp

2 participants