Merged
Conversation
Report for ShieldD (2c39c21 - 552dced)📈 Matched code: 19.40% (+0.03%, +4396 bytes) ✅ 43 new matches
...and 13 more new matches 📈 41 improvements in unmatched functions
...and 11 more improvements in unmatched functions Report for GZ2E01 (2c39c21 - 552dced)📈 Matched code: 86.03% (+0.24%, +28016 bytes) ✅ 90 new matches
...and 60 more new matches Report for GZ2P01 (2c39c21 - 552dced)📈 Matched code: 85.15% (+0.24%, +28016 bytes) ✅ 90 new matches
...and 60 more new matches Report for GZ2J01 (2c39c21 - 552dced)📈 Matched code: 85.16% (+0.24%, +28016 bytes) ✅ 90 new matches
...and 60 more new matches |
hatal175
reviewed
Sep 16, 2025
src/d/actor/d_a_npc_grz.cpp
Outdated
| for (int i = 0; i < 4; i++) { | ||
| mSphs[i].Set(mCcDSph); | ||
| mSphs[i].SetStts(&mCcStts); | ||
| mSphs[i].SetAtSe(0xB); |
Contributor
|
This matches fully (USA and JP) if you remove the explicit ctor/dtor for |
TakaRikka
reviewed
Sep 19, 2025
include/d/d_event_manager.h
Outdated
Comment on lines
+34
to
+36
| enum Event_Cut_Nums { | ||
| /* 0x7 */ NUM_EVT_CUTS_e = 0x7, | ||
| }; |
Contributor
There was a problem hiding this comment.
i dont think this change is correct, or rather half-finished. i think this should be local to the files it's being used in and the value changes per file. like in npc_grr, it should be set to 1 like it was before
src/d/actor/d_a_npc_grz.cpp
Outdated
| return true; | ||
| } | ||
|
|
||
| OS_REPORT("%s: 表情Bckアニメーションの登録に失敗しました！\n", "d_a_npc_grz.cpp"); |
Contributor
There was a problem hiding this comment.
you can use the __FILE__ macro instead of manually specifying a filename
src/d/actor/d_a_npc_grz.cpp
Outdated
| case EXPR_LAUGH: | ||
| case EXPR_SNIFF: | ||
| if (mExpressionPhase != 0) { | ||
| mAnmFlags &= 0xFFFFEFFF; |
Contributor
There was a problem hiding this comment.
~0x1000, or whatever anm flag enum is 0x1000
hatal175
approved these changes
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.