Merged
Conversation
Report for GZ2E01 (818dec8 - 665f62d)📈 Matched code: 85.92% (+0.22%, +25348 bytes) ✅ 52 new matches
...and 22 more new matches Report for GZ2P01 (818dec8 - 665f62d)📈 Matched code: 85.03% (+0.22%, +25348 bytes) ✅ 52 new matches
...and 22 more new matches Report for GZ2J01 (818dec8 - 665f62d)📈 Matched code: 83.81% (+0.22%, +25348 bytes) ✅ 52 new matches
...and 22 more new matches Report for ShieldD (818dec8 - 665f62d)📈 Matched code: 19.38% (+0.01%, +2188 bytes) ✅ 22 new matches
📈 31 improvements in unmatched functions
...and 1 more improvements in unmatched functions |
caseif
reviewed
Sep 18, 2025
src/d/actor/d_a_e_gm.cpp
Outdated
| mMode = 3; | ||
| } else { | ||
| field_0xa68 = 1; | ||
| lbl_195_bss_AE = 1; |
Contributor
There was a problem hiding this comment.
Suggested change
| lbl_195_bss_AE = 1; | |
| lbl_195_bss_AF = 1; |
caseif
reviewed
Sep 18, 2025
src/d/actor/d_a_e_gm.cpp
Outdated
| mSph.SetTgType(0); | ||
| mSph.SetAtType(AT_TYPE_0); | ||
| field_0xa68 = 2; | ||
| lbl_195_bss_AE = 1; |
Contributor
There was a problem hiding this comment.
Suggested change
| lbl_195_bss_AE = 1; | |
| lbl_195_bss_AF = 1; |
caseif
reviewed
Sep 18, 2025
src/d/actor/d_a_e_gm.cpp
Outdated
| } | ||
|
|
||
| if (field_0xa6c == 0) { | ||
| if (player->getDamageWaitTimer() != 0 || field_0xa72 != 0 || lbl_195_bss_AE != 0) { |
Contributor
There was a problem hiding this comment.
Suggested change
| if (player->getDamageWaitTimer() != 0 || field_0xa72 != 0 || lbl_195_bss_AE != 0) { | |
| if (player->getDamageWaitTimer() != 0 || field_0xa72 != 0 || lbl_195_bss_AC != 0) { |
caseif
reviewed
Sep 18, 2025
src/d/actor/d_a_e_gm.cpp
Outdated
| damage_check(); | ||
| action(); | ||
|
|
||
| if (l_hitActorID == fopAcM_GetID(this)) { |
Contributor
There was a problem hiding this comment.
Suggested change
| if (l_hitActorID == fopAcM_GetID(this)) { | |
| if (l_coreActorID == fopAcM_GetID(this)) { |
Contributor
|
There were some incorrect |
hatal175
approved these changes
Sep 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure why, but TU is not matching, despite everything looking fine in objdiff, at least on my end.