Skip to content

Commit d29477c

Browse files
committed
d_a_obj_gtaki matching only for demo, slightly closer on retail
1 parent 217c89b commit d29477c

File tree

3 files changed

+29
-19
lines changed

3 files changed

+29
-19
lines changed

configure.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1707,7 +1707,7 @@ def EquivalentFor(*versions):
17071707
ActorRel(Matching, "d_a_obj_gnndemotakie"),
17081708
ActorRel(NonMatching, "d_a_obj_gnndemotakis"),
17091709
ActorRel(MatchingFor("GZLJ01", "GZLE01", "GZLP01"), "d_a_obj_gong"),
1710-
ActorRel(NonMatching, "d_a_obj_gtaki"),
1710+
ActorRel(MatchingFor("D44J01"), "d_a_obj_gtaki"),
17111711
ActorRel(NonMatching, "d_a_obj_hami2"),
17121712
ActorRel(Matching, "d_a_obj_hami3"),
17131713
ActorRel(Matching, "d_a_obj_hami4"),

include/d/actor/d_a_obj_gtaki.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ class daObjGtaki_c : public fopAc_ac_c {
1212
inline bool _delete();
1313
inline bool _draw();
1414
inline bool _execute();
15-
void set_effect() {}
15+
inline void set_effect();
1616

1717
void setDummyTexture();
1818
BOOL CreateHeap();

src/d/actor/d_a_obj_gtaki.cpp

Lines changed: 27 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,8 @@ void daObjGtaki_c::setDummyTexture() {
5252
J3DModelData* modeldata = mpModel->getModelData();
5353
J3DTexture* texture = modeldata->getTexture();
5454
JUTNameTab* textureName = modeldata->getTextureName();
55-
JUT_ASSERT(0xb4, texture != NULL);
56-
JUT_ASSERT(0xb5, textureName != NULL);
55+
JUT_ASSERT(DEMO_SELECT(178, 180), texture != NULL);
56+
JUT_ASSERT(DEMO_SELECT(179, 181), textureName != NULL);
5757

5858
for (u16 i = 0; i<texture->getNum(); i++) {
5959
if(!strcmp(textureName->getName(i), "B_dummy")){
@@ -69,12 +69,12 @@ BOOL daObjGtaki_c::CreateHeap() {
6969
J3DAnmTextureSRTKey* btk;
7070

7171
modelData = (J3DModelData*)dComIfG_getObjectRes("Gtaki", GTAKI_BDL_GTAKI);
72-
JUT_ASSERT(0x10b, modelData != NULL);
72+
JUT_ASSERT(DEMO_SELECT(265, 267), modelData != NULL);
7373
mpModel = mDoExt_J3DModel__create(modelData, 0, 0x11020203);
7474
if(mpModel == NULL) return FALSE;
7575

7676
btk = static_cast<J3DAnmTextureSRTKey*>(dComIfG_getObjectRes("Gtaki", GTAKI_BTK_GTAKI));
77-
JUT_ASSERT(0x115, btk != NULL);
77+
JUT_ASSERT(DEMO_SELECT(275, 277), btk != NULL);
7878
mBtkAnm.init(modelData, btk, true, J3DFrameCtrl::EMode_LOOP, 1.0, 0, -1, false, 0);
7979
setDummyTexture();
8080

@@ -92,6 +92,22 @@ BOOL daObjGtaki_c::CreateHeap() {
9292
return TRUE;
9393
}
9494

95+
void daObjGtaki_c::set_effect() {
96+
JPABaseEmitter* emitter = dComIfGp_particle_setP1(dPa_name::ID_AK_SN_GANONFALLSSPLASH00, &current.pos, NULL, NULL, 0xff, NULL, -1, NULL, NULL, NULL);
97+
if(emitter != NULL){
98+
JGeometry::TVec3<f32> gd_scale;
99+
gd_scale.set(scale.x, scale.y, scale.z);
100+
emitter->setGlobalDynamicsScale(gd_scale);
101+
102+
JGeometry::TVec3<f32> gp_scale;
103+
gp_scale.set(scale.x, scale.x, scale.x);
104+
emitter->setGlobalParticleScale(gp_scale);
105+
106+
emitter->setGlobalPrmColor(mTevStr.mColorC0.r, mTevStr.mColorC0.g, mTevStr.mColorC0.b);
107+
}
108+
set_mtx();
109+
}
110+
95111
/* 00000484-00000604 .text CreateInit__12daObjGtaki_cFv */
96112
bool daObjGtaki_c::CreateInit() {
97113
/* Nonmatching */
@@ -107,16 +123,7 @@ bool daObjGtaki_c::CreateInit() {
107123
dKy_tevstr_init(&mTevStr, home.roomNo, 0xff);
108124
g_env_light.settingTevStruct(TEV_TYPE_BG1, &current.pos, &mTevStr);
109125

110-
JPABaseEmitter* emitter = dComIfGp_particle_setP1(dPa_name::ID_AK_SN_GANONFALLSSPLASH00, &current.pos, NULL, NULL, 0xff, NULL, -1, NULL, NULL, NULL);
111-
if(emitter != NULL){
112-
JGeometry::TVec3<f32> gd_scale (scale.x, scale.y, scale.z);
113-
emitter->setGlobalDynamicsScale(gd_scale);
114-
115-
JGeometry::TVec3<f32> gp_scale(scale.x, scale.x, scale.x);
116-
emitter->setGlobalParticleScale(gp_scale);
117-
emitter->setGlobalPrmColor(mTevStr.mColorC0.r, mTevStr.mColorC0.g, mTevStr.mColorC0.b);
118-
}
119-
set_mtx();
126+
set_effect();
120127
return dComIfG_Bgsp()->Regist(mpBgW, this);
121128
}
122129

@@ -138,7 +145,7 @@ cPhs_State daObjGtaki_c::_create() {
138145
fopAcM_SetupActor(this, daObjGtaki_c);
139146
cPhs_State state = dComIfG_resLoad(&mPhase, "Gtaki");
140147
if(state == cPhs_COMPLEATE_e){
141-
if(!fopAcM_entrySolidHeap(this, CheckCreateHeap, 0x3450)){
148+
if(!fopAcM_entrySolidHeap(this, CheckCreateHeap, DEMO_SELECT(0xD20, 0x3450))){
142149
state = cPhs_ERROR_e;
143150
return state;
144151
}
@@ -148,10 +155,13 @@ cPhs_State daObjGtaki_c::_create() {
148155
}
149156

150157
bool daObjGtaki_c::_delete(){
151-
if(heap != NULL){
158+
#if VERSION > VERSION_DEMO
159+
if(heap != NULL)
160+
#endif
161+
{
152162
dComIfG_Bgsp()->Release(mpBgW);
153163
}
154-
dComIfG_resDelete(&mPhase, "Gtaki");
164+
dComIfG_resDeleteDemo(&mPhase, "Gtaki");
155165
return true;
156166
}
157167

0 commit comments

Comments
 (0)