Skip to content

InbandEventStream should be an element, slice #82

Open
@bdstark

Description

@bdstark

CommonAttributesAndElements.InbandEventStream has an XML tag to be an attribute, but should be an element:

InbandEventStream         *DescriptorType       `xml:"inbandEventStream,attr"`

should be

InbandEventStream         *DescriptorType       `xml:"InbandEventStream,omitempty"`

otherwise it will never be unmarshaled.

I think is is valid to have multiple InbandEventStream elements, which would need more than just this fix.

InbandEventStream         []DescriptorType      `xml:"InbandEventStream,omitempty"`

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @bdstark

        Issue actions

          InbandEventStream should be an element, slice · Issue #82 · zencoder/go-dash