Skip to content

Commit b787356

Browse files
committed
Fix unit test
1 parent 8210a31 commit b787356

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

Source/Core/Utils/CoreUtils.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -529,6 +529,9 @@ int64_t GetFileSize(const std::string& utf8Filename) {
529529
}
530530

531531
std::string FileSizeToString(int64_t sizeBytes) {
532+
if (sizeBytes < 0) {
533+
return {};
534+
}
532535
const char* units[] = { "B", "KB", "MB", "GB", "TB", "PB" };
533536
const int numUnits = sizeof(units) / sizeof(units[0]);
534537
double size = static_cast<double>(sizeBytes);

Source/Core/Utils/Tests/CoreUtilsTest.cpp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -163,11 +163,11 @@ TEST_F(CoreUtilsTest, GetDefaultExtensionForMimeType)
163163

164164
TEST_F(CoreUtilsTest, fileSizeToString)
165165
{
166-
EXPECT_EQ(FileSizeToString(140*1024*1024), "140.0 MB");
167-
EXPECT_EQ(FileSizeToString(static_cast<int64_t>(25.5*1024)), "26 KB");
168-
EXPECT_EQ(FileSizeToString(0), "0 bytes");
169-
EXPECT_EQ("10.0 GB", FileSizeToString(10ULL * 1024 * 1024 * 1024));
170-
EXPECT_EQ("n/a", FileSizeToString(-1));
166+
EXPECT_EQ(FileSizeToString(140*1024*1024), "140 MB");
167+
EXPECT_EQ(FileSizeToString(static_cast<int64_t>(25.5*1024)), "25.5 KB");
168+
EXPECT_EQ(FileSizeToString(0), "0 B");
169+
EXPECT_EQ("10 GB", FileSizeToString(10ULL * 1024 * 1024 * 1024));
170+
EXPECT_EQ("", FileSizeToString(-1));
171171
}
172172

173173
TEST_F(CoreUtilsTest, Utf8ToWstring)

0 commit comments

Comments
 (0)