Skip to content

Commit 957eb3a

Browse files
authored
Merge pull request #128 from zendesk/victor.piolin/update-integration-type
chore(models): Update Iintegration for exporting Suncotwillio and talkTwillio
2 parents 017d759 + 0d4f524 commit 957eb3a

2 files changed

Lines changed: 15 additions & 3 deletions

File tree

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@zendesk/zaf-toolbox",
3-
"version": "0.4.0",
3+
"version": "0.4.1",
44
"description": "A toolbox for ZAF application built with 🩷 by Zendesk Labs",
55
"main": "lib/src/index.js",
66
"types": "lib/src/index.d.ts",

src/models/sunshine-conversation.ts

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -432,7 +432,8 @@ export type IIntegration =
432432
| IIntegrationIos
433433
| IIntegrationMessageBirds
434434
| IIntegrationMessenger
435-
| IIntegrationTwilio
435+
| IIntegrationTwilioTalk
436+
| IIntegrationSuncoTwilio
436437
| IIntegrationTwitter
437438
| IIntegrationWeb
438439
| IIntegrationWhatsApp
@@ -551,15 +552,26 @@ export interface IIntegrationMessenger extends IIntegrationBase {
551552
export interface IIntegrationTwilio extends IIntegrationBase {
552553
type: UserChannelTypes.Twilio;
553554
phoneNumber: string;
554-
isTalk?: boolean;
555+
/**
556+
* Extra boolean to check if it's Talk or Sunco
557+
*/
558+
isTalk: boolean;
555559
}
556560

557561
export interface IIntegrationTwilioTalk extends IIntegrationTwilio {
562+
/**
563+
* Talk Twilio integration as true
564+
*/
565+
isTalk: true;
558566
sms: boolean;
559567
mms: boolean;
560568
}
561569

562570
export interface IIntegrationSuncoTwilio extends IIntegrationTwilio {
571+
/**
572+
* Talk Twilio integration as false
573+
*/
574+
isTalk: false;
563575
/**
564576
* Twilio Account SID.
565577
*/

0 commit comments

Comments
 (0)