compound statement

Author: cryptomail

lib/zendesk_api/middleware/request/api_token_impersonate.rb

@@ -12,14 +12,7 @@ def call(env)
           if Thread.current[:zendesk_thread_local_username] && env[:request_headers][:authorization] =~ /^Basic /
             current_u_p_encoded = env[:request_headers][:authorization].split(/\s+/)[1]
             current_u_p = Base64.urlsafe_decode64(current_u_p_encoded)
-            unless current_u_p.include?("/token:")
-              warn "WARNING: ApiTokenImpersonate passed in invalid format. It should be in the format username/token:APITOKEN"
-              return @app.call(env)
-            end
-
-            parts = current_u_p.split(":")
-
-            unless parts.length == 2 && parts[0].include?("/token")
+            unless current_u_p.include?("/token:") && (parts = current_u_p.split(":")) && parts.length == 2 && parts[0].include?("/token")
               warn "WARNING: ApiTokenImpersonate passed in invalid format. It should be in the format username/token:APITOKEN"
               return @app.call(env)
             end