-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pending Changes for Active Stack #3372
base: develop
Are you sure you want to change the base?
Conversation
Preyas Shah seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
eb058fb
to
cede201
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is one major part missing here still: When running/building a pipeline for which this config attribute is set, we actually need to use the temporary_active_stack
context manager to switch the stack for the run/build.
This will be in PipelineDefinion.build(...)
and PipelineDefinition._run(...)
.
@@ -46,6 +47,7 @@ class PipelineRunConfiguration( | |||
steps: Dict[str, StepConfigurationUpdate] = {} | |||
settings: Dict[str, SerializeAsAny[BaseSettings]] = {} | |||
tags: Optional[List[str]] = None | |||
stack: Optional[Stack] = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be an Optional[str]
instead. The Stack
object is not something that can be defined in a yaml file, which is usually how users specify attributes of this run configuration class. The value for stack
will be the name or ID of a stack, which will then be passed to temporary_active_stack
.
Describe changes
I implemented changes that were left-over as a part of #2370.
Pre-requisites
Please ensure you have done the following:
develop
and the open PR is targetingdevelop
. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes