Skip to content

Commit 9efd90a

Browse files
airtonixCopilot
andauthored
Apply suggestions from code review
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
1 parent 38daae1 commit 9efd90a

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

.github/copilot-instructions.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -300,7 +300,7 @@ describe('ComponentName', () => {
300300
- This bumps minor versions for new features.
301301
- `.github/release-please-config.hotfix.json` defines the release process for hotfix.
302302
- This bumps patch versions for commits.
303-
- There is two separate configurations to allow hotfix releases without affecting the normal release cadence.
303+
- There are two separate configurations to allow hotfix releases without affecting the normal release cadence.
304304
- Both configurations use `node` release type, which means they update the `package.json` version. They also have `extra-files` configured to update `manifest.json` version as well.
305305
- `.github/release-please-manifest.json` tracks the last released version.
306306
## Known Limitations and Context

.github/workflows/changelog.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -54,9 +54,9 @@ jobs:
5454
target-branch: "${{ github.ref_name }}"
5555

5656
- name: Create snapshot branch
57-
if: steps.release-please.outputs.new-release-created == 'true'
57+
if: steps.release-please.outputs.releases_created == 'true'
5858
run: |
5959
git config --global user.name "github-actions[bot]"
6060
git config --global user.email "github-actions[bot]@users.noreply.github.com"
61-
git checkout -b snapshot/${{ steps.release-please.outputs.new_version }}
62-
git push origin snapshot/${{ steps.release-please.outputs.new_version }}
61+
git checkout -b snapshot/${{ fromJson(steps.release-please.outputs.releases).'.'.version }}
62+
git push origin snapshot/${{ fromJson(steps.release-please.outputs.releases).'.'.version }}

.github/workflows/pr.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ jobs:
2525
- uses: actions/checkout@v4
2626
with:
2727
fetch-depth: 0
28+
ref: ${{ github.event.pull_request.head.sha }}
2829

2930

3031
# if the pull request target is default branch, then use normal rules
@@ -44,7 +45,7 @@ jobs:
4445
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
4546
if: startsWith(github.base_ref, 'release/')
4647
with:
47-
types: fix
48+
types: [fix]
4849
ignoreLabels: |
4950
autorelease-pending
5051
bot

0 commit comments

Comments
 (0)