-
-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(delegate): deleteMany fails when the model has compound id fields #2004
Conversation
📝 WalkthroughWalkthroughThis pull request updates the deletion logic in the Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant Delegate as DelegateProxyHandler
participant Utility as ComposeCompoundUniqueField
participant DB as Database
Client->>Delegate: Request deletion (doDeleteMany or deleteBaseRecursively)
Delegate->>Delegate: Check for compound primary keys
alt Compound keys detected
Delegate->>Utility: Generate compound key filter
Utility-->>Delegate: Return compound filter
else Simple key detected
Delegate->>Delegate: Create simple key filter
end
Delegate->>DB: Execute deletion with filter (doDelete)
DB-->>Delegate: Return result
Delegate-->>Client: Forward deletion outcome
Possibly related PRs
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
⏰ Context from checks skipped due to timeout of 90000ms (6)
🔇 Additional comments (5)
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
fixes #1998