Skip to content

Commit d78fe06

Browse files
committed
Prereview workflow changes for await
1 parent 9f9fbe3 commit d78fe06

1 file changed

Lines changed: 27 additions & 14 deletions

File tree

.github/workflows/pre-review.yml

Lines changed: 27 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -80,48 +80,61 @@ jobs:
8080
run: |
8181
PR_NUMBER=${{ github.event.pull_request.number }};
8282
REVIEW_MESSAGE=$(node ./generators/preReview.js "$CONTRIBUTOR" "$CHANGED_FILES" "$GITHUB_PERMISSION_ROLE");
83+
84+
# Save review message to env
8385
echo "REVIEW_MESSAGE<<EOF" >> $GITHUB_ENV;
8486
echo "$REVIEW_MESSAGE" >> $GITHUB_ENV;
8587
echo "EOF" >> $GITHUB_ENV;
8688
87-
# Show in logs
89+
# Show review message in logs
8890
echo "===== REVIEW_MESSAGE ====="
8991
echo "$REVIEW_MESSAGE"
9092
echo "=========================="
9193
92-
# Submit review
94+
# Submit review comment
9395
echo "Submit review comment"
9496
gh pr comment "$PR_NUMBER" --body "$REVIEW_MESSAGE" -R "${{ github.event.pull_request.base.repo.full_name }}"
9597
96-
# Add "Requested Changes" label + assign contributor
97-
echo "Handle \"Changes Requested\" label and contributor assignment"
98+
# Handle "Changes Requested" label + assignee
99+
echo "Handle 'Changes Requested' label and contributor assignment"
98100
if echo "$REVIEW_MESSAGE" | grep -q '\- \[ \]'; then
99101
# Only assign if contributor is a collaborator
100102
if [[ "$GITHUB_PERMISSION_ROLE" != "unknown" ]]; then
103+
echo "Assigning contributor: $CONTRIBUTOR"
101104
gh pr edit "$PR_NUMBER" --add-assignee "$CONTRIBUTOR" -R "${{ github.event.pull_request.base.repo.full_name }}"
102105
fi
103106
104-
# Always add "Changes Requested" label
107+
# Add "Changes Requested" label
108+
echo "Adding 'Changes Requested' label"
105109
gh pr edit "$PR_NUMBER" --add-label "Changes Requested" -R "${{ github.event.pull_request.base.repo.full_name }}"
110+
111+
# Remove "Awaiting Maintainer Validation" if previously added
112+
echo "Removing 'Awaiting Maintainer Validation' label if present"
113+
gh pr edit "$PR_NUMBER" --remove-label "Awaiting Maintainer Validation" -R "${{ github.event.pull_request.base.repo.full_name }}"
106114
else
107-
# Remove the label if no changes requested
115+
# No changes requested → add "Awaiting Maintainer Validation"
116+
echo "Adding 'Awaiting Maintainer Validation' label"
117+
gh pr edit "$PR_NUMBER" --add-label "Awaiting Maintainer Validation" -R "${{ github.event.pull_request.base.repo.full_name }}"
118+
119+
# Remove "Changes Requested" label just in case
120+
echo "Removing 'Changes Requested' label if present"
108121
gh pr edit "$PR_NUMBER" --remove-label "Changes Requested" -R "${{ github.event.pull_request.base.repo.full_name }}"
109122
fi
110123
111-
# Add "invalid" label when changes are out of Art/ folder (and not maintainer)
112-
echo "Handle label \"invalid\""
124+
# Handle "invalid" label
125+
echo "Handle 'invalid' label"
113126
if echo "$REVIEW_MESSAGE" | grep -q -Eqi 'empty file'; then
114-
gh pr edit "$PR_NUMBER" --add-label "invalid" -R "${{ github.event.pull_request.base.repo.full_name }}";
127+
gh pr edit "$PR_NUMBER" --add-label "invalid" -R "${{ github.event.pull_request.base.repo.full_name }}"
115128
else
116-
gh pr edit "$PR_NUMBER" --remove-label "invalid" -R "${{ github.event.pull_request.base.repo.full_name }}";
129+
gh pr edit "$PR_NUMBER" --remove-label "invalid" -R "${{ github.event.pull_request.base.repo.full_name }}"
117130
fi
118131
119-
# Add "Conflict present" when an icon is present in changes
120-
echo "Handle label \"Conflict present\""
132+
# Handle "Conflict present" label
133+
echo "Handle 'Conflict present' label"
121134
if echo "$REVIEW_MESSAGE" | grep -q -Eqi '/icon'; then
122-
gh pr edit "$PR_NUMBER" --add-label "Conflict present" -R "${{ github.event.pull_request.base.repo.full_name }}";
135+
gh pr edit "$PR_NUMBER" --add-label "Conflict present" -R "${{ github.event.pull_request.base.repo.full_name }}"
123136
else
124-
gh pr edit "$PR_NUMBER" --remove-label "Conflict present" -R "${{ github.event.pull_request.base.repo.full_name }}";
137+
gh pr edit "$PR_NUMBER" --remove-label "Conflict present" -R "${{ github.event.pull_request.base.repo.full_name }}"
125138
fi
126139
127140
env:

0 commit comments

Comments
 (0)