Review fixes

Author: externl

cpp/IceBox/hello/HelloServiceI.cpp

@@ -4,6 +4,7 @@
 #include "HelloI.h"
 
 #include <Ice/Ice.h>
+
 #include <iostream>
 
 using namespace std;
@@ -13,14 +14,14 @@ extern "C"
     //
     // Factory function
     //
-    ICE_DECLSPEC_EXPORT IceBox::Service* create(const shared_ptr<Ice::Communicator>&) { return new HelloServiceI; }
+    ICE_DECLSPEC_EXPORT IceBox::Service* create(const Ice::CommunicatorPtr&) { return new HelloServiceI; }
 }
 
 void
 HelloServiceI::start(
     const string& name,
-    const shared_ptr<Ice::Communicator>& communicator,
-    const Ice::StringSeq& /*args*/)
+    const Ice::CommunicatorPtr& communicator,
+    const Ice::StringSeq&)
 {
     _adapter = communicator->createObjectAdapterWithEndpoints("Hello", "tcp -p 10000:udp -p 10000");
     _adapter->add(make_shared<HelloI>(), Ice::stringToIdentity("hello"));

cpp/IceBox/hello/README.md

@@ -9,16 +9,23 @@ cmake --build build --config Release
 
 To run this demo, open two terminal windows. In the first window:
 
+**Linux:**
+
+```shell
+LD_LIBRARY_PATH=./build icebox --IceBox.Service.Hello="HelloService:create"
+```
+
 **Linux/macOS:**
 
 ```shell
-icebox --IceBox.Service.Hello="./build/HelloService:create"
+DYLD_LIBRARY_PATH=./build icebox --IceBox.Service.Hello="HelloService:create"
 ```
 
 **Windows:**
 
 ```shell
-icebox --IceBox.Service.Hello="./build/Release/HelloService:create"
+set PATH=%PATH%;./build/Release
+icebox --IceBox.Service.Hello="HelloService:create"
 ```
 
 In the second window, run the client: