Review fixes

Author: pepone

python/Ice/context/client/main.py

@@ -12,13 +12,14 @@
 
 
 async def main():
-    # Set the Ice.ImplicitContext property to "Shared" before calling Ice.initialize.
-    # This is only necessary for the implicit context API (see below).
     initData = Ice.InitializationData()
     initData.properties = Ice.createProperties(sys.argv)
+
+    # Set the Ice.ImplicitContext property to "Shared" before calling Ice.initialize.
+    # This is only necessary for the implicit context API (see below).
     initData.properties.setProperty("Ice.ImplicitContext", "Shared")
 
-    # Configure the Ice runtime to use asyncio.
+    # Configure the communicator to use asyncio.
     initData.eventLoopAdapter = Ice.asyncio.EventLoopAdapter(asyncio.get_running_loop())
 
     # Create an Ice communicator. We'll use this communicator to create proxies and manage outgoing connections.

python/Ice/greeter/server/main.py

@@ -11,7 +11,8 @@ def main():
     # Create an Ice communicator. We'll use this communicator to create an object adapter.
     with Ice.initialize(sys.argv) as communicator:
         # Create an object adapter that listens for incoming requests and dispatches them to servants.
-        adapter = communicator.createObjectAdapterWithEndpoints("GreeterAdapter", "tcp -p 4061")
+        communicator.getProperties().setProperty("GreeterAdapter.AdapterId", "IceDiscovery/Locator:tcp -h localhost -p 4061")
+        adapter = communicator.createObjectAdapterWithEndpoints("GreeterAdapter", None)
 
         # Register the Chatbot servant with the adapter.
         adapter.add(chatbot.Chatbot(), Ice.Identity(name="greeter"))

python/Ice/optional/server1/console_printer.py

@@ -10,6 +10,5 @@ class ConsolePrinter(WeatherStation):
     """
 
     # Implements the method report from the WeatherStation class generated by the Slice compiler.
-    # This variant is the synchronous implementation.
     def report(self, sensorId: str, reading: AtmosphericConditions | None, current: Ice.Current) -> None:
         print(f"{sensorId} reported {reading} to station v1")

python/Ice/optional/server2/console_printer.py

@@ -10,6 +10,5 @@ class ConsolePrinter(WeatherStation):
     """
 
     # Implements the method report from the WeatherStation class generated by the Slice compiler.
-    # This variant is the synchronous implementation.
     def report(self, sensorId: str, reading: AtmosphericConditions | None, current: Ice.Current) -> None:
         print(f"{sensorId} reported {reading} to station v2")

python/IceDiscovery/greeter/client/main.py

@@ -12,13 +12,14 @@
 
 
 async def main():
-    # Configure the communicator to load the IceDiscovery plug-in during initialization. This plug-in installs a default
-    # locator on the communicator.
     initData = Ice.InitializationData()
     initData.properties = Ice.createProperties(sys.argv)
+
+    # Configure the communicator to load the IceDiscovery plug-in during initialization. This plug-in installs a default
+    # locator on the communicator.
     initData.properties.setProperty("Ice.Plugin.IceDiscovery", "1")
 
-    # Configure the Ice runtime to use asyncio.
+    # Configure the communicator to use asyncio.
     initData.eventLoopAdapter = Ice.asyncio.EventLoopAdapter(asyncio.get_running_loop())
 
     # Create an Ice communicator. We'll use this communicator to create proxies, and manage outgoing connections.

python/IceDiscovery/greeter/server/chatbot.py

@@ -12,7 +12,6 @@ class Chatbot(VisitorCenter.Greeter):
     """
 
     # Implements the method greet from the Greeter class generated by the Slice compiler.
-    # This variant is the synchronous implementation.
     def greet(self, name: str, current: Ice.Current) -> str:
         print(f"Dispatching greet request {{ name = '{name}' }}")
         return f"Hello, {name}!"

python/IceDiscovery/replication/client/main.py

@@ -12,13 +12,12 @@
 
 
 async def main():
-    # Configure the communicator to load the IceDiscovery plug-in during initialization. This plug-in installs a default
-    # locator on the communicator.
     initData = Ice.InitializationData()
     initData.properties = Ice.createProperties(sys.argv)
+    # Configure the communicator to load the IceDiscovery plug-in during initialization. This plug-in installs a default
+    # locator on the communicator.
     initData.properties.setProperty("Ice.Plugin.IceDiscovery", "1")
-
-    # Configure the Ice runtime to use asyncio.
+    # Configure the communicator to use asyncio.
     initData.eventLoopAdapter = Ice.asyncio.EventLoopAdapter(asyncio.get_running_loop())
 
     # Create an Ice communicator. We'll use this communicator to create proxies, and manage outgoing connections.

python/IceDiscovery/replication/server/chatbot.py

@@ -23,7 +23,6 @@ def __init__(self, greeterName: str):
         self._greeterName = greeterName
 
     # Implements the method greet from the Greeter class generated by the Slice compiler.
-    # This variant is the synchronous implementation.
     def greet(self, name: str, current: Ice.Current) -> str:
         print(f"Dispatching greet request {{ name = '{name}' }}")
         return f"Hello, {name}! I am {self._greeterName}. How can I help you today?"