Skip to content

Remove support for bidir controller registration #4587

@externl

Description

@externl

ProcessControllerRegistryPrx registry =
ProcessControllerRegistryPrx.createProxy(_communicator, "Util/ProcessControllerRegistry");
registerProcessController(adapter, registry, processController);

This was only really necessary on Android emulators and was used to setup a bi-dir connection from the controller to the python driver.

Now that the emulator controller doesn't rely on this (we just use a direct proxy). We should remove this and rely on plain driver -> controller discovery like we do for iOS.

Once this part is removed we can remove the if here

proxy.ice_pingAsync().add_done_callback(callback)
(keep the ping though)

and

ice/scripts/Util.py

Lines 2305 to 2313 in 614e051

class ProcessControllerRegistryI(Test.Common.ProcessControllerRegistry):
def __init__(self, remoteProcessController):
self.remoteProcessController = remoteProcessController
def setProcessController(self, proxy, current):
import Test
proxy = Test.Common.ProcessControllerPrx.uncheckedCast(current.con.createProxy(proxy.ice_getIdentity()))
self.remoteProcessController.setProcessController(proxy)

and the relevant Slice interface.

Need to test on a device though :).

Metadata

Metadata

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions