Skip to content

Commit 1f6688e

Browse files
authored
chore: refactor the imports (#2406)
1 parent ae7f1aa commit 1f6688e

File tree

9 files changed

+8
-18
lines changed

9 files changed

+8
-18
lines changed

core/metric/counter.go

+1-2
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
11
package metric
22

33
import (
4+
prom "github.com/prometheus/client_golang/prometheus"
45
"github.com/zeromicro/go-zero/core/proc"
56
"github.com/zeromicro/go-zero/core/prometheus"
6-
7-
prom "github.com/prometheus/client_golang/prometheus"
87
)
98

109
type (

core/metric/counter_test.go

+1-2
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,9 @@ package metric
33
import (
44
"testing"
55

6-
"github.com/zeromicro/go-zero/core/prometheus"
7-
86
"github.com/prometheus/client_golang/prometheus/testutil"
97
"github.com/stretchr/testify/assert"
8+
"github.com/zeromicro/go-zero/core/prometheus"
109
)
1110

1211
func TestNewCounterVec(t *testing.T) {

core/metric/gauge.go

+1-2
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
11
package metric
22

33
import (
4+
prom "github.com/prometheus/client_golang/prometheus"
45
"github.com/zeromicro/go-zero/core/proc"
56
"github.com/zeromicro/go-zero/core/prometheus"
6-
7-
prom "github.com/prometheus/client_golang/prometheus"
87
)
98

109
type (

core/metric/histogram.go

+1-2
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
11
package metric
22

33
import (
4+
prom "github.com/prometheus/client_golang/prometheus"
45
"github.com/zeromicro/go-zero/core/proc"
56
"github.com/zeromicro/go-zero/core/prometheus"
6-
7-
prom "github.com/prometheus/client_golang/prometheus"
87
)
98

109
type (

core/stores/redis/hook.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ func (h hook) AfterProcess(ctx context.Context, cmd red.Cmder) error {
5757
}
5858

5959
metricReqDur.Observe(int64(duration/time.Millisecond), cmd.Name())
60-
if msg := errFormat(err); len(msg) > 0 {
60+
if msg := formatError(err); len(msg) > 0 {
6161
metricReqErr.Inc(cmd.Name(), msg)
6262
}
6363

@@ -104,14 +104,14 @@ func (h hook) AfterProcessPipeline(ctx context.Context, cmds []red.Cmder) error
104104
}
105105

106106
metricReqDur.Observe(int64(duration/time.Millisecond), "Pipeline")
107-
if msg := errFormat(batchError.Err()); len(msg) > 0 {
107+
if msg := formatError(batchError.Err()); len(msg) > 0 {
108108
metricReqErr.Inc("Pipeline", msg)
109109
}
110110

111111
return nil
112112
}
113113

114-
func errFormat(err error) string {
114+
func formatError(err error) string {
115115
if err == nil || err == red.Nil {
116116
return ""
117117
}

core/stores/sqlx/metrics.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ package sqlx
22

33
import "github.com/zeromicro/go-zero/core/metric"
44

5-
const namespace = "mysql_client"
5+
const namespace = "sql_client"
66

77
var (
88
metricReqDur = metric.NewHistogramVec(&metric.HistogramVecOpts{

core/stores/sqlx/sqlconn.go

-4
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,6 @@ func (db *commonSqlConn) ExecCtx(ctx context.Context, q string, args ...interfac
153153
result, err = exec(ctx, conn, q, args...)
154154
return err
155155
}, db.acceptable)
156-
157156
if err == breaker.ErrServiceUnavailable {
158157
metricReqErr.Inc("Exec", "breaker")
159158
}
@@ -190,7 +189,6 @@ func (db *commonSqlConn) PrepareCtx(ctx context.Context, query string) (stmt Stm
190189
}
191190
return nil
192191
}, db.acceptable)
193-
194192
if err == breaker.ErrServiceUnavailable {
195193
metricReqErr.Inc("Prepare", "breaker")
196194
}
@@ -281,7 +279,6 @@ func (db *commonSqlConn) TransactCtx(ctx context.Context, fn func(context.Contex
281279
err = db.brk.DoWithAcceptable(func() error {
282280
return transact(ctx, db, db.beginTx, fn)
283281
}, db.acceptable)
284-
285282
if err == breaker.ErrServiceUnavailable {
286283
metricReqErr.Inc("Transact", "breaker")
287284
}
@@ -315,7 +312,6 @@ func (db *commonSqlConn) queryRows(ctx context.Context, scanner func(*sql.Rows)
315312
}, func(err error) bool {
316313
return qerr == err || db.acceptable(err)
317314
})
318-
319315
if err == breaker.ErrServiceUnavailable {
320316
metricReqErr.Inc("queryRows", "breaker")
321317
}

zrpc/internal/clientinterceptors/prometheusinterceptor.go

-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ import (
77

88
"github.com/zeromicro/go-zero/core/metric"
99
"github.com/zeromicro/go-zero/core/timex"
10-
1110
"google.golang.org/grpc"
1211
"google.golang.org/grpc/status"
1312
)

zrpc/internal/serverinterceptors/prometheusinterceptor.go

-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ import (
77

88
"github.com/zeromicro/go-zero/core/metric"
99
"github.com/zeromicro/go-zero/core/timex"
10-
1110
"google.golang.org/grpc"
1211
"google.golang.org/grpc/status"
1312
)

0 commit comments

Comments
 (0)