Skip to content

Commit 4d3c831

Browse files
committed
Move task utils to test project where it belongs
1 parent 92aae64 commit 4d3c831

6 files changed

+18
-20
lines changed

src/NetMQ.Tests/NetMQMonitorTests.cs

+2-2
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ public void StartAsync()
6868
Thread.Sleep(200);
6969
Assert.Equal(TaskStatus.Running, task.Status);
7070
monitor.Stop();
71-
Assert.True(Utils.Tasks.Wait(task, TimeSpan.FromMilliseconds(1000)));
71+
Assert.True(TaskUtils.Wait(task, TimeSpan.FromMilliseconds(1000)));
7272
}
7373
}
7474
#endif
@@ -154,7 +154,7 @@ public void MonitorDisposeProperlyWhenDisposedAfterMonitoredTcpSocket()
154154
}
155155
Thread.Sleep(100);
156156
// Monitor.Dispose should complete
157-
var completed = Utils.Tasks.Wait(Task.Factory.StartNew(() => monitor.Dispose()), TimeSpan.FromMilliseconds(1000));
157+
var completed = TaskUtils.Wait(Task.Factory.StartNew(() => monitor.Dispose()), TimeSpan.FromMilliseconds(1000));
158158
Assert.True(completed);
159159
}
160160
// NOTE If this test fails, it will hang because context.Dispose will block

src/NetMQ.Tests/NetMQPollerTest.cs

+9-9
Original file line numberDiff line numberDiff line change
@@ -395,7 +395,7 @@ public void RemoveSocket()
395395

396396
poller.Stop();
397397
// await the pollerTask, 1ms should suffice
398-
Utils.Tasks.Wait(pollerTask, TimeSpan.FromMilliseconds(1));
398+
TaskUtils.Wait(pollerTask, TimeSpan.FromMilliseconds(1));
399399
Assert.True(pollerTask.IsCompleted);
400400
}
401401
}
@@ -879,7 +879,7 @@ public void OneTask()
879879
Assert.True(poller.CanExecuteTaskInline, "Should be on NetMQPoller thread");
880880
});
881881
task.Start(poller);
882-
Utils.Tasks.Wait(task);
882+
TaskUtils.Wait(task);
883883

884884
Assert.True(triggered);
885885
}
@@ -894,7 +894,7 @@ public void SetsCurrentTaskScheduler()
894894

895895
var task = new Task(() => Assert.Same(TaskScheduler.Current, poller));
896896
task.Start(poller);
897-
Utils.Tasks.Wait(task);
897+
TaskUtils.Wait(task);
898898
}
899899
}
900900

@@ -911,7 +911,7 @@ public void CanExecuteTaskInline()
911911

912912
var task = new Task(() => Assert.True(poller.CanExecuteTaskInline));
913913
task.Start(poller);
914-
Utils.Tasks.Wait(task);
914+
TaskUtils.Wait(task);
915915
}
916916
}
917917

@@ -941,8 +941,8 @@ public void ContinueWith()
941941
}, poller);
942942

943943
task.Start(poller);
944-
Utils.Tasks.Wait(task);
945-
Utils.Tasks.Wait(task2);
944+
TaskUtils.Wait(task);
945+
TaskUtils.Wait(task2);
946946

947947
Assert.Equal(threadId1, threadId2);
948948
Assert.Equal(1, runCount1);
@@ -982,9 +982,9 @@ public void TwoThreads()
982982
}
983983
});
984984

985-
Utils.Tasks.Wait(t1, TimeSpan.FromMilliseconds(1000));
986-
Utils.Tasks.Wait(t2, TimeSpan.FromMilliseconds(1000));
987-
Utils.Tasks.WaitAll(allTasks.ToArray(), TimeSpan.FromMilliseconds(1000));
985+
TaskUtils.Wait(t1, TimeSpan.FromMilliseconds(1000));
986+
TaskUtils.Wait(t2, TimeSpan.FromMilliseconds(1000));
987+
TaskUtils.WaitAll(allTasks.ToArray(), TimeSpan.FromMilliseconds(1000));
988988

989989
Assert.Equal(100, count1);
990990
Assert.Equal(100, count2);

src/NetMQ.Tests/NetMQQueueTests.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ public void EnqueueShouldNotBlockWhenCapacityIsZero()
3939
}
4040
});
4141

42-
bool completed = Utils.Tasks.Wait(task, TimeSpan.FromSeconds(1));
42+
bool completed = TaskUtils.Wait(task, TimeSpan.FromSeconds(1));
4343
Assert.True(completed, "Enqueue task should have completed " + socketWatermarkCapacity + " enqueue within 1 second");
4444
}
4545
}

src/NetMQ.Tests/PgmTests.cs

+3-3
Original file line numberDiff line numberDiff line change
@@ -230,8 +230,8 @@ public void Sending1000Messages()
230230
}
231231
});
232232

233-
Utils.Tasks.Wait(pubTask);
234-
Utils.Tasks.Wait(subTask);
233+
TaskUtils.Wait(pubTask);
234+
TaskUtils.Wait(subTask);
235235

236236
Assert.Equal(1000, count);
237237
}
@@ -291,7 +291,7 @@ public void SubscriberCleanupOnUnbind(string address)
291291

292292
monitor.Stop();
293293

294-
Utils.Tasks.Wait(monitorTask);
294+
TaskUtils.Wait(monitorTask);
295295
}
296296
}
297297
}

src/NetMQ.Tests/SocketTests.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ public void ReceiveMessageWithTimeout()
134134
t1.Start();
135135
t2.Start();
136136

137-
Utils.Tasks.WaitAll(new[]{t1, t2});
137+
TaskUtils.WaitAll(new[]{t1, t2});
138138
}
139139
}
140140

src/NetMQ/Utils/Tasks.cs src/NetMQ.Tests/TaskUtils.cs

+2-4
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,11 @@
11
using System;
2-
using System.Collections.Generic;
32
using System.Linq;
4-
using System.Text;
53
using System.Threading;
64
using System.Threading.Tasks;
75

8-
namespace NetMQ.Utils
6+
namespace NetMQ.Tests
97
{
10-
internal class Tasks
8+
internal class TaskUtils
119
{
1210
internal static async Task PollUntil(Func<bool> condition, TimeSpan timeout)
1311
{

0 commit comments

Comments
 (0)