Skip to content

Commit 946d96f

Browse files
committed
dont NACK failed messages. That gets us into a loop of failing the same messages over and over again
1 parent b92fb93 commit 946d96f

File tree

2 files changed

+14
-20
lines changed

2 files changed

+14
-20
lines changed

nonfree/controller/PubSubListener.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,6 @@ void PubSubListener::subscribe()
8989
return true;
9090
}
9191
else {
92-
std::move(h).nack();
9392
span->SetStatus(opentelemetry::trace::StatusCode::kError, "onNotification failed");
9493
return false;
9594
}

rustybits/Cargo.lock

Lines changed: 14 additions & 19 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)