Skip to content

Commit be8ce08

Browse files
committed
Revert "feat: Add configurable wake-up time for button and field detection"
This reverts commit 9b05d35.
1 parent fabc814 commit be8ce08

7 files changed

Lines changed: 11 additions & 87 deletions

File tree

CHANGELOG.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,8 @@ This project uses the changelog in accordance with [keepchangelog](http://keepac
44

55
## [v2.0.0][2025-06-28]
66
- Added basic script support (@zeusricote)
7-
- Added configurable wake-up time for button and field detection (1000-60000 ms) (@zeusricote)
7+
8+
89
- Added commands to dump and clone Mifare tags
910
- Improved slot LED indication when switching slots
1011
- Fixed hardnested subprocess call to work in read-only directories

firmware/application/src/app_cmd.c

Lines changed: 0 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -233,36 +233,6 @@ static data_frame_tx_t *cmd_processor_set_long_press_threshold(uint16_t cmd, uin
233233
return data_frame_make(cmd, STATUS_SUCCESS, 0, NULL);
234234
}
235235

236-
static data_frame_tx_t *cmd_processor_get_wakeup_button_time(uint16_t cmd, uint16_t status, uint16_t length, uint8_t *data) {
237-
uint16_t time_ms = settings_get_wakeup_button_time();
238-
uint8_t resp_data[2] = {(uint8_t)(time_ms >> 8), (uint8_t)(time_ms & 0xFF)};
239-
return data_frame_make(cmd, STATUS_SUCCESS, sizeof(resp_data), resp_data);
240-
}
241-
242-
static data_frame_tx_t *cmd_processor_set_wakeup_button_time(uint16_t cmd, uint16_t status, uint16_t length, uint8_t *data) {
243-
if (length != 2) {
244-
return data_frame_make(cmd, STATUS_PAR_ERR, 0, NULL);
245-
}
246-
uint16_t time_ms = ((uint16_t)data[0] << 8) | data[1];
247-
settings_set_wakeup_button_time(time_ms);
248-
return data_frame_make(cmd, STATUS_SUCCESS, 0, NULL);
249-
}
250-
251-
static data_frame_tx_t *cmd_processor_get_wakeup_field_time(uint16_t cmd, uint16_t status, uint16_t length, uint8_t *data) {
252-
uint16_t time_ms = settings_get_wakeup_field_time();
253-
uint8_t resp_data[2] = {(uint8_t)(time_ms >> 8), (uint8_t)(time_ms & 0xFF)};
254-
return data_frame_make(cmd, STATUS_SUCCESS, sizeof(resp_data), resp_data);
255-
}
256-
257-
static data_frame_tx_t *cmd_processor_set_wakeup_field_time(uint16_t cmd, uint16_t status, uint16_t length, uint8_t *data) {
258-
if (length != 2) {
259-
return data_frame_make(cmd, STATUS_PAR_ERR, 0, NULL);
260-
}
261-
uint16_t time_ms = ((uint16_t)data[0] << 8) | data[1];
262-
settings_set_wakeup_field_time(time_ms);
263-
return data_frame_make(cmd, STATUS_SUCCESS, 0, NULL);
264-
}
265-
266236
#if defined(PROJECT_CHAMELEON_ULTRA)
267237

268238
static data_frame_tx_t *cmd_processor_hf14a_scan(uint16_t cmd, uint16_t status, uint16_t length, uint8_t *data) {
@@ -1390,10 +1360,6 @@ static cmd_data_map_t m_data_cmd_map[] = {
13901360
{ DATA_CMD_SET_BLE_PAIRING_ENABLE, NULL, cmd_processor_set_ble_pairing_enable, NULL },
13911361
{ DATA_CMD_GET_LONG_PRESS_THRESHOLD, NULL, cmd_processor_get_long_press_threshold, NULL },
13921362
{ DATA_CMD_SET_LONG_PRESS_THRESHOLD, NULL, cmd_processor_set_long_press_threshold, NULL },
1393-
{ DATA_CMD_GET_WAKEUP_BUTTON_TIME, NULL, cmd_processor_get_wakeup_button_time, NULL },
1394-
{ DATA_CMD_SET_WAKEUP_BUTTON_TIME, NULL, cmd_processor_set_wakeup_button_time, NULL },
1395-
{ DATA_CMD_GET_WAKEUP_FIELD_TIME, NULL, cmd_processor_get_wakeup_field_time, NULL },
1396-
{ DATA_CMD_SET_WAKEUP_FIELD_TIME, NULL, cmd_processor_set_wakeup_field_time, NULL },
13971363

13981364
#if defined(PROJECT_CHAMELEON_ULTRA)
13991365

firmware/application/src/app_cmd.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,7 @@
22
#define APP_CMD_H
33

44
#include <stdint.h>
5-
#include <stdbool.h>
65
#include "dataframe.h"
7-
#include "settings.h"
86

97

108
typedef data_frame_tx_t *(*cmd_processor)(uint16_t cmd, uint16_t status, uint16_t length, uint8_t *data);

firmware/application/src/data_cmd.h

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -47,10 +47,6 @@
4747
#define DATA_CMD_SET_BLE_PAIRING_ENABLE (1037)
4848
#define DATA_CMD_GET_LONG_PRESS_THRESHOLD (1038)
4949
#define DATA_CMD_SET_LONG_PRESS_THRESHOLD (1039)
50-
#define DATA_CMD_GET_WAKEUP_BUTTON_TIME (1040)
51-
#define DATA_CMD_SET_WAKEUP_BUTTON_TIME (1041)
52-
#define DATA_CMD_GET_WAKEUP_FIELD_TIME (1042)
53-
#define DATA_CMD_SET_WAKEUP_FIELD_TIME (1043)
5450

5551
//
5652
// ******************************************************************

firmware/application/src/settings.c

Lines changed: 6 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -55,13 +55,7 @@ void settings_init_ble_pairing_enable_config(void) {
5555

5656
// add on version6
5757
void settings_init_long_press_threshold_config(void) {
58-
config.long_press_threshold = 500; // 500ms default
59-
}
60-
61-
// add on version7
62-
void settings_init_wakeup_time_config(void) {
63-
config.wakeup_button_time = 8000; // 8s default for button wake-up
64-
config.wakeup_field_time = 4000; // 4s default for field wake-up
58+
config.long_press_threshold = 1000; // default 1000ms
6559
}
6660

6761
void settings_init_config(void) {
@@ -72,7 +66,6 @@ void settings_init_config(void) {
7266
settings_init_ble_connect_key_config();
7367
settings_init_ble_pairing_enable_config();
7468
settings_init_long_press_threshold_config();
75-
settings_init_wakeup_time_config();
7669
}
7770

7871
void settings_migrate(void) {
@@ -312,30 +305,10 @@ uint16_t settings_get_long_press_threshold(void) {
312305
}
313306

314307
void settings_set_long_press_threshold(uint16_t duration) {
315-
if (duration < 100) duration = 100;
316-
if (duration > 2000) duration = 2000;
308+
// Enforce minimum value of 200ms
309+
if (duration < 200) {
310+
duration = 200;
311+
}
312+
// Maximum value is implicitly handled by uint16_t
317313
config.long_press_threshold = duration;
318-
update_config_crc();
319-
}
320-
321-
void settings_set_wakeup_button_time(uint16_t time_ms) {
322-
if (time_ms < 1000) time_ms = 1000; // Minimum 1 second
323-
if (time_ms > 60000) time_ms = 60000; // Maximum 60 seconds
324-
config.wakeup_button_time = time_ms;
325-
update_config_crc();
326-
}
327-
328-
uint16_t settings_get_wakeup_button_time(void) {
329-
return config.wakeup_button_time;
330-
}
331-
332-
void settings_set_wakeup_field_time(uint16_t time_ms) {
333-
if (time_ms < 1000) time_ms = 1000; // Minimum 1 second
334-
if (time_ms > 60000) time_ms = 60000; // Maximum 60 seconds
335-
config.wakeup_field_time = time_ms;
336-
update_config_crc();
337-
}
338-
339-
uint16_t settings_get_wakeup_field_time(void) {
340-
return config.wakeup_field_time;
341314
}

firmware/application/src/settings.h

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
#include "utils.h"
77

8-
#define SETTINGS_CURRENT_VERSION 7
8+
#define SETTINGS_CURRENT_VERSION 6
99
#define BLE_PAIRING_KEY_LEN 6
1010
#define DEFAULT_BLE_PAIRING_KEY "123456" // length must == 6
1111

@@ -49,8 +49,6 @@ typedef struct ALIGN_U32 {
4949

5050
// 2 bytes
5151
uint16_t long_press_threshold; // in ms
52-
uint16_t wakeup_button_time; // in ms
53-
uint16_t wakeup_field_time; // in ms
5452

5553
// 1 byte
5654
uint8_t reserved1; // see bottom.
@@ -81,11 +79,4 @@ bool settings_get_ble_pairing_enable(void);
8179
bool settings_get_ble_pairing_enable_first_load(void);
8280
uint16_t settings_get_long_press_threshold(void);
8381
void settings_set_long_press_threshold(uint16_t duration);
84-
85-
// Wake-up time settings
86-
void settings_set_wakeup_button_time(uint16_t time_ms);
87-
uint16_t settings_get_wakeup_button_time(void);
88-
void settings_set_wakeup_field_time(uint16_t time_ms);
89-
uint16_t settings_get_wakeup_field_time(void);
90-
9182
#endif

firmware/application/src/utils/syssleep.h

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,10 @@
22
#define SYS_SLEEP_H__
33

44
#include <stdint.h>
5-
#include "settings.h"
65

76
// Wake up equipment
8-
#define SLEEP_DELAY_MS_BUTTON_WAKEUP (settings_get_wakeup_button_time()) // The sleep delay of the button awakened
9-
#define SLEEP_DELAY_MS_FIELD_WAKEUP (settings_get_wakeup_field_time()) // The sleep delay (including high and low frequencies) of the field wake -up (including high and low frequency)
7+
#define SLEEP_DELAY_MS_BUTTON_WAKEUP 8000 // The sleep delay of the button awakened
8+
#define SLEEP_DELAY_MS_FIELD_WAKEUP 4000 // The sleep delay (including high and low frequencies) of the field wake -up (including high and low frequency)
109
#define SLEEP_DELAY_MS_FIRST_POWER 1000 // The sleep delay of the first power supply (access to the battery)
1110

1211
// The operating state is delayed

0 commit comments

Comments
 (0)