Update version 2.8.12 (#1278)

mini2s · web-flow · commit 34e465994d22 · 2026-06-09T14:27:42.000+08:00
* chore: update version to 2.8.12 and update changelog

* feat: add built-in skills notification
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,8 @@
 - Add timeout option to CoStrict model fetching and caching (#1276)
 - Migrate pnpm config to workspace yaml and apply security overrides (#1273)
 - Fix vitest Mock type compatibility and add missing node types (#1273)
+- Add built-in skills notification
+- Fix known issues
 
 ## [2.8.11]
 
diff --git a/packages/telemetry/src/__tests__/PostHogTelemetryClient.test.ts b/packages/telemetry/src/__tests__/PostHogTelemetryClient.test.ts
@@ -48,7 +48,9 @@ describe("PostHogTelemetryClient", () => {
 			optOut: vi.fn(),
 			shutdown: vi.fn().mockResolvedValue(undefined),
 		}
-		;(PostHog as any).mockImplementation(() => mockPostHogClient)
+		;(PostHog as any).mockImplementation(function () {
+			return mockPostHogClient
+		})
 
 		// @ts-expect-error - Accessing private static property for testing
 		PostHogTelemetryClient._instance = undefined
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/pnpm-workspace.yaml b/pnpm-workspace.yaml
@@ -62,4 +62,5 @@ overrides:
     "qs@>=6.11.1 <=6.15.1": ">=6.15.2"
     "tmp@<0.2.6": ">=0.2.6"
     "axios@>=1.0.0 <1.16.0": ">=1.16.0"
-    "vitest@<4.1.0": ">=4.1.0"
+    "vitest": "3.2.6"
+    "@ai-sdk/provider-utils": "4.0.27"
diff --git a/src/api/providers/costrict.ts b/src/api/providers/costrict.ts
@@ -951,11 +951,7 @@ export class CostrictAiHandler extends BaseProvider implements SingleCompletionH
 		if (info.id !== id) {
 			info.id = id
 		}
-		const _mid = id.toLowerCase()
-		if (
-			(_mid?.includes("auto") || _mid?.includes("kimi") || _mid?.includes("minimax") || _mid?.includes("glm") || _mid?.includes("deepseek-v4") || _mid?.includes("qwen-3")) &&
-			info.preserveReasoning == null
-		) {
+		if (info.preserveReasoning == null) {
 			info.preserveReasoning = true
 		}
 		return { id, info, ...params }
diff --git a/src/api/providers/fetchers/__tests__/modelCache.spec.ts b/src/api/providers/fetchers/__tests__/modelCache.spec.ts
@@ -332,7 +332,7 @@ describe("empty cache protection", () => {
 			})
 
 			expect(result).toEqual(diskModels)
-			expect(mockGetCostrictModels).toHaveBeenCalledWith("https://api.example.com", "test-api-key", undefined)
+			expect(mockGetCostrictModels).toHaveBeenCalledWith("https://api.example.com", "test-api-key", undefined, 2000)
 
 			await vi.waitFor(() => {
 				expect(mockSet).toHaveBeenCalledWith("costrict", refreshedModels)
diff --git a/src/api/providers/fetchers/modelCache.ts b/src/api/providers/fetchers/modelCache.ts
@@ -154,7 +154,7 @@ export const getModels = async (options: GetModelsOptions): Promise<ModelRecord>
 				models = undefined
 			} else {
 				if (!hadMemoryModels && refreshOnDiskCacheHit) {
-					options.timeout = 2000 // Set a short timeout for the background refresh to prevent long waits on slow API responses
+					options.timeout = 1000 // Set a short timeout for the background refresh to prevent long waits on slow API responses
 					void refreshModels(options).catch((error) => {
 						console.error(`[getModels] Background refresh failed for ${provider}:`, error)
 					})
diff --git a/src/core/webview/webviewMessageHandler.ts b/src/core/webview/webviewMessageHandler.ts
@@ -89,7 +89,7 @@ import { ErrorCodeManager } from "../costrict/error-code"
 import { writeCostrictRuntimeAuth } from "../costrict/runtime-config"
 import { fetchCostrictQuotaInfo, fetchCostrictInviteCode } from "../../api/providers/fetchers/costrict"
 import { initNotificationService } from "../costrict/notification"
-import { installGitHubSkills } from "../../services/skills/github-skills-installer"
+import { initReviewSkills, showSkillsInitNotification } from "../../services/skills/github-skills-init"
 import delay from "delay"
 import { ensureProjectWikiSubtasksExists } from "../costrict/wiki/projectWikiHelpers"
 import { setPendingTodoList } from "../tools/UpdateTodoListTool"
@@ -782,8 +782,11 @@ export const webviewMessageHandler = async (
 					})
 
 					void provider.getState().then((state) => {
-						void installGitHubSkills(provider.context, state.language ?? "zh-CN")
-							.then(() => provider.log("[BuiltinSkills] Bundled skills installed"))
+						void initReviewSkills(provider.context, state.language ?? "zh-CN")
+							.then((summary) => {
+								provider.log("[BuiltinSkills] Bundled skills installed")
+								showSkillsInitNotification(summary)
+							})
 							.catch((error) =>
 								provider.log(
 									`[BuiltinSkills] Failed to install: ${error instanceof Error ? error.message : String(error)}`,
@@ -854,8 +857,11 @@ export const webviewMessageHandler = async (
 						// Initialize subtask files for the new language.
 						await ensureProjectWikiSubtasksExists(newValue as string)
 						// Reinstall bundled skills with the new locale
-						void installGitHubSkills(provider.context, newValue as string)
-							.then(() => provider.log("[BuiltinSkills] Bundled skills reinstalled"))
+						void initReviewSkills(provider.context, newValue as string)
+							.then((summary) => {
+								provider.log("[BuiltinSkills] Bundled skills reinstalled")
+								showSkillsInitNotification(summary)
+							})
 							.catch((error) =>
 								provider.log(
 									`[BuiltinSkills] Failed to reinstall: ${error instanceof Error ? error.message : String(error)}`,
diff --git a/src/i18n/costrict-i18n/locales/en/common.json b/src/i18n/costrict-i18n/locales/en/common.json
@@ -215,6 +215,10 @@
 	"notification": {
 		"confirm": "Confirm"
 	},
+	"builtinSkills": {
+		"init": "Built-in skills ({{skills}}) have been installed to {{path}}",
+		"updated": "Built-in skills ({{skills}}) have been updated in {{path}}"
+	},
 	"ipc": {
 		"connectionFailed": "IPC connection failed, unable to connect to local server",
 		"reloadWindow": "Reload Window",
diff --git a/src/i18n/costrict-i18n/locales/zh-CN/common.json b/src/i18n/costrict-i18n/locales/zh-CN/common.json
diff --git a/src/i18n/costrict-i18n/locales/zh-TW/common.json b/src/i18n/costrict-i18n/locales/zh-TW/common.json
diff --git a/src/services/checkpoints/ShadowCheckpointService.ts b/src/services/checkpoints/ShadowCheckpointService.ts
@@ -46,6 +46,13 @@ function createSanitizedGit(baseDir: string): SimpleGit {
 			continue
 		}
 
+		// Skip generic environment variables that simple-git considers unsafe
+		// for command injection (e.g. PAGER, EDITOR, VISUAL, BROWSER)
+		if (key === "PAGER" || key === "EDITOR" || key === "VISUAL" || key === "BROWSER") {
+			removedVars.push(`${key}=${value}`)
+			continue
+		}
+
 		// Only include defined values
 		if (value !== undefined) {
 			sanitizedEnv[key] = value
@@ -62,6 +69,11 @@ function createSanitizedGit(baseDir: string): SimpleGit {
 	const options: Partial<SimpleGitOptions> = {
 		baseDir,
 		config: [],
+		unsafe: {
+			allowUnsafeTemplateDir: true,
+			allowUnsafeConfigEnvCount: true,
+			allowUnsafePager: true,
+		} as SimpleGitOptions["unsafe"],
 	}
 
 	// Create git instance and set the sanitized environment
diff --git a/src/services/skills/github-skills-init.ts b/src/services/skills/github-skills-init.ts
@@ -19,6 +19,7 @@ import * as path from "path"
 import * as vscode from "vscode"
 import { getGlobalCostrictDirectory } from "../roo-config"
 import { createLogger, ILogger } from "../../utils/logger"
+import { t } from "../../i18n"
 
 const logger: ILogger = createLogger("BuiltinSkillsInstaller")
 
@@ -183,14 +184,19 @@ async function copyBundledSkill(
 	}
 }
 
+/**
+ * Installation result for a single skill
+ */
+type SkillInstallResult = "up-to-date" | "installed" | "updated" | "failed"
+
 /**
  * Install a single built-in skill
  */
-async function installBuiltinSkill(
+async function initBuiltinSkill(
 	config: BuiltinSkillConfig,
 	bundledSkillsPath: string,
 	preferredLocale: string,
-): Promise<boolean> {
+): Promise<SkillInstallResult> {
 	const { name, mode } = config
 
 	// Get bundled commit SHA from index.json
@@ -199,7 +205,7 @@ async function installBuiltinSkill(
 	// Skip if commitSha is null/empty (skill not properly bundled)
 	if (!bundledCommitSha) {
 		logger.info(`[BuiltinSkills] ${name}: No commitSha in index.json, skipping`)
-		return false
+		return "failed"
 	}
 
 	// Resolve locale from available locales
@@ -222,7 +228,7 @@ async function installBuiltinSkill(
 	if (dirExists) {
 		if (installedVersion === expectedVersion) {
 			logger.info(`[BuiltinSkills] ${name}: Up to date (${expectedVersion})`)
-			return true
+			return "up-to-date"
 		}
 		const shortInstalled = installedVersion?.slice(0, 7) || "unknown"
 		const shortBundled = bundledCommitSha?.slice(0, 7) || "unknown"
@@ -241,11 +247,25 @@ async function installBuiltinSkill(
 		const modeInfo = mode ? ` to ${mode} mode` : ""
 		const shortSha = bundledCommitSha?.slice(0, 7) || "unknown"
 		logger.info(`[BuiltinSkills] ${name}: Installed from bundled skills${modeInfo} (${shortSha}:${locale})`)
-		return true
+		return dirExists ? "updated" : "installed"
 	}
 
 	logger.info(`[BuiltinSkills] ${name}: Bundled skills not found`)
-	return false
+	return "failed"
+}
+
+/**
+ * Installation summary returned by initReviewSkills
+ */
+export interface SkillsInitSummary {
+	/** Skills that were freshly installed */
+	installed: string[]
+	/** Skills that were updated to a new version */
+	updated: string[]
+	/** Skills that were already up to date */
+	upToDate: string[]
+	/** Skills that failed to install */
+	failed: string[]
 }
 
 /**
@@ -259,10 +279,11 @@ async function installBuiltinSkill(
  *
  * Skills are automatically updated when the bundled version or locale changes.
  */
-export async function installGitHubSkills(
+export async function initReviewSkills(
 	context: vscode.ExtensionContext,
 	preferredLocale: string = "zh-CN",
-): Promise<void> {
+): Promise<SkillsInitSummary> {
+	const emptySummary: SkillsInitSummary = { installed: [], updated: [], upToDate: [], failed: [] }
 	const bundledSkillsPath = getBundledSkillsPath(context)
 
 	// Check if bundled skills exist
@@ -273,7 +294,7 @@ export async function installGitHubSkills(
 
 	if (!bundledExists) {
 		logger.info("[BuiltinSkills] No bundled skills found, skipping")
-		return
+		return emptySummary
 	}
 
 	const extensionVersion = getExtensionVersion(context)
@@ -283,11 +304,61 @@ export async function installGitHubSkills(
 
 	// Install all skills (copy from bundled to user directory)
 	const results = await Promise.all(
-		BUILTIN_SKILLS.map((config) => installBuiltinSkill(config, bundledSkillsPath, preferredLocale)),
+		BUILTIN_SKILLS.map(async (config) => {
+			const result = await initBuiltinSkill(config, bundledSkillsPath, preferredLocale)
+			return { name: config.name, result }
+		}),
+	)
+
+	// Aggregate results
+	const summary: SkillsInitSummary = { installed: [], updated: [], upToDate: [], failed: [] }
+	for (const { name, result } of results) {
+		switch (result) {
+			case "installed":
+				summary.installed.push(name)
+				break
+			case "updated":
+				summary.updated.push(name)
+				break
+			case "up-to-date":
+				summary.upToDate.push(name)
+				break
+			case "failed":
+				summary.failed.push(name)
+				break
+		}
+	}
+
+	logger.info(
+		`[BuiltinSkills] Installation complete: ${summary.installed.length} installed, ${summary.updated.length} updated, ${summary.upToDate.length} up-to-date, ${summary.failed.length} failed`,
 	)
 
-	const successCount = results.filter((r) => r).length
-	logger.info(`[BuiltinSkills] Installation complete: ${successCount}/${BUILTIN_SKILLS.length} skills`)
+	return summary
+}
+
+/**
+ * Show a VS Code notification for skills that were installed or updated.
+ * Only shows when there are actual changes (not when all skills are already up-to-date).
+ */
+export function showSkillsInitNotification(summary: SkillsInitSummary): void {
+	const installedOrUpdated = [...summary.installed, ...summary.updated]
+	if (installedOrUpdated.length === 0) return
+
+	const skillsList = installedOrUpdated.join(", ")
+	const installPath = getGlobalCostrictDirectory()
+
+	if (summary.installed.length > 0 && summary.updated.length === 0) {
+		vscode.window.showInformationMessage(t("common:builtinSkills.init", { skills: skillsList, path: installPath }))
+	} else if (summary.updated.length > 0 && summary.installed.length === 0) {
+		vscode.window.showInformationMessage(
+			t("common:builtinSkills.updated", { skills: skillsList, path: installPath }),
+		)
+	} else {
+		// Mixed: some installed, some updated
+		vscode.window.showInformationMessage(
+			t("common:builtinSkills.updated", { skills: skillsList, path: installPath }),
+		)
+	}
 }
 
 /**
diff --git a/src/tsconfig.json b/src/tsconfig.json
@@ -1,6 +1,5 @@
 {
 	"compilerOptions": {
-		"ignoreDeprecations": "6.0",
 		"baseUrl": ".",
 		"paths": {
 			"@roo-code/logger": ["../packages/logger/src/index.ts"]
diff --git a/webview-ui/src/components/chat/ChatView.tsx b/webview-ui/src/components/chat/ChatView.tsx
@@ -1492,7 +1492,7 @@ const ChatViewComponent: React.ForwardRefRenderFunction<ChatViewRef, ChatViewPro
 
 	useEffect(() => {
 		checkpointJumpCursorRef.current = null
-	}, [task?.ts, checkpointIndices])
+	}, [task?.ts, checkpointIndices.length])
 
 	// Scroll lifecycle is managed by a dedicated hook to keep ChatView focused
 	// on message handling and UI orchestration.
diff --git a/webview-ui/src/components/chat/__tests__/ChatView.scroll-debug-repro.spec.tsx b/webview-ui/src/components/chat/__tests__/ChatView.scroll-debug-repro.spec.tsx
@@ -598,7 +598,6 @@ describe("ChatView scroll behavior regression coverage", () => {
 		})
 		expect(harness.scrollToIndexArgs.at(-1)).toMatchObject({ index: 0, align: "center", behavior: "smooth" })
 
-		// Once at the oldest checkpoint, additional clicks keep targeting it.
 		await act(async () => {
 			;(checkpointButton as HTMLButtonElement).click()
 		})

Original file line number	Diff line number	Diff line change
`@@ -951,11 +951,7 @@ export class CostrictAiHandler extends BaseProvider implements SingleCompletionH`
`951`	`951`	`if (info.id !== id) {`
`952`	`952`	`info.id = id`
`953`	`953`	`}`
`954`		`- const _mid = id.toLowerCase()`
`955`		`- if (`
`956`		`- (_mid?.includes("auto") \|\| _mid?.includes("kimi") \|\| _mid?.includes("minimax") \|\| _mid?.includes("glm") \|\| _mid?.includes("deepseek-v4") \|\| _mid?.includes("qwen-3")) &&`
`957`		`- info.preserveReasoning == null`
`958`		`- ) {`
	`954`	`+ if (info.preserveReasoning == null) {`
`959`	`955`	`info.preserveReasoning = true`
`960`	`956`	`}`
`961`	`957`	`return { id, info, ...params }`