fix ci

Author: alphabetc1

README.md

@@ -8,7 +8,7 @@ It provides worker registration, load balancing, health checking, refit weights
 
 ## Table of Contents
 
-- [Overview](#Overview)
+- [Overview](#overview)
 - [Installation](#installation)
 - [Quick Start](#quick-start)
   - [Start diffusion workers](#start-diffusion-workers)
@@ -18,7 +18,7 @@ It provides worker registration, load balancing, health checking, refit weights
   - [Videos Result Query](#videos-result-query)
   - [Model Discovery and Health Checks](#model-discovery-and-health-checks)
   - [Worker Management APIs](#worker-management-apis)
-  - [Optional (business-dependent)](#optional-business-dependent)
+  - [RL Related API](#rl-related-api)
 - [Acknowledgment](#acknowledgment)
 
 ---
@@ -209,7 +209,7 @@ curl -X POST http://localhost:30081/v1/videos \
     -d '{"model": "Qwen/Qwen-Image", "prompt": "a flowing river"}'
 
 # Poll a specific video job by video_id
-curl http://localhost:30081/v1/videos/<video_id>
+curl http://localhost:30081/v1/videos/{video_id}
 
 
 curl -X POST http://localhost:30081/update_weights_from_disk \
@@ -263,11 +263,11 @@ Video query routing is stable by `video_id`: router caches `video_id -> worker`
 - `is_dead` (boolean): quarantine (`true`) or recover (`false`) this worker.
 - `refresh_video_support` (boolean): re-probe worker `/v1/models` capability.
 
-### Optional (business-dependent)
+### RL Related API
 
 | Method | Path | Description |
 |---|---|---|
-| `POST` | `/update_weights_from_disk` | Reload weights from disk (ops/admin use) |
+| `POST` | `/update_weights_from_disk` | Reload weights from disk on all healthy workers |
 
 ---
 

pyproject.toml

@@ -41,3 +41,4 @@ where = ["src"]
 
 [tool.pytest.ini_options]
 testpaths = ["tests/unit"]
+pythonpath = ["src"]

src/sglang_diffusion_routing/router/diffusion_router.py

@@ -61,9 +61,11 @@ def __init__(self, args, verbose: bool = False):
     def _setup_routes(self) -> None:
         self.app.post("/workers")(self.create_worker)
         self.app.get("/workers")(self.get_workers)
-        self.app.get("/workers/{worker_id}")(self.get_worker)
-        self.app.put("/workers/{worker_id}")(self.update_worker)
-        self.app.delete("/workers/{worker_id}")(self.delete_worker)
+        # worker_id is a URL-encoded worker URL; decoded value can contain "/".
+        # Use :path converter so encoded slashes still resolve to this route.
+        self.app.get("/workers/{worker_id:path}")(self.get_worker)
+        self.app.put("/workers/{worker_id:path}")(self.update_worker)
+        self.app.delete("/workers/{worker_id:path}")(self.delete_worker)
         self.app.post("/v1/images/generations")(self.generate)
         self.app.post("/v1/videos")(self.generate_video)
         self.app.get("/v1/videos")(self.list_or_poll_videos)
@@ -670,6 +672,15 @@ async def health(self, request: Request):
 
     async def update_weights_from_disk(self, request: Request):
         """Broadcast weight reload to all healthy workers."""
+        healthy_workers = [
+            url for url in self.worker_request_counts if url not in self.dead_workers
+        ]
+        if not healthy_workers:
+            return JSONResponse(
+                status_code=503,
+                content={"error": "No healthy workers available in the pool"},
+            )
+
         body = await request.body()
         headers = dict(request.headers)
         results = await self._broadcast_to_workers(

tests/unit/test_router_endpoints.py

@@ -327,3 +327,14 @@ async def fake_broadcast(path: str, body: bytes, headers: dict):
         response = client.post("/update_weights_from_disk", json={"model_path": "abc"})
         assert response.status_code == 200
         assert response.json()["results"][0]["status_code"] == 200
+
+
+def test_update_weights_from_disk_returns_503_without_healthy_workers():
+    router = DiffusionRouter(make_router_args())
+    router.register_worker("http://localhost:10090")
+    router.dead_workers.add("http://localhost:10090")
+
+    with TestClient(router.app) as client:
+        response = client.post("/update_weights_from_disk", json={"model_path": "abc"})
+        assert response.status_code == 503
+        assert "No healthy workers available" in response.json()["error"]