Fix ElemSegment CheckType in shared validator

Author: zherczeg

src/shared-validator.cc

@@ -282,7 +282,7 @@ Result SharedValidator::OnElemSegmentElemType(const Location& loc,
   if (elem.is_active) {
     // Check that the type of the elem segment matches the table in which
     // it is active.
-    result |= CheckType(loc, elem.table_type, elem_type, "elem segment");
+    result |= CheckType(loc, elem_type, elem.table_type, "elem segment");
   }
   elem.element = elem_type;
   return result;

test/spec/elem.txt

@@ -71,10 +71,10 @@ out/test/spec/elem.wast:527: assert_invalid passed:
   0000023: error: OnCallExpr callback failed
 out/test/spec/elem.wast:585: assert_trap passed: uninitialized table element
 out/test/spec/elem.wast:618: assert_invalid passed:
-  out/test/spec/elem/elem.61.wasm:000001f: error: type mismatch at elem segment. got externref, expected funcref
+  out/test/spec/elem/elem.61.wasm:000001f: error: type mismatch at elem segment. got funcref, expected externref
   000001f: error: OnElemSegmentElemType callback failed
 out/test/spec/elem.wast:623: assert_invalid passed:
-  out/test/spec/elem/elem.62.wasm:0000017: error: type mismatch at elem segment. got funcref, expected externref
+  out/test/spec/elem/elem.62.wasm:0000017: error: type mismatch at elem segment. got externref, expected funcref
   0000017: error: OnElemSegmentElemType callback failed
 out/test/spec/elem.wast:628: assert_invalid passed:
   out/test/spec/elem/elem.63.wasm:0000032: error: type mismatch at table.init. got funcref, expected externref

test/spec/extended-const/elem.txt

@@ -75,10 +75,10 @@ out/test/spec/extended-const/elem.wast:536: assert_invalid passed:
   0000023: error: OnCallExpr callback failed
 out/test/spec/extended-const/elem.wast:594: assert_trap passed: uninitialized table element
 out/test/spec/extended-const/elem.wast:627: assert_invalid passed:
-  out/test/spec/extended-const/elem/elem.62.wasm:000001f: error: type mismatch at elem segment. got externref, expected funcref
+  out/test/spec/extended-const/elem/elem.62.wasm:000001f: error: type mismatch at elem segment. got funcref, expected externref
   000001f: error: OnElemSegmentElemType callback failed
 out/test/spec/extended-const/elem.wast:632: assert_invalid passed:
-  out/test/spec/extended-const/elem/elem.63.wasm:0000017: error: type mismatch at elem segment. got funcref, expected externref
+  out/test/spec/extended-const/elem/elem.63.wasm:0000017: error: type mismatch at elem segment. got externref, expected funcref
   0000017: error: OnElemSegmentElemType callback failed
 out/test/spec/extended-const/elem.wast:637: assert_invalid passed:
   out/test/spec/extended-const/elem/elem.64.wasm:0000032: error: type mismatch at table.init. got funcref, expected externref