TAB indent of list item stopped working

[derekwsgray]

Describe the bug
I upgraded Atom from 1.38.something to 1.40.1. After upgrading, the TAB key is just adding the spaces, but not indenting the bullet.

To Reproduce
Steps to reproduce the behavior:

1. Open a markdown file and start a list using a dash -, a space then type.
2. Hit ENTER to go to the next line. A dash is correctly inserted for the next list item and the cursor is to the right of that by 1 space.
3. hit TAB to indent the list item.
4. 4 spaces are inserted after the dash, the dash has not moved over.

Expected behavior
I expected the list item to indent as a whole, to the right, dash and all. For the past year I've used this on a daily basis - I could click in the middle of the line of a list item and hit tab and it would indent the whole thing. Now it's just inserting spaces with no recognition.

Screenshots

Additional context
I tried uninstalling and re-installing the plugin but it made no difference.

[aviatesk]

I encountered this issue too, after updating this package to the latest version (v2.11.8).
I confirmed v2.11.7 doesn't produce this issue, thus I suspect there is some regression in v2.11.8.

/cc @zhuochun hope you find it worth to be fixed ;)

[zhuochun]

There was one behavior change in version v2.11.8, where Tab indent only kick in when the indent will create a valid sublist.

From my own test on Atom v1.40.1 and Markdown Writer v2.11.8, on a blank Markdown file (_ is the cursor):

- Test
- _

Tab will indent one level:

- Test
  * _

Tab again will insert 2 spaces.

@derekwsgray @aviatesk maybe you can provide the full content of the Markdown file? or try the example I gave to spot the difference in expected behavior?

[aviatesk]

@zhuochun
Thanks for getting me back !

I found markdown-write: indent-list-line doesn't work when an open editor's getTabLength() !== 2.

(On Atom v1.40.1, and markdown-writer@2.11.8)

[zhuochun]

@aviatesk Thanks. Now I can reproduce the behavior.

The quick immediate fix is change Package > Language Markdown > Tab Length to 2 first (this only applies to Markdown files).

I will need to revise whether to not use getTabLength.

[aviatesk]

@zhuochun are you willing to fix this ? If you're not, I may want to help you out if given some pointers.

[derekwsgray]

Confused why this would be tagged enhancement if it is a feature regression?

Also, I don't have the Package > Language Markdown even installed.

".source.md":
  editor:
    tabLength: 2

Had no effect either.

Installing language-markdown and changing the tab length setting resulted in even worse behaviour for me, adding even more tabs on top of the indent:

- This is a test of the lists.
    - This is a second items
    -       fjdkla
    -             fjkdlsa;
    -                   fdjkls;a 

[derekwsgray]

Ok, the workaround is to install language-markdown and just disable the markdown-writer keybindings, then I get the normal 4-space tab that I had originally and the correct list tabbing behaviour.

[aviatesk]

Obviously you can downgrade this package via apm install markdown-writer@2.11.7

or if you want to stick with language-gfm just set

".gfm.source":
  editor:
    tabLength: 2

[aviatesk]

Ok, the workaround is to install language-markdown and just disable the markdown-writer keybindings, then I get the normal 4-space tab that I had originally and the correct list tabbing behaviour.

This workaround just uses langauge-markdown's markdown: indent-list-item and then you can't use changing list prefix and the other fancy feature that markdown-writer provides.

[derekwsgray]

True, my workaround is heavy-handed. I'm a simple guy though and don't use those features :)

[derekwsgray]

(Downgrading the plugin means you have a blue "1 update" notification in the bottom right corner all the time - unless someone knows a plugin that then allows us to ignore updates for particular plugins...)

[aviatesk]

dirty solution:

~/.atom/styles.less

atom-workspace {
  status-bar {
    .package-updates-status-view {
      display: none;
    }
  }
}

[zhuochun]

The latest change on latest Markdown Writer v2.11.9 should address the issue.