Send three resets when connecting, not just one (#689)

* Send three resets when connecting, not just one

* Fix unit test

Author: puddly

bellows/ash.py

@@ -715,4 +715,8 @@ async def send_data(self, data: bytes) -> None:
         )
 
     def send_reset(self) -> None:
+        # Some adapters seem to send a NAK immediately but still process the reset frame
+        # if one eventually makes it through
+        self._write_frame(RstFrame(), prefix=(Reserved.CANCEL,))
+        self._write_frame(RstFrame(), prefix=(Reserved.CANCEL,))
         self._write_frame(RstFrame(), prefix=(Reserved.CANCEL,))

tests/test_ash.py

@@ -438,7 +438,10 @@ async def test_ash_protocol_startup(caplog):
 
     assert ezsp.reset_received.mock_calls == [call(t.NcpResetCode.RESET_SOFTWARE)]
     assert protocol._write_frame.mock_calls == [
-        call(ash.RstFrame(), prefix=(ash.Reserved.CANCEL,))
+        # We send three
+        call(ash.RstFrame(), prefix=(ash.Reserved.CANCEL,)),
+        call(ash.RstFrame(), prefix=(ash.Reserved.CANCEL,)),
+        call(ash.RstFrame(), prefix=(ash.Reserved.CANCEL,)),
     ]
 
     protocol._write_frame.reset_mock()