You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As I'm porting my Sinopé quirks to quirks V2 I've noticed that some attributes are already included in [zha]zigpy/zha/tree/dev/zha/application/platforms/select.py
Like SinopeLightLedColors, SinopeLightLEDOffColorSelect, SinopeLightLEDOnColorSelect etc. Those select should normally goes in the sinope light quirks V2.
Do we need to remove them from select.py and include them in light.py quirks V2 ? or if I add them to light.py in quirks V2 they will overwrite what is in the select.py
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
As I'm porting my Sinopé quirks to quirks V2 I've noticed that some attributes are already included in [zha]zigpy/zha/tree/dev/zha/application/platforms/select.py
Like SinopeLightLedColors, SinopeLightLEDOffColorSelect, SinopeLightLEDOnColorSelect etc. Those select should normally goes in the sinope light quirks V2.
Do we need to remove them from select.py and include them in light.py quirks V2 ? or if I add them to light.py in quirks V2 they will overwrite what is in the select.py
Beta Was this translation helpful? Give feedback.
All reactions