Revert 'open' tilt state precedence for cover devices supporting lift & tilt (#428)

Revert change that reports a cover state of open if either lift or tilt axes are open

This is an interim change to address issues with some cover 'relay' type devices which falsely report support for both lift and tilt. In reality these only support one axes or the other, with users using yaml overrides to restrict functionality in HA.

Devices that genuinely support both movement axes will behave the same as they did prior to #376

A subsequent PR will be made to allow users to override the covering type in a way that allows the entity handler to be aware of the configuration, calculating the state accordingly.

Author: jeverley

tests/test_cover.py

@@ -258,14 +258,13 @@ async def test_cover(
         | CoverEntityFeature.SET_TILT_POSITION
     )
 
-    # set lift to 100% (closed) and test that the state has changed from unavailable to open
-    # the starting open tilt position overrides the closed lift state
+    # set lift to 100% (closed) and test that the state has changed from unavailable to closed
     await send_attributes_report(
         zha_gateway, cluster, {WCAttrs.current_position_lift_percentage.id: 100}
     )
-    assert entity.state["state"] == CoverState.OPEN
+    assert entity.state["state"] == CoverState.CLOSED
 
-    # test that the state closes after tilting to 100% (closed)
+    # test that the state remains after tilting to 100% (closed)
     await send_attributes_report(
         zha_gateway, cluster, {WCAttrs.current_position_tilt_percentage.id: 100}
     )
@@ -325,7 +324,7 @@ async def test_cover(
         await send_attributes_report(
             zha_gateway, cluster, {WCAttrs.current_position_tilt_percentage.id: 0}
         )
-        assert entity.state["state"] == CoverState.OPEN
+        assert entity.state["state"] == CoverState.CLOSED
 
         await entity.async_close_cover_tilt()
         await zha_gateway.async_block_till_done()

zha/application/platforms/cover/__init__.py

@@ -420,9 +420,8 @@ def _determine_cover_state(
             self.maybe_emit_state_changed_event()
             return
 
-        # An open or moving tilt state overrides a static lift state
+        # A moving tilt state overrides a static lift state
         if self._tilt_state in (
-            CoverState.OPEN,
             CoverState.OPENING,
             CoverState.CLOSING,
         ) and self._lift_state in (CoverState.CLOSED, CoverState.OPEN):