Skip to content

Make things for inspecting and manipulating PKZip structures public #180

Open
@daniel-abramov

Description

@daniel-abramov

I wanted to ask your opinion regarding one question. What do you think about making some private structures and functions public? In particularly I mean the structure which represents the parsed local file header and the functions which allow you to write local file header and central directory headers based on the parsed structure.

I find them very useful. Recently I had to work with the internals of the ZIP format a lot, but I did not want to use the whole functionality of compressing / decompressing, just wanted to access the internal structures of ZIP format, change them and write them again in a new file. Here zip-rs was very useful, but I had to make some things public.

Basically it's not a lot of work to do, and the required changes are already pushed to my fork: https://github.com/snapview/zip-rs/tree/make-some-apis-public

The only thing which may make sense is making them feature-guarded, so that the users who just want to use the "regular zip functionality" / who are not familiar with the structure of PKZip file don't get confused by seeing these additional functions and structures.

What do you think?

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions