Favour promoted property annotation nullable over native (#1785)

Author: DerManoMann

src/Analysers/AttributeAnnotationFactory.php

@@ -85,7 +85,9 @@ public function build(\Reflector $reflector, Context $context): array
                                 if (Generator::isDefault($instance->type)) {
                                     $instance->type = $type;
                                 }
-                                $instance->nullable = $nullable ?: Generator::UNDEFINED;
+                                if (Generator::isDefault($instance->nullable)) {
+                                    $instance->nullable = $nullable ?: Generator::UNDEFINED;
+                                }
 
                                 if ($rp->isPromoted()) {
                                     // ensure each property has its own context

tests/Fixtures/Scratch/Nullable.php

@@ -52,6 +52,12 @@ class Nullable
 
     #[OAT\Property(enum: ['Choice1', 'Choice2', null], example: 'Choice1', nullable: true)]
     public ?string $choice = null;
+
+    public function __construct(
+        #[OAT\Property(nullable: false)]
+        public ?string $title,
+    ) {
+    }
 }
 
 #[OAT\Get(

tests/Fixtures/Scratch/Nullable3.0.0.yaml

@@ -21,6 +21,9 @@ components:
       example: '2023-08-02T07:06:46+03:30'
     Nullable:
       properties:
+        title:
+          type: string
+          nullable: false
         firstname:
           type: string
           nullable: true

tests/Fixtures/Scratch/Nullable3.1.0.yaml

@@ -21,6 +21,8 @@ components:
       example: '2023-08-02T07:06:46+03:30'
     Nullable:
       properties:
+        title:
+          type: string
         firstname:
           type:
             - string