-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathhandle_updatetodo_test.go
More file actions
387 lines (316 loc) · 14.1 KB
/
handle_updatetodo_test.go
File metadata and controls
387 lines (316 loc) · 14.1 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
package main
import (
"crypto/sha256"
"errors"
"fmt"
"net/http"
"net/http/httptest"
"strings"
"testing"
"github.com/gin-gonic/gin"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/mock"
"github.com/ziyixi/todofy/testutils/mocks"
"github.com/ziyixi/todofy/utils"
pb "github.com/ziyixi/protos/go/todofy"
)
// helper to set up a gin test context with mock clients injected.
func setupUpdateTodoTest(
mockDB *mocks.MockDataBaseServiceClient,
mockLLM *mocks.MockLLMSummaryServiceClient,
mockTodo *mocks.MockTodoServiceClient,
) (*httptest.ResponseRecorder, *gin.Engine) {
gin.SetMode(gin.TestMode)
clients := mocks.NewMockGRPCClients()
clients.SetClient("database", mockDB)
if mockLLM != nil {
clients.SetClient("llm", mockLLM)
}
if mockTodo != nil {
clients.SetClient("todo", mockTodo)
}
router := gin.New()
router.Use(func(c *gin.Context) {
c.Set(utils.KeyGRPCClients, clients)
c.Next()
})
router.POST("/api/updatetodo", HandleUpdateTodo)
w := httptest.NewRecorder()
return w, router
}
// validEmailJSON returns a CloudMailin-format JSON body with the given fields.
func validEmailJSON(from, to, subject, content string) string {
return fmt.Sprintf(`{
"headers": {"from": %q, "to": %q, "date": "2024-01-01", "subject": %q},
"html": %q,
"plain": %q
}`, from, to, subject, "<p>"+content+"</p>", content)
}
// computeExpectedHash returns the SHA-256 hex hash of DefaultPromptToSummaryEmail + content,
// matching the logic in HandleUpdateTodo.
func computeExpectedHash(content string) string {
hashInput := utils.DefaultPromptToSummaryEmail + content
return fmt.Sprintf("%x", sha256.Sum256([]byte(hashInput)))
}
func TestHandleUpdateTodo_SuccessCacheMiss(t *testing.T) {
mockDB := new(mocks.MockDataBaseServiceClient)
mockLLM := new(mocks.MockLLMSummaryServiceClient)
mockTodo := new(mocks.MockTodoServiceClient)
// CheckExist returns nil entry (cache miss)
mockDB.On("CheckExist", mock.Anything, mock.Anything, mock.Anything).
Return(&pb.CheckExistResponse{Entry: nil}, nil)
// LLM summarizes
mockLLM.On("Summarize", mock.Anything, mock.Anything, mock.Anything).
Return(&pb.LLMSummaryResponse{
Summary: "This is a test summary",
Model: pb.Model_MODEL_GEMINI_2_5_FLASH,
}, nil)
// Todo created
mockTodo.On("PopulateTodo", mock.Anything, mock.Anything, mock.Anything).
Return(&pb.TodoResponse{}, nil)
// DB write succeeds
mockDB.On("Write", mock.Anything, mock.Anything, mock.Anything).
Return(&pb.WriteResponse{}, nil)
w, router := setupUpdateTodoTest(mockDB, mockLLM, mockTodo)
body := validEmailJSON("sender@example.com", "me@test.com", "Test Subject", "Test content")
req, _ := http.NewRequest(http.MethodPost, "/api/updatetodo", strings.NewReader(body))
req.Header.Set("Content-Type", "application/json")
router.ServeHTTP(w, req)
assert.Equal(t, http.StatusOK, w.Code)
assert.Contains(t, w.Body.String(), "todo created successfully")
mockDB.AssertExpectations(t)
mockLLM.AssertExpectations(t)
mockTodo.AssertExpectations(t)
}
func TestHandleUpdateTodo_SuccessCacheHit(t *testing.T) {
mockDB := new(mocks.MockDataBaseServiceClient)
mockTodo := new(mocks.MockTodoServiceClient)
// CheckExist returns a cached entry (cache hit) — LLM should NOT be called
mockDB.On("CheckExist", mock.Anything, mock.Anything, mock.Anything).
Return(&pb.CheckExistResponse{
Entry: &pb.DataBaseSchema{
Summary: "Cached summary from DB",
Model: pb.Model_MODEL_GEMINI_2_5_FLASH,
ModelFamily: pb.ModelFamily_MODEL_FAMILY_GEMINI,
Prompt: utils.DefaultPromptToSummaryEmail,
Text: "Test content",
},
}, nil)
// Todo created
mockTodo.On("PopulateTodo", mock.Anything, mock.Anything, mock.Anything).
Return(&pb.TodoResponse{}, nil)
// DB write succeeds
mockDB.On("Write", mock.Anything, mock.Anything, mock.Anything).
Return(&pb.WriteResponse{}, nil)
// No LLM mock set — if handler calls LLM, it will panic (no "llm" client)
w, router := setupUpdateTodoTest(mockDB, nil, mockTodo)
body := validEmailJSON("sender@example.com", "me@test.com", "Test Subject", "Test content")
req, _ := http.NewRequest(http.MethodPost, "/api/updatetodo", strings.NewReader(body))
req.Header.Set("Content-Type", "application/json")
router.ServeHTTP(w, req)
assert.Equal(t, http.StatusOK, w.Code)
assert.Contains(t, w.Body.String(), "todo created successfully")
mockDB.AssertExpectations(t)
mockTodo.AssertExpectations(t)
}
func TestHandleUpdateTodo_InvalidBody(t *testing.T) {
mockDB := new(mocks.MockDataBaseServiceClient)
w, router := setupUpdateTodoTest(mockDB, nil, nil)
// Send a non-JSON body that will parse to empty fields via gjson
body := "this is not valid json at all"
req, _ := http.NewRequest(http.MethodPost, "/api/updatetodo", strings.NewReader(body))
req.Header.Set("Content-Type", "application/json")
router.ServeHTTP(w, req)
assert.Equal(t, http.StatusBadRequest, w.Code)
assert.Contains(t, w.Body.String(), "from/to/subject/content is empty")
}
func TestHandleUpdateTodo_EmptyFields(t *testing.T) {
mockDB := new(mocks.MockDataBaseServiceClient)
w, router := setupUpdateTodoTest(mockDB, nil, nil)
// Provide JSON with empty from and to
body := validEmailJSON("", "", "Subject", "Content")
req, _ := http.NewRequest(http.MethodPost, "/api/updatetodo", strings.NewReader(body))
req.Header.Set("Content-Type", "application/json")
router.ServeHTTP(w, req)
assert.Equal(t, http.StatusBadRequest, w.Code)
assert.Contains(t, w.Body.String(), "from/to/subject/content is empty")
}
func TestHandleUpdateTodo_SystemEmailPrefix(t *testing.T) {
mockDB := new(mocks.MockDataBaseServiceClient)
w, router := setupUpdateTodoTest(mockDB, nil, nil)
subject := utils.SystemAutomaticallyEmailPrefix + " daily summary"
body := validEmailJSON("sender@example.com", "me@test.com", subject, "Some content")
req, _ := http.NewRequest(http.MethodPost, "/api/updatetodo", strings.NewReader(body))
req.Header.Set("Content-Type", "application/json")
router.ServeHTTP(w, req)
assert.Equal(t, http.StatusOK, w.Code)
assert.Contains(t, w.Body.String(), "system automatically email")
}
func TestHandleUpdateTodo_CheckExistError(t *testing.T) {
mockDB := new(mocks.MockDataBaseServiceClient)
mockLLM := new(mocks.MockLLMSummaryServiceClient)
mockTodo := new(mocks.MockTodoServiceClient)
// CheckExist fails — handler should log warning and proceed with LLM
mockDB.On("CheckExist", mock.Anything, mock.Anything, mock.Anything).
Return(nil, errors.New("db connection refused"))
// LLM summarizes (handler falls through to LLM path)
mockLLM.On("Summarize", mock.Anything, mock.Anything, mock.Anything).
Return(&pb.LLMSummaryResponse{
Summary: "Summary after CheckExist failure",
Model: pb.Model_MODEL_GEMINI_2_5_FLASH,
}, nil)
mockTodo.On("PopulateTodo", mock.Anything, mock.Anything, mock.Anything).
Return(&pb.TodoResponse{}, nil)
mockDB.On("Write", mock.Anything, mock.Anything, mock.Anything).
Return(&pb.WriteResponse{}, nil)
w, router := setupUpdateTodoTest(mockDB, mockLLM, mockTodo)
body := validEmailJSON("sender@example.com", "me@test.com", "Test Subject", "Test content")
req, _ := http.NewRequest(http.MethodPost, "/api/updatetodo", strings.NewReader(body))
req.Header.Set("Content-Type", "application/json")
router.ServeHTTP(w, req)
assert.Equal(t, http.StatusOK, w.Code)
assert.Contains(t, w.Body.String(), "todo created successfully")
mockLLM.AssertExpectations(t)
mockDB.AssertExpectations(t)
}
func TestHandleUpdateTodo_LLMError(t *testing.T) {
mockDB := new(mocks.MockDataBaseServiceClient)
mockLLM := new(mocks.MockLLMSummaryServiceClient)
mockDB.On("CheckExist", mock.Anything, mock.Anything, mock.Anything).
Return(&pb.CheckExistResponse{Entry: nil}, nil)
mockLLM.On("Summarize", mock.Anything, mock.Anything, mock.Anything).
Return(nil, errors.New("llm quota exceeded"))
w, router := setupUpdateTodoTest(mockDB, mockLLM, nil)
body := validEmailJSON("sender@example.com", "me@test.com", "Test Subject", "Test content")
req, _ := http.NewRequest(http.MethodPost, "/api/updatetodo", strings.NewReader(body))
req.Header.Set("Content-Type", "application/json")
router.ServeHTTP(w, req)
assert.Equal(t, http.StatusInternalServerError, w.Code)
assert.Contains(t, w.Body.String(), "llm quota exceeded")
mockDB.AssertExpectations(t)
mockLLM.AssertExpectations(t)
}
func TestHandleUpdateTodo_TodoError(t *testing.T) {
mockDB := new(mocks.MockDataBaseServiceClient)
mockLLM := new(mocks.MockLLMSummaryServiceClient)
mockTodo := new(mocks.MockTodoServiceClient)
mockDB.On("CheckExist", mock.Anything, mock.Anything, mock.Anything).
Return(&pb.CheckExistResponse{Entry: nil}, nil)
mockLLM.On("Summarize", mock.Anything, mock.Anything, mock.Anything).
Return(&pb.LLMSummaryResponse{
Summary: "A summary",
Model: pb.Model_MODEL_GEMINI_2_5_FLASH,
}, nil)
mockTodo.On("PopulateTodo", mock.Anything, mock.Anything, mock.Anything).
Return(nil, errors.New("todoist API down"))
w, router := setupUpdateTodoTest(mockDB, mockLLM, mockTodo)
body := validEmailJSON("sender@example.com", "me@test.com", "Test Subject", "Test content")
req, _ := http.NewRequest(http.MethodPost, "/api/updatetodo", strings.NewReader(body))
req.Header.Set("Content-Type", "application/json")
router.ServeHTTP(w, req)
assert.Equal(t, http.StatusInternalServerError, w.Code)
assert.Contains(t, w.Body.String(), "todoist API down")
mockDB.AssertExpectations(t)
mockLLM.AssertExpectations(t)
mockTodo.AssertExpectations(t)
}
func TestHandleUpdateTodo_DBWriteError(t *testing.T) {
mockDB := new(mocks.MockDataBaseServiceClient)
mockLLM := new(mocks.MockLLMSummaryServiceClient)
mockTodo := new(mocks.MockTodoServiceClient)
mockDB.On("CheckExist", mock.Anything, mock.Anything, mock.Anything).
Return(&pb.CheckExistResponse{Entry: nil}, nil)
mockLLM.On("Summarize", mock.Anything, mock.Anything, mock.Anything).
Return(&pb.LLMSummaryResponse{
Summary: "A summary",
Model: pb.Model_MODEL_GEMINI_2_5_FLASH,
}, nil)
mockTodo.On("PopulateTodo", mock.Anything, mock.Anything, mock.Anything).
Return(&pb.TodoResponse{}, nil)
mockDB.On("Write", mock.Anything, mock.Anything, mock.Anything).
Return(nil, errors.New("disk full"))
w, router := setupUpdateTodoTest(mockDB, mockLLM, mockTodo)
body := validEmailJSON("sender@example.com", "me@test.com", "Test Subject", "Test content")
req, _ := http.NewRequest(http.MethodPost, "/api/updatetodo", strings.NewReader(body))
req.Header.Set("Content-Type", "application/json")
router.ServeHTTP(w, req)
assert.Equal(t, http.StatusInternalServerError, w.Code)
assert.Contains(t, w.Body.String(), "disk full")
mockDB.AssertExpectations(t)
mockLLM.AssertExpectations(t)
mockTodo.AssertExpectations(t)
}
func TestHandleUpdateTodo_TagRemoval(t *testing.T) {
mockDB := new(mocks.MockDataBaseServiceClient)
mockLLM := new(mocks.MockLLMSummaryServiceClient)
mockTodo := new(mocks.MockTodoServiceClient)
mockDB.On("CheckExist", mock.Anything, mock.Anything, mock.Anything).
Return(&pb.CheckExistResponse{Entry: nil}, nil)
// Return a summary containing #tags that should be removed
summaryWithTags := "Important task #urgent needs attention #review now"
mockLLM.On("Summarize", mock.Anything, mock.Anything, mock.Anything).
Return(&pb.LLMSummaryResponse{
Summary: summaryWithTags,
Model: pb.Model_MODEL_GEMINI_2_5_FLASH,
}, nil)
// Capture the todo request to verify tags were removed from the description.
// Note: html/template escapes < and > so <removed tag> becomes <removed tag>
mockTodo.On("PopulateTodo", mock.Anything,
mock.MatchedBy(func(req *pb.TodoRequest) bool {
return (strings.Contains(req.Body, "<removed tag>") || strings.Contains(req.Body, "<removed tag>")) &&
!strings.Contains(req.Body, "#urgent") &&
!strings.Contains(req.Body, "#review")
}), mock.Anything).
Return(&pb.TodoResponse{}, nil)
mockDB.On("Write", mock.Anything, mock.Anything, mock.Anything).
Return(&pb.WriteResponse{}, nil)
w, router := setupUpdateTodoTest(mockDB, mockLLM, mockTodo)
body := validEmailJSON("sender@example.com", "me@test.com", "Test Subject", "Test content")
req, _ := http.NewRequest(http.MethodPost, "/api/updatetodo", strings.NewReader(body))
req.Header.Set("Content-Type", "application/json")
router.ServeHTTP(w, req)
assert.Equal(t, http.StatusOK, w.Code)
mockTodo.AssertExpectations(t)
}
func TestHandleUpdateTodo_HashConsistency(t *testing.T) {
mockDB := new(mocks.MockDataBaseServiceClient)
mockLLM := new(mocks.MockLLMSummaryServiceClient)
mockTodo := new(mocks.MockTodoServiceClient)
emailContent := "Test content for hash consistency"
// The handler parses HTML via html-to-markdown; for simple <p>text</p> the
// converted markdown is the plain text itself. Compute the expected hash
// using the same content that ParseCloudmailin will produce.
// We use plain text fallback to keep the test deterministic.
emailBody := fmt.Sprintf(`{
"headers": {"from": "sender@example.com", "to": "me@test.com", "date": "2024-01-01", "subject": "Hash Test"},
"plain": %q
}`, emailContent)
// ParseCloudmailin falls back to plain when html is empty
parsed := utils.ParseCloudmailin(emailBody)
expectedHash := computeExpectedHash(parsed.Content)
// Verify CheckExist receives the expected hash
mockDB.On("CheckExist", mock.Anything,
mock.MatchedBy(func(req *pb.CheckExistRequest) bool {
return req.HashId == expectedHash
}), mock.Anything).
Return(&pb.CheckExistResponse{Entry: nil}, nil)
mockLLM.On("Summarize", mock.Anything, mock.Anything, mock.Anything).
Return(&pb.LLMSummaryResponse{
Summary: "Summary",
Model: pb.Model_MODEL_GEMINI_2_5_FLASH,
}, nil)
mockTodo.On("PopulateTodo", mock.Anything, mock.Anything, mock.Anything).
Return(&pb.TodoResponse{}, nil)
// Verify Write receives the same hash
mockDB.On("Write", mock.Anything,
mock.MatchedBy(func(req *pb.WriteRequest) bool {
return req.Schema != nil && req.Schema.HashId == expectedHash
}), mock.Anything).
Return(&pb.WriteResponse{}, nil)
w, router := setupUpdateTodoTest(mockDB, mockLLM, mockTodo)
req, _ := http.NewRequest(http.MethodPost, "/api/updatetodo", strings.NewReader(emailBody))
req.Header.Set("Content-Type", "application/json")
router.ServeHTTP(w, req)
assert.Equal(t, http.StatusOK, w.Code)
mockDB.AssertExpectations(t)
}