feat(agora): migrate to pnpm and improve API type safety (#459)

* chore(agora): migrate frontend to pnpm

* feat(shared): update zod types and sync DTOs

* feat(agora): improve API response handling and type safety

* chore: update dependencies

Author: nicobao

.github/workflows/build-ios-app.yml

@@ -1,44 +1,47 @@
-# name: build-ios-app
-# on:
-#   push:
-#     paths:
-#       - 'services/app/**'
-#       - '.github/workflows/build-ios-app.yml'
-#     branches:
-#       - 'main'
-# jobs:
-#   build:
-#     runs-on: macos-latest
-#     defaults:
-#       run:
-#         working-directory: ./services/app
-#     steps:
-#       - uses: actions/checkout@v4
-#       - uses: actions/setup-node@v4
-#         with:
-#           node-version: 20
-#           cache: 'yarn'
-#           cache-dependency-path: './services/app'
-#       - name: Install dependencies
-#         run: yarn install --production=false --frozen-lockfile
-#       - name: Build Quasar Capacitor app for iOS
-#         run: echo $PWD && yarn build:ci:ios
-#       - name: Fastlane - build & upload to TestFlight
-#         working-directory: './services/app/src-capacitor'
-#         run: bundle exec fastlane beta --verbose
-#         env:
-#           MATCH_PASSWORD: ${{ secrets.MATCH_PASSWORD }}
-#           APP_STORE_CONNECT_API_ISSUER_ID: ${{ secrets.APP_STORE_CONNECT_API_ISSUER_ID }}
-#           APP_STORE_CONNECT_API_KEY_CONTENT: ${{ secrets.APP_STORE_CONNECT_API_KEY_CONTENT }}
-#           APP_STORE_CONNECT_API_KEY_ID: ${{ secrets.APP_STORE_CONNECT_API_KEY_ID }}
-#           GIT_APPLE_KEYS_TOKEN_USER: ${{ secrets.GIT_APPLE_KEYS_TOKEN_USER }}
-#           GIT_APPLE_KEYS_TOKEN_VALUE: ${{ secrets.GIT_APPLE_KEYS_TOKEN_VALUE }}
-#           GIT_APPLE_KEYS_URL: ${{ secrets.GIT_APPLE_KEYS_URL }}
-#           APPLE_ID: ${{ secrets.APPLE_ID }}
-#           APPLE_DEVELOPER_PORTAL_TEAM_ID: ${{ secrets.APPLE_DEVELOPER_PORTAL_TEAM_ID }}
-#           APPLE_APP_STORE_CONNECT_TEAM_ID: ${{ secrets.APPLE_APP_STORE_CONNECT_TEAM_ID }}
-#           APPLE_DIST_PROFILE_NAME: ${{ secrets.APPLE_DIST_PROFILE_NAME }}
-#           APPLE_DIST_PROFILE_UUID: ${{ secrets.APPLE_DIST_PROFILE_UUID }}
-#           APPLE_DIST_CERTIFICATE_NAME: ${{ secrets.APPLE_DIST_CERTIFICATE_NAME }}
-#           TEMP_KEYCHAIN_USER: ${{ secrets.TEMP_KEYCHAIN_USER }}
-#           TEMP_KEYCHAIN_PASSWORD: ${{ secrets.TEMP_KEYCHAIN_PASSWORD }}
+name: build-ios-app
+on:
+  push:
+    paths:
+      - 'services/app/**'
+      - '.github/workflows/build-ios-app.yml'
+    branches:
+      - 'main'
+jobs:
+  build:
+    runs-on: macos-latest
+    defaults:
+      run:
+        working-directory: ./services/app
+    steps:
+      - uses: actions/checkout@v4
+      - uses: pnpm/action-setup@v2
+        with:
+          version: 9
+      - uses: actions/setup-node@v4
+        with:
+          node-version: 20
+          cache: 'pnpm'
+          cache-dependency-path: './services/app/pnpm-lock.yaml'
+      - name: Install dependencies
+        run: pnpm install --frozen-lockfile
+      - name: Build Quasar Capacitor app for iOS
+        run: echo $PWD && pnpm build:ci:ios
+      - name: Fastlane - build & upload to TestFlight
+        working-directory: './services/app/src-capacitor'
+        run: bundle exec fastlane beta --verbose
+        env:
+          MATCH_PASSWORD: ${{ secrets.MATCH_PASSWORD }}
+          APP_STORE_CONNECT_API_ISSUER_ID: ${{ secrets.APP_STORE_CONNECT_API_ISSUER_ID }}
+          APP_STORE_CONNECT_API_KEY_CONTENT: ${{ secrets.APP_STORE_CONNECT_API_KEY_CONTENT }}
+          APP_STORE_CONNECT_API_KEY_ID: ${{ secrets.APP_STORE_CONNECT_API_KEY_ID }}
+          GIT_APPLE_KEYS_TOKEN_USER: ${{ secrets.GIT_APPLE_KEYS_TOKEN_USER }}
+          GIT_APPLE_KEYS_TOKEN_VALUE: ${{ secrets.GIT_APPLE_KEYS_TOKEN_VALUE }}
+          GIT_APPLE_KEYS_URL: ${{ secrets.GIT_APPLE_KEYS_URL }}
+          APPLE_ID: ${{ secrets.APPLE_ID }}
+          APPLE_DEVELOPER_PORTAL_TEAM_ID: ${{ secrets.APPLE_DEVELOPER_PORTAL_TEAM_ID }}
+          APPLE_APP_STORE_CONNECT_TEAM_ID: ${{ secrets.APPLE_APP_STORE_CONNECT_TEAM_ID }}
+          APPLE_DIST_PROFILE_NAME: ${{ secrets.APPLE_DIST_PROFILE_NAME }}
+          APPLE_DIST_PROFILE_UUID: ${{ secrets.APPLE_DIST_PROFILE_UUID }}
+          APPLE_DIST_CERTIFICATE_NAME: ${{ secrets.APPLE_DIST_CERTIFICATE_NAME }}
+          TEMP_KEYCHAIN_USER: ${{ secrets.TEMP_KEYCHAIN_USER }}
+          TEMP_KEYCHAIN_PASSWORD: ${{ secrets.TEMP_KEYCHAIN_PASSWORD }}

CLAUDE.md

@@ -92,7 +92,7 @@ make dev-generate
 
 ```bash
 # Frontend
-cd services/agora && yarn lint && yarn test
+cd services/agora && pnpm lint && pnpm test
 
 # Backend API
 cd services/api && pnpm lint && pnpm test
@@ -197,7 +197,7 @@ pnpm db:undo
 
 ```bash
 # Build images for each service
-cd services/agora && yarn image:build
+cd services/agora && pnpm image:build
 cd services/api && pnpm image:build
 cd services/math-updater && pnpm image:build
 ```

Makefile

@@ -2,12 +2,12 @@ all: dev
 
 generate:
 	docker run --rm \
-		-v ${PWD}:/local openapitools/openapi-generator-cli:v7.12.0 generate \
+		-v ${PWD}:/local openapitools/openapi-generator-cli generate \
 		-i /local/services/api/openapi-zkorum.json \
 		-g typescript-axios \
 		-o /local/services/agora/src/api
 	docker run --rm \
-		-v ${PWD}:/local openapitools/openapi-generator-cli:v7.12.0 generate \
+		-v ${PWD}:/local openapitools/openapi-generator-cli generate \
 		-i /local/services/api/openapi-zkorum.json \
 		-g typescript-axios \
 		-o /local/services/load-testing/src/api
@@ -36,7 +36,7 @@ dev-generate:
 	watchman-make -p 'services/api/openapi-zkorum.json' -t generate
 
 dev-app:
-	cd services/agora && yarn dev 
+	cd services/agora && pnpm dev 
 
 dev-api:
 	cd services/api && pnpm start:dev

README.md

@@ -36,7 +36,6 @@ Install:
 - [pnpm](https://pnpm.io/)
 - [watchman](https://facebook.github.io/watchman/)
 - [docker](https://www.docker.com/)
-- [yarn](https://yarnpkg.com/)
 
 ## Services
 

services/agora/Dockerfile.production

@@ -3,8 +3,9 @@ FROM node:22-alpine AS build
 WORKDIR /app
 ENV PATH=/app/node_modules/.bin:$PATH
 COPY . ./
-RUN yarn install --frozen-lockfile
-RUN yarn build:production
+RUN npm install -g pnpm
+RUN pnpm install --frozen-lockfile
+RUN pnpm run build:production
 
 # production environment
 FROM nginx:stable-alpine

services/agora/Dockerfile.staging

@@ -3,8 +3,9 @@ FROM node:22-alpine AS build
 WORKDIR /app
 ENV PATH=/app/node_modules/.bin:$PATH
 COPY . ./
-RUN yarn install --frozen-lockfile
-RUN yarn build:staging
+RUN npm install -g pnpm
+RUN pnpm install --frozen-lockfile
+RUN pnpm run build:staging
 
 # production environment
 FROM nginx:stable-alpine

services/agora/README.md

@@ -8,24 +8,20 @@ Recommended: Install [nvm](https://github.com/nvm-sh/nvm) and install npm LTS us
 
 Or follow [npm documentation](https://docs.npmjs.com/downloading-and-installing-node-js-and-npm/)
 
-### Yarn
-
-Install [yarn](https://classic.yarnpkg.com/lang/en/docs/install/#mac-stable)
-
 ### Install dependencies
 
 Then cd to this root directy and install the dependencies:
 
 ```bash
-yarn
+pnpm install
 ```
 
 ### Prepare for IDE work
 
 Run:
 
 ```bash
-yarn prepare
+pnpm prepare
 ```
 
 ## Environment Variables
@@ -34,7 +30,7 @@ yarn prepare
 
 The project uses separate environment files for different build modes:
 
-- `.env.dev` - Development configuration (automatically loaded by `yarn dev`)
+- `.env.dev` - Development configuration (automatically loaded by `pnpm dev`)
 - `.env.staging` - Staging configuration (must include `VITE_STAGING=true`)
 - `.env.production` - Production configuration (must include `VITE_STAGING=false`)
 
@@ -47,8 +43,8 @@ cp env.example .env.dev
 Edit the files with your configuration values. Environment variables are accessed via the typed `processEnv` export, which wraps `import.meta.env` at runtime.
 
 **Build Process**:
-- Development: `yarn dev` automatically loads `.env.dev` via Quasar/Vite
-- Production builds: `yarn build:staging` and `yarn build:production` use `env-cmd` to load the appropriate env file before building
+- Development: `pnpm dev` automatically loads `.env.dev` via Quasar/Vite
+- Production builds: `pnpm build:staging` and `pnpm build:production` use `env-cmd` to load the appropriate env file before building
 
 We use `env-cmd` because:
 - Quasar has no built-in support for staging environments (only dev/production)
@@ -69,7 +65,7 @@ Environment variables are validated using a multi-layer approach:
    - Provides IDE autocomplete and compile-time type checking
 
 3. **Build-Time Validation** (custom Vite plugin in [quasar.config.ts](quasar.config.ts)):
-   - Runs during `yarn dev` / `yarn build` before app starts
+   - Runs during `pnpm dev` / `pnpm build` before app starts
    - Calls `validateEnv()` function during Vite's config phase
    - **Build fails immediately** if validation fails (missing/invalid variables)
    - Env object generated dynamically from schema keys (line 247-249)
@@ -84,7 +80,7 @@ For full documentation including variable descriptions and validation rules, see
 ## Start the app in development mode (hot-code reloading, error reporting, etc.)
 
 Start the app with:
-`yarn dev` in the `services/agora` directory or running `make dev-app` at the root of this project.
+`pnpm dev` in the `services/agora` directory or running `make dev-app` at the root of this project.
 
 ## Logos
 
@@ -108,13 +104,13 @@ quasar dev -m capacitor -T ios
 ## Lint the files
 
 ```bash
-yarn lint
+pnpm lint
 ```
 
 ## Format the files
 
 ```bash
-yarn format
+pnpm format
 ```
 
 ## Build the app for production

services/agora/package.json

@@ -21,7 +21,7 @@
     "build:ios": "quasar build -m capacitor -T ios --skip-pkg",
     "build:android": "quasar build -m capacitor -T android -- bundleRelease",
     "sign:android": "./scripts/artifact_sign.sh",
-    "build:ci:ios": "yarn quasar build -m capacitor -T ios --skip-pkg",
+    "build:ci:ios": "pnpm quasar build -m capacitor -T ios --skip-pkg",
     "image:build": "docker build -f Dockerfile.production -t agora-app .",
     "image:buildx": "docker buildx build -f Dockerfile.production --platform linux/amd64 -t agora-app --load .",
     "image:build:staging": "docker build -f Dockerfile.staging -t agora-app-staging .",
@@ -78,7 +78,7 @@
     "vue": "^3.5.25",
     "vue-i18n": "^11.1.12",
     "vue-router": "^4.6.4",
-    "zod": "^4.1.9"
+    "zod": "^4.3.5"
   },
   "devDependencies": {
     "@eslint/js": "^9.35.0",
@@ -101,7 +101,7 @@
     "prettier": "^3.4.2",
     "serve": "^14.2.5",
     "typescript": "5.9.3",
-    "unplugin-vue-router": "^0.19.1",
+    "unplugin-vue-router": "^0.19.2",
     "vite-plugin-checker": "^0.12.0",
     "vue-tsc": "^3.2.1"
   },