refactor(api): split opinion fetching for analysis views (#414)

Fixed AI label bug on analysis details page by separating analysis
opinion fetching from regular opinion fetching, ensuring cluster
statistics are always included in analysis views.

**Analysis API refactoring:**
- Split opinion fetching into two distinct code paths:
  * fetchOpinionsByPostSlugId: for regular opinion lists without
    cluster stats (new/moderated/hidden/discover feeds)
  * fetchAnalysisOpinionsByPostSlugId: for analysis views with
    cluster stats (consensus/controversial/representative opinions)
- Fixed AI label bug: analysis opinions now always include cluster
  statistics because they use the dedicated analysis fetch path
- Simplified filterTarget parameter (removed unused filter types)

**Type safety improvements:**
- Added AnalysisOpinionItem type that extends OpinionItem with
  required clustersStats array
- Ensures analysis opinions always have cluster statistics attached
- Prevents runtime errors from missing cluster data in UI components

**Load testing fixes:**
- Fixed 401 authentication errors during teardown phase
- Root cause: MemoryKeyStore keys were not shared between VUs and
  teardown environment in k6
- Solution: Added exportKeys/importKeys methods to MemoryKeyStore
- Keys now generated in setup(), exported as JSON, and imported into
  each VU and teardown phase
- Eliminates need to regenerate keys in teardown (which was failing)

**Code cleanup:**
- Removed 4 unused API endpoints (fetch-consensus, fetch-majority,
  fetch-controversial, fetch-representative)
- Removed ~3000 lines from OpenAPI spec (unused endpoint definitions)
- Removed unused imports and SQL query builder functions
- Simplified frontend query hooks with better cache management
- Removed dead cluster stats fetching code from user service
- Removed redundant SQL queries in user profile fetching

Net result: 33 files changed, 1536 insertions(+), 4479 deletions(-)

Author: nicobao

services/agora/src/api/api.ts

@@ -142,34 +142,39 @@ const participantCountLocal = ref(
 
 const { profileData } = storeToRefs(useUserStore());
 
-// Preload both analysis and comment data immediately when component mounts (only if not in compact mode)
+// Lazy load analysis data only when user clicks Analysis tab
+const isAnalysisEnabled = computed(() => !props.compactMode && currentTab.value === 'analysis');
 const analysisQuery = useAnalysisQuery({
   conversationSlugId: props.conversationData.metadata.conversationSlugId,
   voteCount: props.conversationData.metadata.voteCount,
-  enabled: !props.compactMode,
+  enabled: isAnalysisEnabled,
 });
 
 // Preload comment queries for all filter types (only if not in compact mode)
 const commentsDiscoverQuery = useCommentsQuery({
   conversationSlugId: props.conversationData.metadata.conversationSlugId,
   filter: "discover",
+  voteCount: props.conversationData.metadata.voteCount,
   enabled: !props.compactMode,
 });
 
 const commentsNewQuery = useCommentsQuery({
   conversationSlugId: props.conversationData.metadata.conversationSlugId,
   filter: "new",
+  voteCount: props.conversationData.metadata.voteCount,
   enabled: !props.compactMode,
 });
 
 const commentsModeratedQuery = useCommentsQuery({
   conversationSlugId: props.conversationData.metadata.conversationSlugId,
   filter: "moderated",
+  voteCount: props.conversationData.metadata.voteCount,
   enabled: !props.compactMode,
 });
 
 const hiddenCommentsQuery = useHiddenCommentsQuery({
   conversationSlugId: props.conversationData.metadata.conversationSlugId,
+  voteCount: props.conversationData.metadata.voteCount,
   enabled: !props.compactMode && profileData.value.isModerator,
 });
 

services/agora/src/components/post/PostDetails.vue

@@ -13,6 +13,8 @@
           :item-list="analysisQuery.data.value?.consensus || []"
           :compact-mode="currentTab === 'Summary'"
           :clusters="analysisQuery.data.value?.polisClusters || {}"
+          :cluster-labels="clusterLabels"
+          :vote-count="props.participantCount"
         />
       </div>
 
@@ -26,6 +28,8 @@
           :item-list="analysisQuery.data.value?.controversial || []"
           :compact-mode="currentTab === 'Summary'"
           :clusters="analysisQuery.data.value?.polisClusters || {}"
+          :cluster-labels="clusterLabels"
+          :vote-count="props.participantCount"
         />
       </div>
 
@@ -57,11 +61,15 @@ import {
   type AnalysisPageTranslations,
 } from "./AnalysisPage.i18n";
 import type { UseQueryReturnType } from "@tanstack/vue-query";
-import type { OpinionItem, PolisClusters } from "src/shared/types/zod";
+import type {
+  AnalysisOpinionItem,
+  PolisClusters,
+  PolisKey,
+} from "src/shared/types/zod";
 
 type AnalysisData = {
-  consensus: OpinionItem[];
-  controversial: OpinionItem[];
+  consensus: AnalysisOpinionItem[];
+  controversial: AnalysisOpinionItem[];
   polisClusters: Partial<PolisClusters>;
 };
 
@@ -80,6 +88,19 @@ const currentTab = ref<ShortcutItem>("Summary");
 // Use the passed-in analysis query instead of creating our own
 const analysisQuery = props.analysisQuery;
 
+// Extract only cluster labels for optimal performance (300 bytes instead of 300KB)
+const clusterLabels = computed(() => {
+  const labels: Partial<Record<PolisKey, string>> = {};
+  if (!analysisQuery.data.value?.polisClusters) return labels;
+
+  for (const [key, cluster] of Object.entries(analysisQuery.data.value.polisClusters)) {
+    if (cluster?.aiLabel) {
+      labels[key as PolisKey] = cluster.aiLabel;
+    }
+  }
+  return labels;
+});
+
 const asyncStateConfig = {
   loading: {
     text: t("loadingAnalysis"),

services/agora/src/components/post/analysis/AnalysisPage.vue

@@ -30,6 +30,8 @@
     v-model="showDialog"
     :conversation-slug-id="props.conversationSlugId"
     :opinion-item="props.opinionItem"
+    :vote-count="props.voteCount"
+    :cluster-labels="props.clusterLabels"
   />
 </template>
 
@@ -38,7 +40,11 @@ import { computed, ref } from "vue";
 import VoteCountVisualizer from "../common/VoteCountVisualizer.vue";
 import OpinionAnalysisDialog from "./OpinionAnalysisDialog.vue";
 import OpinionGridLayout from "../common/OpinionGridLayout.vue";
-import type { OpinionItem } from "src/shared/types/zod";
+import type {
+  AnalysisOpinionItem,
+  PolisClusters,
+  PolisKey,
+} from "src/shared/types/zod";
 import ZKHtmlContent from "src/components/ui-library/ZKHtmlContent.vue";
 import { useComponentI18n } from "src/composables/ui/useComponentI18n";
 import {
@@ -48,8 +54,11 @@ import {
 
 const props = defineProps<{
   conversationSlugId: string;
-  opinionItem: OpinionItem;
-  opinionItemForVisualizer: OpinionItem;
+  opinionItem: AnalysisOpinionItem;
+  opinionItemForVisualizer: AnalysisOpinionItem;
+  voteCount: number;
+  polisClusters: Partial<PolisClusters>;
+  clusterLabels: Partial<Record<PolisKey, string>>;
 }>();
 
 const { t } = useComponentI18n<ConsensusItemTranslations>(

services/agora/src/components/post/analysis/consensusTab/ConsensusItem.vue

@@ -30,6 +30,9 @@
           :conversation-slug-id="props.conversationSlugId"
           :opinion-item="consensusItem"
           :opinion-item-for-visualizer="consensusItem"
+          :vote-count="props.voteCount"
+          :polis-clusters="props.clusters"
+          :cluster-labels="props.clusterLabels"
         />
       </template>
     </AnalysisSectionWrapper>
@@ -43,7 +46,11 @@ import AnalysisActionButton from "../common/AnalysisActionButton.vue";
 import EmptyStateMessage from "../common/EmptyStateMessage.vue";
 import ConsensusItem from "./ConsensusItem.vue";
 import type { ShortcutItem } from "src/utils/component/analysis/shortcutBar";
-import type { OpinionItem, PolisClusters } from "src/shared/types/zod";
+import type {
+  AnalysisOpinionItem,
+  PolisClusters,
+  PolisKey,
+} from "src/shared/types/zod";
 import { useComponentI18n } from "src/composables/ui/useComponentI18n";
 import {
   consensusTabTranslations,
@@ -52,9 +59,11 @@ import {
 
 const props = defineProps<{
   conversationSlugId: string;
-  itemList: OpinionItem[];
+  itemList: AnalysisOpinionItem[];
   compactMode: boolean;
   clusters: Partial<PolisClusters>;
+  clusterLabels: Partial<Record<PolisKey, string>>;
+  voteCount: number;
 }>();
 
 const currentTab = defineModel<ShortcutItem>();

services/agora/src/components/post/analysis/consensusTab/ConsensusTab.vue

@@ -126,7 +126,7 @@
                   >
                     <td class="group-name">
                       {{
-                        `${formatClusterLabel(group.key, true, group.aiLabel)} (${formatAmount(group.numUsers)})`
+                        `${formatClusterLabel(group.key, true, getClusterLabel(group.key))} (${formatAmount(group.numUsers)})`
                       }}
                     </td>
                     <td class="agree-cell">
@@ -177,7 +177,10 @@
 import ZKButton from "src/components/ui-library/ZKButton.vue";
 import ZKHtmlContent from "src/components/ui-library/ZKHtmlContent.vue";
 import OpinionIdentityCard from "src/components/post/comments/OpinionIdentityCard.vue";
-import type { OpinionItem } from "src/shared/types/zod";
+import type {
+  AnalysisOpinionItem,
+  PolisKey,
+} from "src/shared/types/zod";
 import { formatClusterLabel } from "src/utils/component/opinion";
 import { calculatePercentage } from "src/shared/util";
 import { formatAmount, formatPercentage } from "src/utils/common";
@@ -191,7 +194,9 @@ import {
 
 const props = defineProps<{
   conversationSlugId: string;
-  opinionItem: OpinionItem;
+  opinionItem: AnalysisOpinionItem;
+  voteCount: number;
+  clusterLabels: Partial<Record<PolisKey, string>>;
 }>();
 
 const { forceOpenComment } = useRouterNavigation();
@@ -202,6 +207,10 @@ const { t } = useComponentI18n<OpinionAnalysisDialogTranslations>(
 
 const showDialog = defineModel<boolean>({ required: true });
 
+function getClusterLabel(key: PolisKey): string | undefined {
+  return props.clusterLabels[key];
+}
+
 const noGroupStats = computed(() => {
   const totalClusteredAgrees = props.opinionItem.clustersStats.reduce(
     (sum, cluster) => sum + cluster.numAgrees,

services/agora/src/components/post/analysis/consensusTab/OpinionAnalysisDialog.vue

@@ -30,6 +30,9 @@
           :conversation-slug-id="props.conversationSlugId"
           :opinion-item="consensusItem"
           :opinion-item-for-visualizer="consensusItem"
+          :vote-count="props.voteCount"
+          :polis-clusters="props.clusters"
+          :cluster-labels="props.clusterLabels"
         />
       </template>
     </AnalysisSectionWrapper>
@@ -43,7 +46,11 @@ import AnalysisActionButton from "../common/AnalysisActionButton.vue";
 import EmptyStateMessage from "../common/EmptyStateMessage.vue";
 import ConsensusItem from "../consensusTab/ConsensusItem.vue";
 import type { ShortcutItem } from "src/utils/component/analysis/shortcutBar";
-import type { OpinionItem, PolisClusters } from "src/shared/types/zod";
+import type {
+  AnalysisOpinionItem,
+  PolisClusters,
+  PolisKey,
+} from "src/shared/types/zod";
 import { useComponentI18n } from "src/composables/ui/useComponentI18n";
 import {
   divisiveTabTranslations,
@@ -52,9 +59,11 @@ import {
 
 const props = defineProps<{
   conversationSlugId: string;
-  itemList: OpinionItem[];
+  itemList: AnalysisOpinionItem[];
   compactMode: boolean;
   clusters: Partial<PolisClusters>;
+  clusterLabels: Partial<Record<PolisKey, string>>;
+  voteCount: number;
 }>();
 
 const currentTab = defineModel<ShortcutItem>();

services/agora/src/components/post/analysis/divisivenessTab/DivisiveTab.vue

@@ -36,15 +36,21 @@
         :conversation-slug-id="props.conversationSlugId"
         :opinion-item="comment"
         :opinion-item-for-visualizer="getModifiedOpinionItem(comment)"
+        :vote-count="props.voteCount"
+        :polis-clusters="props.polisClusters"
+        :cluster-labels="props.clusterLabels"
       />
     </div>
   </div>
 </template>
 
 <script setup lang="ts">
 import { computed, ref, watch } from "vue";
-import type { OpinionItem } from "src/shared/types/zod";
-import type { PolisKey } from "src/shared/types/zod";
+import type {
+  AnalysisOpinionItem,
+  PolisClusters,
+  PolisKey,
+} from "src/shared/types/zod";
 import ConsensusItem from "../consensusTab/ConsensusItem.vue";
 import { useComponentI18n } from "src/composables/ui/useComponentI18n";
 import {
@@ -54,9 +60,12 @@ import {
 
 const props = defineProps<{
   conversationSlugId: string;
-  itemList: OpinionItem[];
+  itemList: AnalysisOpinionItem[];
   currentClusterTab: PolisKey;
   hasUngroupedParticipants: boolean;
+  voteCount: number;
+  polisClusters: Partial<PolisClusters>;
+  clusterLabels: Partial<Record<PolisKey, string>>;
 }>();
 
 const { t } = useComponentI18n<OpinionGroupCommentsTranslations>(
@@ -74,7 +83,7 @@ watch(
   }
 );
 
-function getActiveVotes(comment: OpinionItem) {
+function getActiveVotes(comment: AnalysisOpinionItem) {
   const currentClusterStats = comment.clustersStats.find(
     (cv) => cv.key === props.currentClusterTab
   );
@@ -136,7 +145,7 @@ function getActiveVotes(comment: OpinionItem) {
   }
 }
 
-function getModifiedOpinionItem(comment: OpinionItem): OpinionItem {
+function getModifiedOpinionItem(comment: AnalysisOpinionItem): AnalysisOpinionItem {
   const activeVotes = getActiveVotes(comment);
   return {
     ...comment,

services/agora/src/components/post/analysis/opinionGroupTab/OpinionGroupComments.vue

@@ -52,11 +52,13 @@
           <OpinionGroupComments
             :conversation-slug-id="props.conversationSlugId"
             :item-list="
-              props.clusters[currentClusterTab]?.representative ??
-              ([] as OpinionItem[])
+              props.clusters[currentClusterTab]?.representative ?? []
             "
             :current-cluster-tab="currentClusterTab"
             :has-ungrouped-participants="hasUngroupedParticipants"
+            :vote-count="props.totalParticipantCount"
+            :polis-clusters="props.clusters"
+            :cluster-labels="clusterLabels"
             @update:current-cluster-tab="currentClusterTab = $event"
           />
         </template>
@@ -69,7 +71,6 @@
 
 <script setup lang="ts">
 import type {
-  OpinionItem,
   PolisClusters,
   PolisKey,
 } from "src/shared/types/zod";
@@ -124,4 +125,15 @@ const currentAiSummary = computed(() => {
   }
   return undefined;
 });
+
+// Extract only cluster labels for optimal performance
+const clusterLabels = computed(() => {
+  const labels: Partial<Record<PolisKey, string>> = {};
+  for (const [key, cluster] of Object.entries(props.clusters)) {
+    if (cluster?.aiLabel) {
+      labels[key as PolisKey] = cluster.aiLabel;
+    }
+  }
+  return labels;
+});
 </script>

services/agora/src/components/post/analysis/opinionGroupTab/OpinionGroupTab.vue

@@ -70,9 +70,9 @@ import { StandardMenuBar } from "src/components/navigation/header/variants";
 import DrawerLayout from "src/layouts/DrawerLayout.vue";
 import OpinionGroupTab from "src/components/post/analysis/opinionGroupTab/OpinionGroupTab.vue";
 import type {
+  AnalysisOpinionItem,
   PolisClusters,
   PolisKey,
-  OpinionItem,
 } from "src/shared/types/zod";
 import {
   opinionGroupVisualizationTranslations,
@@ -121,8 +121,8 @@ const clusterSummaries = [
   "This group is driven by idealistic principles and long-term vision.",
 ];
 
-function generateMockOpinions(count: number = 3): OpinionItem[] {
-  const mockOpinions: OpinionItem[] = [];
+function generateMockOpinions(count: number = 3): AnalysisOpinionItem[] {
+  const mockOpinions: AnalysisOpinionItem[] = [];
 
   for (let i = 0; i < count; i++) {
     mockOpinions.push({