Commit c48eadb
authored
Fix after test (#412)
* fix(frontend): clear draft after navigation completes
When creating a conversation with seed opinions and clicking "Publier", the
review page briefly flashed showing empty fields before unmounting. This
occurred because the draft was being cleared before the component unmounted,
causing a reactive re-render of the form with empty values.
Previous fix (PR #411) kept the loading state active during navigation but
still cleared the draft in the review page before navigation completed.
Changes:
- Remove draft clearing from review page (services/agora/src/pages/conversation/new/review/index.vue was already fixed in PR #411)
- Add draft clearing to conversation page onMounted lifecycle
- Check cameFromConversationCreation flag to only clear after successful creation
- Use resetDraft() store method for proper cleanup
Flow:
1. User clicks "Publier" - loading state activates, draft data intact
2. Navigation starts - review page stays rendered with data
3. Review page unmounts - no re-render because draft wasn't cleared
4. Conversation page mounts and renders
5. Conversation page onMounted checks flag and silently clears draft
6. Draft is now empty for next conversation creation
This ensures the review page maintains its visual state during unmount,
preventing any flash of empty form fields during the transition.
* fix(frontend): translate "copied to clipboard" notifications
The "Copied link to clipboard" notification was hardcoded in English in
both PostDetails.vue and WebShare.ts. This change adds proper i18n support
to ensure all clipboard copy notifications are translated across all 7
supported languages.
Changes:
- Created PostDetails.i18n.ts with copiedToClipboard translations
- Updated PostDetails.vue to use translated notification in copyLinkCallback
- Created WebShare.i18n.ts with copiedToClipboard translations
- Updated WebShare.ts to use translated notification in fallback path
- Removed Platform.is.mobile check from WebShare to support Web Share API
on all browsers where available
Now all "Copied link to clipboard" messages in the share flow are properly
translated and will display in the user's selected language.1 parent 762628a commit c48eadb
5 files changed
Lines changed: 99 additions & 6 deletions
File tree
- services/agora/src
- components/post
- pages/conversation
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
110 | 110 | | |
111 | 111 | | |
112 | 112 | | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
113 | 118 | | |
114 | 119 | | |
115 | 120 | | |
| |||
129 | 134 | | |
130 | 135 | | |
131 | 136 | | |
| 137 | + | |
132 | 138 | | |
133 | 139 | | |
134 | 140 | | |
| |||
234 | 240 | | |
235 | 241 | | |
236 | 242 | | |
237 | | - | |
| 243 | + | |
238 | 244 | | |
239 | 245 | | |
240 | 246 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
34 | | - | |
| 34 | + | |
35 | 35 | | |
| 36 | + | |
36 | 37 | | |
37 | 38 | | |
38 | 39 | | |
39 | 40 | | |
40 | 41 | | |
| 42 | + | |
41 | 43 | | |
42 | 44 | | |
43 | 45 | | |
| |||
49 | 51 | | |
50 | 52 | | |
51 | 53 | | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
52 | 61 | | |
53 | 62 | | |
54 | 63 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
3 | 2 | | |
4 | 3 | | |
5 | 4 | | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
6 | 10 | | |
7 | 11 | | |
8 | 12 | | |
9 | 13 | | |
10 | 14 | | |
11 | 15 | | |
| 16 | + | |
12 | 17 | | |
13 | 18 | | |
14 | | - | |
15 | | - | |
| 19 | + | |
16 | 20 | | |
17 | 21 | | |
18 | 22 | | |
| |||
30 | 34 | | |
31 | 35 | | |
32 | 36 | | |
33 | | - | |
| 37 | + | |
34 | 38 | | |
35 | 39 | | |
36 | 40 | | |
| |||
0 commit comments