Skip to content

Commit 2fa98e0

Browse files
committed
add some missed assert messages
1 parent 6804586 commit 2fa98e0

File tree

6 files changed

+24
-22
lines changed

6 files changed

+24
-22
lines changed

tests/unit-global/es.array.flat-map.js

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,11 @@ QUnit.test('Array#flatMap', assert => {
1616
const array = [1];
1717
const context = {};
1818
array.flatMap(function (value, key, that) {
19-
assert.same(value, 1);
20-
assert.same(key, 0);
21-
assert.same(that, array);
22-
assert.same(this, context);
19+
assert.same(arguments.length, 3, 'correct number of callback arguments');
20+
assert.same(value, 1, 'correct value in callback');
21+
assert.same(key, 0, 'correct index in callback');
22+
assert.same(that, array, 'correct link to array in callback');
23+
assert.same(this, context, 'correct callback context');
2324
return value;
2425
}, context);
2526
if (STRICT) {

tests/unit-global/es.map.group-by.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@ QUnit.test('Map.groupBy', assert => {
2020

2121
const element = {};
2222
groupBy([element], function (it, i) {
23-
assert.same(arguments.length, 2);
24-
assert.same(it, element);
25-
assert.same(i, 0);
23+
assert.same(arguments.length, 2, 'correct number of callback arguments');
24+
assert.same(it, element, 'correct value in callback');
25+
assert.same(i, 0, 'correct index in callback');
2626
});
2727
});

tests/unit-global/es.object.group-by.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ QUnit.test('Object.groupBy', assert => {
99
assert.looksNative(groupBy);
1010
assert.nonEnumerable(Object, 'groupBy');
1111

12-
assert.same(getPrototypeOf(groupBy([], it => it)), null);
12+
assert.same(getPrototypeOf(groupBy([], it => it)), null, 'null proto');
1313

1414
assert.deepEqual(entries(groupBy([], it => it)), []);
1515
assert.deepEqual(entries(groupBy([1, 2], it => it ** 2)), [['1', [1]], ['4', [2]]]);
@@ -19,9 +19,9 @@ QUnit.test('Object.groupBy', assert => {
1919

2020
const element = {};
2121
groupBy([element], function (it, i) {
22-
assert.same(arguments.length, 2);
23-
assert.same(it, element);
24-
assert.same(i, 0);
22+
assert.same(arguments.length, 2, 'correct number of callback arguments');
23+
assert.same(it, element, 'correct value in callback');
24+
assert.same(i, 0, 'correct index in callback');
2525
});
2626

2727
const even = Symbol('even');

tests/unit-pure/es.array.flat-map.js

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,11 @@ QUnit.test('Array#flatMap', assert => {
1212
const array = [1];
1313
const context = {};
1414
flatMap(array, function (value, index, that) {
15-
assert.same(value, 1);
16-
assert.same(index, 0);
17-
assert.same(that, array);
18-
assert.same(this, context);
15+
assert.same(arguments.length, 3, 'correct number of callback arguments');
16+
assert.same(value, 1, 'correct value in callback');
17+
assert.same(index, 0, 'correct index in callback');
18+
assert.same(that, array, 'correct link to array in callback');
19+
assert.same(this, context, 'correct callback context');
1920
return value;
2021
}, context);
2122
if (STRICT) {

tests/unit-pure/es.map.group-by.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@ QUnit.test('Map.groupBy', assert => {
2020

2121
const element = {};
2222
groupBy([element], function (it, i) {
23-
assert.same(arguments.length, 2);
24-
assert.same(it, element);
25-
assert.same(i, 0);
23+
assert.same(arguments.length, 2, 'correct number of callback arguments');
24+
assert.same(it, element, 'correct value in callback');
25+
assert.same(i, 0, 'correct index in callback');
2626
});
2727
});

tests/unit-pure/es.object.group-by.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ QUnit.test('Object.groupBy', assert => {
99
assert.arity(groupBy, 2);
1010
assert.name(groupBy, 'groupBy');
1111

12-
assert.same(getPrototypeOf(groupBy([], it => it)), null);
12+
assert.same(getPrototypeOf(groupBy([], it => it)), null, 'null proto');
1313

1414
assert.deepEqual(entries(groupBy([], it => it)), []);
1515
assert.deepEqual(entries(groupBy([1, 2], it => it ** 2)), [['1', [1]], ['4', [2]]]);
@@ -19,9 +19,9 @@ QUnit.test('Object.groupBy', assert => {
1919

2020
const element = {};
2121
groupBy([element], function (it, i) {
22-
assert.same(arguments.length, 2);
23-
assert.same(it, element);
24-
assert.same(i, 0);
22+
assert.same(arguments.length, 2, 'correct number of callback arguments');
23+
assert.same(it, element, 'correct value in callback');
24+
assert.same(i, 0, 'correct index in callback');
2525
});
2626

2727
const even = Symbol('even');

0 commit comments

Comments
 (0)