Skip to content

Commit 4e8ff5f

Browse files
committed
some tweaks
1 parent 88bea6c commit 4e8ff5f

File tree

3 files changed

+8
-9
lines changed

3 files changed

+8
-9
lines changed

packages/core-js/modules/esnext.promise.all-keyed.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,8 @@ $({ target: 'Promise', stat: true, forced: true }, {
4949
--remaining;
5050
if (remaining === 0) {
5151
var res = create(null);
52-
forEach(keys, function (k, idx) {
53-
createProperty(res, k, values[idx]);
52+
forEach(keys, function (k, i) {
53+
createProperty(res, k, values[i]);
5454
});
5555
resolve(res);
5656
}

packages/core-js/modules/esnext.promise.all-settled-keyed.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,10 @@ $({ target: 'Promise', stat: true, forced: true }, {
2828
var resolve = capability.resolve;
2929
var reject = capability.reject;
3030
var result = perform(function () {
31-
var wrapResolve = function () {
31+
var createResultObjectAndResolve = function () {
3232
var res = create(null);
33-
forEach(keys, function (k, idx) {
34-
createProperty(res, k, values[idx]);
33+
forEach(keys, function (key, index) {
34+
createProperty(res, key, values[index]);
3535
});
3636
resolve(res);
3737
};
@@ -53,17 +53,17 @@ $({ target: 'Promise', stat: true, forced: true }, {
5353
if (alreadyCalled) return;
5454
alreadyCalled = true;
5555
values[index] = { status: 'fulfilled', value: value };
56-
--remaining || wrapResolve();
56+
--remaining || createResultObjectAndResolve();
5757
}, function (error) {
5858
if (alreadyCalled) return;
5959
alreadyCalled = true;
6060
values[index] = { status: 'rejected', reason: error };
61-
--remaining || wrapResolve();
61+
--remaining || createResultObjectAndResolve();
6262
});
6363
counter++;
6464
}
6565
});
66-
--remaining || wrapResolve();
66+
--remaining || createResultObjectAndResolve();
6767
});
6868
if (result.error) reject(result.value);
6969
return capability.promise;

tests/unit-pure/esnext.promise.all-settled-keyed.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ QUnit.test('Promise.allSettledKeyed, resolved with rejection', assert => {
3838
});
3939

4040
QUnit.test('Promise.allSettledKeyed, rejected', assert => {
41-
// eslint-disable-next-line promise/valid-params -- required for testing
4241
return Promise.allSettledKeyed().then(() => {
4342
assert.avoid();
4443
}, () => {

0 commit comments

Comments
 (0)