Fix Symbols

Author: slowcheetah

packages/core-js-types/src/base/pure/proposals/symbol.d.ts

@@ -1,5 +1,4 @@
-// Motivation: We should use SymbolConstructor without asyncIterator, matchAll, dispose, asyncDispose,
-// customMatcher, metadata properties to avoid signature conflicts
+// Motivation: We should use all unique symbols in SymbolConstructor with fallback
 
 // proposal stage: 3
 // https://github.com/tc39/proposal-explicit-resource-management
@@ -33,24 +32,20 @@
 // License: https://github.com/microsoft/TypeScript/blob/v5.9.3/LICENSE.txt
 
 declare namespace CoreJS {
-  type BaseSymbolConstructor = {
-    (description?: string | number | symbol): symbol;
-    new (description?: string | number | symbol): symbol;
-  } & Omit<
-    SymbolConstructor,
-    'asyncIterator' | 'matchAll' | 'dispose' | 'asyncDispose' | 'customMatcher' | 'metadata'
-  >;
-
-  export interface CoreJSSymbolConstructor extends BaseSymbolConstructor {
+  const CoreJSFallbackSymbol: unique symbol;
+  type CoreJSFallbackSymbolType = typeof CoreJSFallbackSymbol;
+  type GetNativeWithFallback<T, K extends PropertyKey> = K extends keyof T ? T[K] : CoreJSFallbackSymbolType;
+
+  export interface CoreJSSymbolConstructor extends SymbolConstructor {
     /**
      * A method that is used to release resources held by an object. Called by the semantics of the `using` statement.
      */
-    readonly dispose: unique symbol;
+    readonly dispose: GetNativeWithFallback<SymbolConstructor, 'dispose'>;
 
     /**
      * A method that is used to asynchronously release resources held by an object. Called by the semantics of the `await using` statement.
      */
-    readonly asyncDispose: unique symbol;
+    readonly asyncDispose: GetNativeWithFallback<SymbolConstructor, 'asyncDispose'>;
 
     /**
      * Determines whether the given value is a registered symbol.
@@ -68,13 +63,13 @@ declare namespace CoreJS {
      * A method that returns the default async iterator for an object. Called by the semantics of
      * the for-await-of statement.
      */
-    readonly asyncIterator: unique symbol;
+    readonly asyncIterator: GetNativeWithFallback<SymbolConstructor, 'asyncIterator'>;
 
-    readonly customMatcher: unique symbol;
+    readonly customMatcher: GetNativeWithFallback<SymbolConstructor, 'customMatcher'>;
 
-    readonly metadata: unique symbol;
+    readonly metadata: GetNativeWithFallback<SymbolConstructor, 'metadata'>;
 
-    readonly matchAll: unique symbol;
+    readonly matchAll: GetNativeWithFallback<SymbolConstructor, 'matchAll'>;
   }
 
   export interface CoreJSSymbol extends Symbol {

tests/type-definitions/pure/proposals/await-dictionary.test.ts

@@ -1,7 +1,6 @@
 import promiseAllKeyed from '@core-js/pure/full/promise/all-keyed';
 import promiseAllSettledKeyed from '@core-js/pure/full/promise/all-settled-keyed';
 import promiseResolve from '@core-js/pure/full/promise/resolve';
-import $Symbol from '@core-js/pure/full/symbol';
 import { CoreJSPromiseAndPromiseLike } from '../../helpers';
 
 const res: CoreJSPromiseAndPromiseLike<{ a: number, b: string, c: boolean }> = promiseAllKeyed({
@@ -10,7 +9,7 @@ const res: CoreJSPromiseAndPromiseLike<{ a: number, b: string, c: boolean }> = p
   c: promiseResolve(true),
 });
 
-const sym = $Symbol('sym');
+declare const sym: unique symbol;
 const res2: CoreJSPromiseAndPromiseLike<{ [sym]: number }> = promiseAllKeyed({
   [sym]: promiseResolve(1)
 });