fix some cases of '' and null host handling in the URL polyfill

Author: zloirock

CHANGELOG.md

@@ -25,6 +25,7 @@
 - Fixed possible removal of unnecessary entries in `URLSearchParam.prototype.delete` polyfill with second argument
 - Fixed an error in some cases of non-special URLs without a path in the `URL` polyfill
 - Fixed some percent encode cases / character sets in the `URL` polyfill
+- Fixed some cases of `''` and `null` host handling in the `URL` polyfill
 - Fixed host parsing with `hostname = host:port` in the `URL` polyfill
 - Fixed invalid code points handling in UTF-8 decode in the `URLSearchParams` polyfill
 - Fixed some cases of serialization in `URL` polyfill (`/.` prefix for non-special URLs with `null` host and path starting with empty segment)

packages/core-js/modules/web.url.constructor.js

@@ -396,7 +396,7 @@ URLState.prototype = {
             if (stateOverride && (
               (url.isSpecial() !== hasOwn(specialSchemes, buffer)) ||
               (buffer === 'file' && (url.includesCredentials() || url.port !== null)) ||
-              (url.scheme === 'file' && !url.host)
+              (url.scheme === 'file' && url.host === '')
             )) return;
             url.scheme = buffer;
             if (stateOverride) {
@@ -700,7 +700,7 @@ URLState.prototype = {
               }
             } else {
               if (url.scheme === 'file' && !url.path.length && isWindowsDriveLetter(buffer)) {
-                if (url.host) url.host = '';
+                if (url.host !== null && url.host !== '') url.host = '';
                 buffer = charAt(buffer, 0) + ':'; // normalize windows drive letter
               }
               push(url.path, buffer);
@@ -776,7 +776,7 @@ URLState.prototype = {
   },
   // https://url.spec.whatwg.org/#cannot-have-a-username-password-port
   cannotHaveUsernamePasswordPort: function () {
-    return !this.host || this.cannotBeABaseURL || this.scheme === 'file';
+    return this.host === null || this.host === '' || this.cannotBeABaseURL || this.scheme === 'file';
   },
   // https://url.spec.whatwg.org/#include-credentials
   includesCredentials: function () {

tests/unit-global/web.url.js

@@ -221,6 +221,12 @@ QUnit.test('URL#username', assert => {
     url.username = 'username';
     assert.same(url.username, 'username');
     assert.same(String(url), 'http://username@zloirock.ru/');
+
+    // IPv4 address 0.0.0.0 (stored as number 0) should allow username
+    url = new URL('http://0.0.0.0/');
+    url.username = 'user';
+    assert.same(url.username, 'user', 'username settable on 0.0.0.0');
+    assert.same(String(url), 'http://user@0.0.0.0/', 'href correct after setting username on 0.0.0.0');
   }
 });
 
@@ -443,6 +449,12 @@ QUnit.test('URL#port', assert => {
     // url.port = 1e10;
     // assert.same(url.port, '1234'); // '0' in Chrome
     // assert.same(String(url), 'http://zloirock.ru:1234/'); // 'http://zloirock.ru:0/' in Chrome
+
+    // IPv4 address 0.0.0.0 (stored as number 0) should allow port
+    url = new URL('http://0.0.0.0/');
+    url.port = '8080';
+    assert.same(url.port, '8080', 'port settable on 0.0.0.0');
+    assert.same(String(url), 'http://0.0.0.0:8080/', 'href correct after setting port on 0.0.0.0');
   }
 });
 

tests/unit-pure/web.url.js

@@ -222,6 +222,12 @@ QUnit.test('URL#username', assert => {
     url.username = 'username';
     assert.same(url.username, 'username');
     assert.same(String(url), 'http://username@zloirock.ru/');
+
+    // IPv4 address 0.0.0.0 (stored as number 0) should allow username
+    url = new URL('http://0.0.0.0/');
+    url.username = 'user';
+    assert.same(url.username, 'user', 'username settable on 0.0.0.0');
+    assert.same(String(url), 'http://user@0.0.0.0/', 'href correct after setting username on 0.0.0.0');
   }
 });
 
@@ -444,6 +450,12 @@ QUnit.test('URL#port', assert => {
     // url.port = 1e10;
     // assert.same(url.port, '1234'); // '0' in Chrome
     // assert.same(String(url), 'http://zloirock.ru:1234/'); // 'http://zloirock.ru:0/' in Chrome
+
+    // IPv4 address 0.0.0.0 (stored as number 0) should allow port
+    url = new URL('http://0.0.0.0/');
+    url.port = '8080';
+    assert.same(url.port, '8080', 'port settable on 0.0.0.0');
+    assert.same(String(url), 'http://0.0.0.0:8080/', 'href correct after setting port on 0.0.0.0');
   }
 });