add arg-is-string plugin filter

Author: zloirock

packages/core-js-babel-plugin/index.js

@@ -89,14 +89,23 @@ module.exports = defineProvider(({
     }
   }
 
+  function isCallOrNew(node, callee) {
+    return t.isCallExpression(node, { callee }) || t.isNewExpression(node, { callee });
+  }
+
   function filter(name, args, path) {
     const { node, parent } = path;
-    // eslint-disable-next-line sonarjs/no-small-switch -- tba
     switch (name) {
       case 'min-args':
-        if (!t.isCallExpression(parent, { callee: node }) && !t.isNewExpression(parent, { callee: node })) return false;
+        if (!isCallOrNew(parent, node)) return false;
         if (parent.arguments.length >= args[0]) return false;
         return parent.arguments.every(arg => !t.isSpreadElement(arg));
+      case 'arg-is-string': {
+        if (!isCallOrNew(parent, node)) return false;
+        if (parent.arguments.length < args[0]) return true;
+        const arg = parent.arguments[args[0]];
+        return t.isStringLiteral(arg) || t.isTemplateLiteral(arg);
+      }
     }
   }
 

packages/core-js-compat/src/built-in-definitions.mjs

@@ -312,7 +312,10 @@ export const InstanceProperties = {
   some: { global: 'iterator/some' },
   sort: 'instance/sort',
   splice: 'instance/splice',
-  split: undefined,
+  split: { global: {
+    common: { dependencies: 'string/split', filters: [['arg-is-string', 0]] },
+    string: { dependencies: 'string/split', filters: [['arg-is-string', 0]] },
+  } },
   startsWith: 'instance/starts-with',
   sticky: { global: 'regexp/sticky' },
   strike: { global: 'string/strike' },

tests/babel-plugin/fixtures/usage-global/split-object-call-no-args/input.mjs

@@ -0,0 +1 @@
+({}).split();

tests/babel-plugin/fixtures/usage-global/split-object-call-no-args/options.json

@@ -0,0 +1,14 @@
+{
+  "plugins": [
+    [
+      "@core-js",
+      {
+        "method": "usage-global",
+        "version": "4.0",
+        "targets": {
+          "ie": 11
+        }
+      }
+    ]
+  ]
+}

tests/babel-plugin/fixtures/usage-global/split-object-call-no-args/output.mjs

@@ -0,0 +1 @@
+({}).split();

tests/babel-plugin/fixtures/usage-global/split-object-call-regexp/input.mjs

@@ -0,0 +1 @@
+({}).split(/./);

tests/babel-plugin/fixtures/usage-global/split-object-call-regexp/options.json

@@ -0,0 +1,14 @@
+{
+  "plugins": [
+    [
+      "@core-js",
+      {
+        "method": "usage-global",
+        "version": "4.0",
+        "targets": {
+          "ie": 11
+        }
+      }
+    ]
+  ]
+}

tests/babel-plugin/fixtures/usage-global/split-object-call-regexp/output.mjs

@@ -0,0 +1 @@
+({}).split(/./);

tests/babel-plugin/fixtures/usage-global/split-object-call-string/input.mjs

@@ -0,0 +1 @@
+({}).split('');

tests/babel-plugin/fixtures/usage-global/split-object-call-string/options.json

@@ -0,0 +1,14 @@
+{
+  "plugins": [
+    [
+      "@core-js",
+      {
+        "method": "usage-global",
+        "version": "4.0",
+        "targets": {
+          "ie": 11
+        }
+      }
+    ]
+  ]
+}