fix possible removal of extra entries in URLSearchParam.prototype.delete polyfill with second argument

Author: zloirock

CHANGELOG.md

@@ -22,6 +22,7 @@
 - Fixed handling of some line terminators in case of `multiline` + `sticky` mode in `RegExp` polyfill
 - Fixed handling of empty groups with `global` and `unicode` flags in polyfills
 - Fixed `URLSearchParam.prototype.delete` polyfill with duplicate key-value pairs
+- Fixed possible removal of unnecessary entries in `URLSearchParam.prototype.delete` polyfill with second argument
 - Fixed an error in some cases of non-special URLs without a path in the `URL` polyfill
 - Fixed some percent encode cases / character sets in the `URL` polyfill
 - Fixed host parsing with `hostname = host:port` in the `URL` polyfill

packages/core-js/modules/web.url-search-params.delete.js

@@ -30,19 +30,16 @@ if (params + '' !== 'a=2') {
     var key = toString(name);
     var value = toString($value);
     var index = 0;
-    var dindex = 0;
-    var found = false;
     var entriesLength = entries.length;
     var entry;
     while (index < entriesLength) {
-      entry = entries[index++];
-      if (found || entry.key === key) {
-        found = true;
-        $delete(this, entry.key);
-      } else dindex++;
+      entry = entries[index];
+      $delete(this, entry.key);
+      index++;
     }
-    while (dindex < entriesLength) {
-      entry = entries[dindex++];
+    index = 0;
+    while (index < entriesLength) {
+      entry = entries[index++];
       if (!(entry.key === key && entry.value === value)) append(this, entry.key, entry.value);
     }
   }, { enumerable: true, unsafe: true });

tests/unit-global/web.url-search-params.js

@@ -295,6 +295,19 @@ QUnit.test('URLSearchParams#delete', assert => {
   params.delete('a', undefined);
   assert.same(String(params), 'b=4');
 
+  // delete with value should not drop entries with the same key before the target
+  params = new URLSearchParams('b=1&a=2&b=3');
+  params.delete('a', '2');
+  assert.same(String(params), 'b=1&b=3', 'entries before target with same key preserved');
+
+  params = new URLSearchParams('a=1&a=2&b=3');
+  params.delete('a', '1');
+  assert.same(String(params), 'a=2&b=3', 'only matching name+value pairs removed, rest preserved');
+
+  params = new URLSearchParams('a=1&b=2');
+  params.delete('a', '999');
+  assert.same(String(params), 'a=1&b=2', 'no match leaves all entries intact');
+
   if (DESCRIPTORS) {
     let url = new URL('http://example.com/?param1&param2');
     url.searchParams.delete('param1');

tests/unit-pure/web.url-search-params.js

@@ -295,6 +295,19 @@ QUnit.test('URLSearchParams#delete', assert => {
   params.delete('a', undefined);
   assert.same(String(params), 'b=4');
 
+  // delete with value should not drop entries with the same key before the target
+  params = new URLSearchParams('b=1&a=2&b=3');
+  params.delete('a', '2');
+  assert.same(String(params), 'b=1&b=3', 'entries before target with same key preserved');
+
+  params = new URLSearchParams('a=1&a=2&b=3');
+  params.delete('a', '1');
+  assert.same(String(params), 'a=2&b=3', 'only matching name+value pairs removed, rest preserved');
+
+  params = new URLSearchParams('a=1&b=2');
+  params.delete('a', '999');
+  assert.same(String(params), 'a=1&b=2', 'no match leaves all entries intact');
+
   if (DESCRIPTORS) {
     let url = new URL('http://example.com/?param1&param2');
     url.searchParams.delete('param1');