Types linting: interfaces

Author: slowcheetah

packages/core-js-types/src/base/proposals/array-buffer-base64.d.ts

@@ -8,20 +8,20 @@ type alphabet = 'base64' | 'base64url';
 
 type lastChunkHandling = 'loose' | 'strict' | 'stop-before-partial';
 
-type fromBase64Options = {
+interface fromBase64Options {
   alphabet?: alphabet;
   lastChunkHandling?: lastChunkHandling;
-};
+}
 
-type toBase64Options = {
+interface toBase64Options {
   alphabet?: alphabet;
   omitPadding?: boolean;
-};
+}
 
-type processMetadata = {
+interface processMetadata {
   read: number;
   written: number;
-};
+}
 
 interface Uint8ArrayConstructor {
   /**

packages/core-js-types/src/base/proposals/iterator-joint.d.ts

@@ -1,10 +1,10 @@
 // https://github.com/tc39/proposal-joint-iteration
 
-type ZipOptions = {
+interface ZipOptions {
   mode?: 'shortest' | 'longest' | 'strict';
 
   padding?: object;
-};
+}
 
 interface IteratorConstructor { // @type-options no-extends
   /**

packages/core-js-types/src/base/proposals/iterator-range.d.ts

@@ -1,10 +1,10 @@
 // https://github.com/tc39/proposal-iterator.range
 
-type IteratorRangeOptions<T> = {
+interface IteratorRangeOptions<T> {
   step?: T;
 
   inclusive?: boolean;
-};
+}
 
 interface IteratorConstructor { // @type-options no-extends
   /**

packages/core-js-types/src/base/pure/proposals/iterator.d.ts

@@ -27,17 +27,17 @@
 // License: https://github.com/microsoft/TypeScript/blob/v5.9.3/LICENSE.txt
 
 declare namespace CoreJS {
-  type ZipOptions = {
+  interface ZipOptions {
     mode?: 'shortest' | 'longest' | 'strict';
 
     padding?: object;
-  };
+  }
 
-  type IteratorRangeOptions<T> = {
+  interface IteratorRangeOptions<T> {
     step?: T;
 
     inclusive?: boolean;
-  };
+  }
 
   interface CoreJSPromiseLike<T> {
     /**

packages/core-js-types/src/ts5-2/pure/proposals/iterator.d.ts

@@ -27,17 +27,17 @@
 // License: https://github.com/microsoft/TypeScript/blob/v5.9.3/LICENSE.txt
 
 declare namespace CoreJS {
-  type ZipOptions = {
+  interface ZipOptions {
     mode?: 'shortest' | 'longest' | 'strict';
 
     padding?: object;
-  };
+  }
 
-  type IteratorRangeOptions<T> = {
+  interface IteratorRangeOptions<T> {
     step?: T;
 
     inclusive?: boolean;
-  };
+  }
 
   interface CoreJSPromiseLike<T> {
     /**

tests/eslint/eslint.config.js

@@ -1925,7 +1925,7 @@ const ts = {
   // require that function overload signatures be consecutive
   '@typescript-eslint/adjacent-overload-signatures': ERROR,
   // enforce type definitions to consistently use either `interface` or `type`
-  '@typescript-eslint/consistent-type-definitions': [OFF, 'interface'],
+  '@typescript-eslint/consistent-type-definitions': [ERROR, 'interface'],
   // disallow extra non-null assertions
   '@typescript-eslint/no-extra-non-null-assertion': ERROR,
   // enforce the use of top-level import type qualifier when an import only has specifiers with inline type qualifiers

tests/type-definitions/global/proposals/array-unique.test.ts

@@ -1,6 +1,9 @@
 import 'core-js/full';
 
-type Obj = { a: number; b: string };
+interface Obj {
+  a: number;
+  b: string
+}
 const arr: Obj[] = [{ a: 1, b: 'x' }, { a: 2, b: 'y' }];
 const arrRes: Obj[] = arr.uniqueBy();
 const arrRes2: Obj[] = arr.uniqueBy('a');

tests/type-definitions/global/proposals/decorator-metadata.test.ts

@@ -3,9 +3,9 @@ import 'core-js/full';
 const rsmd1: symbol = Symbol.metadata;
 const rsmd2: typeof Symbol.metadata = Symbol.metadata;
 
-type T = {
+interface T {
   [Symbol.metadata]?: object;
-};
+}
 
 const obj: T = {};
 obj[Symbol.metadata] = { foo: 1 };

tests/type-definitions/pure/proposals/array-unique.test.ts

@@ -1,6 +1,9 @@
 import arrayUniqueBy from '@core-js/pure/full/array/unique-by';
 
-type Obj = { a: number; b: string };
+interface Obj {
+  a: number;
+  b: string
+}
 const arr: Obj[] = [{ a: 1, b: 'x' }, { a: 2, b: 'y' }];
 const arrRes: Obj[] = arrayUniqueBy(arr);
 const arrRes2: Obj[] = arrayUniqueBy(arr, 'a');

tests/type-definitions/pure/proposals/decorator-metadata.test.ts

@@ -3,9 +3,9 @@ import metadata from '@core-js/pure/full/symbol/metadata';
 const rsmd1: symbol = metadata;
 const rsmd2: typeof metadata = metadata;
 
-type T = {
+interface T {
   [metadata]?: object;
-};
+}
 
 const obj: T = {};
 obj[metadata] = { foo: 1 };