Skip to content

Commit e822e3d

Browse files
committed
fix some assert messages
1 parent 12015c9 commit e822e3d

File tree

6 files changed

+9
-9
lines changed

6 files changed

+9
-9
lines changed

tests/unit-global/es.data-view.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ QUnit.test('DataView', assert => {
2929
assert.same(dataview.byteLength, 0, '#byteLength, passed buffer and byteOffset with buffer length');
3030
// TypeError in IE + FF bug - TypeError instead of RangeError
3131
assert.throws(() => new DataView(new ArrayBuffer(8), -1), RangeError, 'If offset < 0, throw a RangeError exception');
32-
assert.throws(() => new DataView(new ArrayBuffer(8), 16), RangeError, 'If newByteLength < 0, throw a RangeError exception');
32+
assert.throws(() => new DataView(new ArrayBuffer(8), 16), RangeError, 'If offset > bufferByteLength, throw a RangeError exception');
3333
assert.throws(() => new DataView(new ArrayBuffer(24), 8, 24), RangeError, 'If offset+newByteLength > bufferByteLength, throw a RangeError exception');
3434
assert.throws(() => new DataView(new ArrayBuffer(8), 0, -1), RangeError, 'negative byteLength throws RangeError');
3535
// Android ~ 4.0
@@ -38,7 +38,7 @@ QUnit.test('DataView', assert => {
3838
} else {
3939
// FF bug - TypeError instead of RangeError
4040
assert.throws(() => new DataView(new ArrayBuffer(8), -1), 'If offset < 0, throw a RangeError exception');
41-
assert.throws(() => new DataView(new ArrayBuffer(8), 16), 'If newByteLength < 0, throw a RangeError exception');
41+
assert.throws(() => new DataView(new ArrayBuffer(8), 16), 'If offset > bufferByteLength, throw a RangeError exception');
4242
assert.throws(() => new DataView(new ArrayBuffer(24), 8, 24), 'If offset+newByteLength > bufferByteLength, throw a RangeError exception');
4343
assert.throws(() => new DataView(new ArrayBuffer(8), 0, -1), 'negative byteLength throws');
4444
}

tests/unit-global/es.iterator.concat.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,12 +43,12 @@ QUnit.test('Iterator.concat', assert => {
4343

4444
iterator = concat(createIterable([1, 2, 3]));
4545
assert.deepEqual(iterator.return(), { done: true, value: undefined }, '.return with no active inner iterator result');
46-
assert.deepEqual(iterator.next(), { done: true, value: undefined }, '.return with no active inner iterator result on closed iterator');
46+
assert.deepEqual(iterator.next(), { done: true, value: undefined }, '.next on closed iterator');
4747

4848
iterator = concat(createIterable([1, 2, 3]));
4949
assert.deepEqual(iterator.next(), { done: false, value: 1 }, '.next with active inner iterator result');
5050
assert.deepEqual(iterator.return(), { done: true, value: undefined }, '.return with active inner iterator result');
51-
assert.deepEqual(iterator.next(), { done: true, value: undefined }, '.return with active inner iterator result on closed iterator');
51+
assert.deepEqual(iterator.next(), { done: true, value: undefined }, '.next on closed iterator after .return with active inner iterator');
5252

5353
let called = false;
5454
iterator = concat(createIterable([1, 2, 3], {

tests/unit-global/es.string.split.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ const run = assert => {
6262
assert.arrayEqual('tesst'.split(/(s)*?/), ['t', undefined, 'e', undefined, 's', undefined, 's', undefined, 't'], "'tesst'.split(/(s)*?/) results in ['t', undefined, 'e', undefined, 's', undefined, 's', undefined, 't']");
6363
assert.arrayEqual('tesst'.split(/(s*)/), ['t', '', 'e', 'ss', 't'], "'tesst'.split(/(s*)/) results in ['t', '', 'e', 'ss', 't']");
6464
assert.arrayEqual('tesst'.split(/(s*?)/), ['t', '', 'e', '', 's', '', 's', '', 't'], "'tesst'.split(/(s*?)/) results in ['t', '', 'e', '', 's', '', 's', '', 't']");
65-
assert.arrayEqual('tesst'.split(/s*/), ['t', 'e', 't'], "'tesst'.split(/(?:s)*/) results in ['t', 'e', 't']");
65+
assert.arrayEqual('tesst'.split(/s*/), ['t', 'e', 't'], "'tesst'.split(/s*/) results in ['t', 'e', 't']");
6666
assert.arrayEqual('tesst'.split(/(?=s+)/), ['te', 's', 'st'], "'tesst'.split(/(?=s+)/) results in ['te', 's', 'st']");
6767
assert.arrayEqual('test'.split('t'), ['', 'es', ''], "'test'.split('t') results in ['', 'es', '']");
6868
assert.arrayEqual('test'.split('es'), ['t', 't'], "'test'.split('es') results in ['t', 't']");

tests/unit-global/esnext.async-iterator.from.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ QUnit.test('AsyncIterator.from', assert => {
4141
}).then(() => {
4242
assert.avoid();
4343
}, error => {
44-
assert.same(error, 42, 'rejection on a callback error');
44+
assert.same(error, 42, 'rejection on a `.next()` promise rejection');
4545
assert.true(closableIterator.closed, 'closes sync iterator on promise rejection');
4646
});
4747
});

tests/unit-pure/es.iterator.concat.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,12 +42,12 @@ QUnit.test('Iterator.concat', assert => {
4242

4343
iterator = concat(createIterable([1, 2, 3]));
4444
assert.deepEqual(iterator.return(), { done: true, value: undefined }, '.return with no active inner iterator result');
45-
assert.deepEqual(iterator.next(), { done: true, value: undefined }, '.return with no active inner iterator result on closed iterator');
45+
assert.deepEqual(iterator.next(), { done: true, value: undefined }, '.next on closed iterator');
4646

4747
iterator = concat(createIterable([1, 2, 3]));
4848
assert.deepEqual(iterator.next(), { done: false, value: 1 }, '.next with active inner iterator result');
4949
assert.deepEqual(iterator.return(), { done: true, value: undefined }, '.return with active inner iterator result');
50-
assert.deepEqual(iterator.next(), { done: true, value: undefined }, '.return with active inner iterator result on closed iterator');
50+
assert.deepEqual(iterator.next(), { done: true, value: undefined }, '.next on closed iterator after .return with active inner iterator');
5151

5252
let called = false;
5353
iterator = concat(createIterable([1, 2, 3], {

tests/unit-pure/esnext.async-iterator.from.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ QUnit.test('AsyncIterator.from', assert => {
4444
}).then(() => {
4545
assert.avoid();
4646
}, error => {
47-
assert.same(error, 42, 'rejection on a callback error');
47+
assert.same(error, 42, 'rejection on a `.next()` promise rejection');
4848
assert.true(closableIterator.closed, 'closes sync iterator on promise rejection');
4949
});
5050
});

0 commit comments

Comments
 (0)